Bug 149414 - Change submenu label for formatting textboxes and shapes in Calc and Impress
Summary: Change submenu label for formatting textboxes and shapes in Calc and Impress
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.5.0 target:7.4....
Keywords:
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2022-06-01 00:36 UTC by sdc.blanco
Modified: 2022-12-28 10:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-06-01 00:36:24 UTC
In Calc: Format > OLE Object (using.uno:ObjectMenu), 
In Impress: Format > "Object and Shape" (using .uno:FormatObjectMenu).

Proposal: 
  1. Change Label of .uno:FormatObjectMenu
  from "Object and Shape" -> "Text Box and Shape"
       (a) to be consistent with Writer,
       (b) because the contents of its submenu are applied
           only to Text Boxes and Shapes.

  2. Change in Calc, .uno:ObjectMenu to .uno:FormatObjectMenu 
     for its Format menu.
       (a) will make its label consistent with Writer and Impress
       (b) the contents of its submenu is for editing properties of text boxes
           and shapes, not OLE Objects, so the label will be more appropriate.

https://gerrit.libreoffice.org/c/core/+/135162
Comment 1 Heiko Tietze 2022-06-01 08:12:07 UTC
(In reply to sdc.blanco from comment #0)
>        (b) because the contents of its submenu are applied
>            only to Text Boxes and Shapes.

Insert > Object > Formula - and change the background via this menu and Area. Or set the position for a bar code.

I never struggled with "Object and Shape".


(In reply to sdc.blanco from comment #0)
>   2. Change in Calc, .uno:ObjectMenu to .uno:FormatObjectMenu 

.uno:ObjectMenue I guess. What is the difference between the two?

Btw, WriterCommands redefines uno:FormatObjectMenu

  <value xml:lang="en-US">Text Box and Shap~e</value>

it's in GenericCommands as

  <value xml:lang="en-US">~Object and Shape</value>
Comment 2 sdc.blanco 2022-06-01 09:45:50 UTC
(In reply to Heiko Tietze from comment #1)
> I never struggled with "Object and Shape".
Ack. Reasons for change are:  (a) trying not to use the generic "object" in the UI (in part because "object" ≠ "OLE object, such as noted in bug 149018) and (b) consistency across modules. 

> .uno:ObjectMenue I guess. What is the difference between the two?
Edit > OLE Object (in all modules) is .uno:ObjectMenue  (e=Edit)
 
> it's in GenericCommands as
>   <value xml:lang="en-US">~Object and Shape</value>
That is what the patch in OP changed.

Alternative solutions:
1. Leave "Object and Shape" unchanged in Impress, and use that label in Calc as well.

2. Leave "Object and Shape" unchanged in Impress, and make a pseudo .uno for Calc with "TargetURL" with a different label (e.g., "Text Box and Shape")

No strong opinion in any direction, beyond the following main issue that motivated this ticket:

- Calc should be changed (because Format > OLE Object is wrong.  
- The obvious .uno for Calc is in GenericCommands and used already in Impress.
- If consistency across modules is not important here, then maybe just take
    the Alternative Solution 1.
Comment 3 Heiko Tietze 2022-06-01 10:24:33 UTC
The Writer-specific command was introduced resp. derived from Generic with https://gerrit.libreoffice.org/c/core/+/20167/ for bug 91781. If all modules use the same label you can just delete it from WriterCommands.

It was split in https://gerrit.libreoffice.org/c/core/+/20630 probably to deal with the fact that Draw/Impress has one more option.
Comment 4 sdc.blanco 2022-06-03 11:08:38 UTC
Hoping for some resolution here -- even if WF -- because has implications for updating the help pages in relation to bug 126658.
Comment 5 Heiko Tietze 2022-06-09 05:54:01 UTC
We discussed the topic in the design meeting.

The need to change this becomes obvious after comparing Insert > OLE Object with Format > Object, which are different functions. The proposed "Text Box and Shape" sounds good.
Comment 6 Commit Notification 2022-06-09 07:20:27 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/64b5eb228625f4da6368be3e7ec93e68cf74605d

tdf#149414 change Format Object label for Calc and Impress

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-06-16 18:03:57 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/51cfc9a957eec7be595e8b667a528cbe749992a0

(related) tdf#149414 change in Impress Format menu command name
Comment 8 Commit Notification 2022-06-16 18:11:11 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/help/commit/907f876a9a0ab822fe6a67ab779ca03f4134e4d5

(related) tdf#149414 change in Impress Format menu command name
Comment 9 Stéphane Guillou (stragu) 2022-12-28 10:34:25 UTC
Fix verified in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Seth!