Bug 149418 - FILESAVE: TIFFFetchDirectory: libtiff-svstream: Seek error accessing TIFF directory.
Summary: FILESAVE: TIFFFetchDirectory: libtiff-svstream: Seek error accessing TIFF dir...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-06-01 08:58 UTC by Xisco Faulí
Modified: 2022-06-02 10:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison before and after RT (973.77 KB, image/png)
2022-06-01 08:58 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-06-01 08:58:19 UTC
Created attachment 180514 [details]
Comparison before and after RT

Steps to reproduce:
1. Open attachment 46857 [details] from bug 37311
2. Save it to ODP or PPTX
3. Reopen

-> The coat of arms is gone. See comparison. Error in console:

TIFFFetchDirectory: libtiff-svstream: Seek error accessing TIFF directory.
TIFFReadDirectory: Failed to read directory at offset 393802.


Reproduced in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: c3baf2a7f48b5ee46c6792b3106cb4fedb4a2ad2
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2022-06-01 08:59:03 UTC
Started to happen after

author	Caolán McNamara <caolanm@redhat.com>	2022-05-19 17:11:23 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2022-05-21 11:52:30 +0200
commit 22b50f1937de67e4ad9e692d6964aa5b8d33af7a (patch)
tree 22bdeb790811b0eeabaa918ad681d859c7ee9ff4
parent d05b8080b25877e94d54576744b68f01ae775380 (diff)
use libtiff for tiff import

bisected with: bibisect-linux64-7.4

Adding Cc: to Caolán McNamara
Comment 2 Caolán McNamara 2022-06-01 18:59:35 UTC
I wonder how on earth has the import affected the export in this way
Comment 3 Caolán McNamara 2022-06-01 19:29:29 UTC
aha, the final tiff is meant to be the original data and the assumption is that the stream is seeked to the end of the tiff data on success.

https://gerrit.libreoffice.org/c/core/+/135279
Comment 4 Commit Notification 2022-06-02 08:01:55 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1577c0dc30ed3c9db361fb989e41a3e9d6c45dfa

tdf#149418 the expectation is on success the tiff stream pos is at EOF

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-06-02 10:38:36 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f6fbdb87a15f7de97e18676560eeba988fac1b67

tdf#149418: vcl_filters_test: Add unittest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.