Bug 150007 - Use the GTK3 / GTK4 "suggested-action" CSS class for the "Find Next" button in the "Find and Replace" dialog to visually indicate it is receiving the default action
Summary: Use the GTK3 / GTK4 "suggested-action" CSS class for the "Find Next" button i...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: All Linux (All)
: medium enhancement
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0 target:7.5.0.0.beta2 tar...
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2022-07-15 18:07 UTC by Jeff Fortin Tam
Modified: 2022-12-13 11:23 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2022-07-15 18:07:12 UTC
In the Find & Replace dialog that shows up when you do ctrl+H in Calc/Writer/etc., it is not visually obvious what the result of the "Enter" keyboard shortcut would be, which can be a bit intimidating to new (or forgetful) users. The user might think, "if I think Enter, will it just find something, or do a replacement, or something else?"

An easy solution for that on platforms where a GTK backend is used is to use the "suggested-action" CSS class on the "Find Next" button, which would make it blue, clearly indicating it is the default and preferred/main action in the dialog. See also https://docs.gtk.org/gtk3/const.STYLE_CLASS_SUGGESTED_ACTION.html

(Conversely, "destructive-action" exists, but both should not be used at the same time, and I see suggested-action as more relevant in this dialog).
Comment 1 Caolán McNamara 2022-11-07 20:00:19 UTC
we do have support suggested-action so it is possible
Comment 2 Commit Notification 2022-11-08 08:17:50 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a4c8f05c760328177bb6056750aab53432a3a506

Resolves: tdf#150007 add suggested-action to "find next"

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Stéphane Guillou (stragu) 2022-12-13 07:47:25 UTC
Fix verified in:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Caolán!
Comment 4 Commit Notification 2022-12-13 10:32:04 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/635a335de2eb8a532d7427fcc52ab23cdc20bea4

Related: tdf#150007 add destructive-action to file overwrite message dialog

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-12-13 10:32:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6832a939623ad3b0ad61016344a432f47d1e97d

Related: tdf#150007 add destructive-action to file overwrite message dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-12-13 11:23:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/0614198babeeb48359c8363c1b098688ccb1406d

Related: tdf#150007 add destructive-action to file overwrite message dialog

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.