Bug 150008 - Use the GTK3 / GTK4 "destructive-action" CSS class for the unsaved changes confirmation dialogs
Summary: Use the GTK3 / GTK4 "destructive-action" CSS class for the unsaved changes co...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: All Linux (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2022-07-15 18:30 UTC by Jeff Fortin Tam
Modified: 2022-11-02 19:36 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2022-07-15 18:30:42 UTC
A bit like issue #15007 in reverse. Throughout LibreOffice, when you try to close a document with unsaved changes, the app prompts you with a confirmation dialog. On some platforms, it uses a GTK dialog to do so.

In that case, it should also apply the "destructive-action" CSS class/styling to the most dangerous button in that dialog, "Don't Save"

See also:
https://developer.gnome.org/hig/patterns/controls/buttons.html#button-styles
https://docs.gtk.org/gtk3/const.STYLE_CLASS_DESTRUCTIVE_ACTION.html
Comment 1 Caolán McNamara 2022-11-02 19:36:51 UTC
We do this already since 7.3, see sfx2/uiconfig/ui/querysavedialog.ui which is the general file save case. and under gtk the "Don't Save" is highlighted with the red danger background.

(also seen in svx/uiconfig/ui/deletefooterdialog.ui and 
svx/uiconfig/ui/deleteheaderdialog.ui which are undoable actions)