Description: Track changes: Crash rejecting a grouped change Steps to Reproduce: 1. Open attachment 180723 [details] 2. Edit -> Track Changes -> Manage 3. Scroll down the list of changes to find the first collapsed changes indicated with + symbol 4. Select the entry 5. Reject change Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c1446da82b999349e1a09fed3420bd1c38d7b38c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Regression introduced by: author László Németh <nemeth@numbertext.org> 2022-01-12 10:27:35 +0100 committer László Németh <nemeth@numbertext.org> 2022-01-12 14:29:28 +0100 commit eebe4747d2d13545004937bb0267ccfc8ab9d63f (patch) tree b8072db2a224f086fa1730dd895ecbf039af9f42 parent 439df74885ba9c24db3a1d417744acf4b3b6c48f (diff) tdf#144270 sw: manage tracked table (row) deletion/insertion Bisected with: bibisect-linux64-7.4 Adding Cc: to László Németh
Created attachment 181813 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. (remark: I don't have a "+" but a triangle to indicated the list can be expanded).
Also on console, I noticed a lot of these: warn:sw:98465:98465:sw/source/core/doc/DocumentRedlineManager.cxx:109: redline table corrupted: overlapping redlines
Crash+regression+all envs => let's increase importance.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4668540ff7256bb0ddd382dfaf9f3499e99128a tdf#150443 sw: fix crash of rejecting table row deletion It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Commit description: tdf#150443 sw: fix crash of rejecting table row deletion Joining "Delete" redlines of deleted table row with overlapping tracked formatting change with same time stamp resulted bad tree parent in Manage Changes dialog window (tracked formatting change instead of tracked deletion, see its pencil icon before this fix), crashing at its rejection. Regression from commit eebe4747d2d13545004937bb0267ccfc8ab9d63f "tdf#144270 sw: manage tracked table (row) deletion/insertion".
@Telesto: thanks for the nice catch! @Xisco, Julien: thanks for bibisecting and backtracking!
On pc Debian x86-64 with master sources updated today, I confirm I don't reproduce the crash. Thank you László! Just for the record, there are still a lot of these: warn:sw:98465:98465:sw/source/core/doc/DocumentRedlineManager.cxx:109: redline table corrupted: overlapping redlines at the opening of the file but it's another story I suppose.
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/a91ad83e5eb83625ee0e1c9250365c5dc494f845 tdf#150443 sw: fix crash of rejecting table row deletion It will be available in 7.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: b323f1fba2a7a409177f5296c6ba8b98c9e537ad CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL
(In reply to Julien Nabet from comment #8) > Just for the record, there are still a lot of these: > warn:sw:98465:98465:sw/source/core/doc/DocumentRedlineManager.cxx:109: > redline table corrupted: overlapping redlines > at the opening of the file but it's another story I suppose. @Julien: the message is obsolete or incomplete: overlapping is allowed for formatting redlines, like here. Thanks for your feedback!
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2eba8bb8d43d39eb229a81947907e70f50859a76 tdf#150443: replace missing fonts in testfile It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/49cf2346861791b519f97b07a5973c1410e15a6a tdf#150443: replace missing fonts in testfile It will be available in 24.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/403abdc86af5f7ec145d14e2315493c510b1b869 disable part of tdf150443 UITest for now It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.