Bug 151016 - Start Center: Thumbnail filter: hamburger menu icon lacks contrast and does not adapt dark mode
Summary: Start Center: Thumbnail filter: hamburger menu icon lacks contrast and does n...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All macOS (All)
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.3
Keywords:
Depends on:
Blocks: macOS-Dark-Mode
  Show dependency treegraph
 
Reported: 2022-09-17 08:29 UTC by steve
Modified: 2022-10-16 11:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
dark (8.53 KB, image/png)
2022-09-17 08:29 UTC, steve
Details
hamburger menu icon low contrast (8.86 KB, image/png)
2022-09-17 08:30 UTC, steve
Details
hamburger menu icon low contrast, sukapura icons (442.71 KB, image/png)
2022-09-24 10:22 UTC, steve
Details
hamburger menu icon correct contrast, breeze icons (4.29 KB, image/png)
2022-09-24 10:35 UTC, steve
Details
sukapura hamburger menu icon sidebar correct (14.34 KB, image/png)
2022-09-24 11:14 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2022-09-17 08:29:03 UTC
Description:
Start Center: Thumbnail filter: hamburger menu icon lacks contrast and does not adapt dark mode.

Tested on macOS, thought probably all os.

Steps to Reproduce:
Look at start center thumbnail filter hamburger menu icon.

Actual Results:
Light grey on light grey with too little contrast.

Expected Results:
Icon with good contrast respecting dark and light mode, which btw the thumbnail filter bar does, and that is great.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a3bbdfab809609bec3475613a918eda699fbdc29
CPU threads: 8; OS: Mac OS X 12.6; UI render: default; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 1 steve 2022-09-17 08:29:44 UTC
Created attachment 182514 [details]
dark
Comment 2 steve 2022-09-17 08:30:01 UTC
Created attachment 182515 [details]
hamburger menu icon low contrast
Comment 3 Heiko Tietze 2022-09-19 07:41:45 UTC
It's a stock icon and should behave like any other on the system.
Comment 4 Caolán McNamara 2022-09-19 08:51:00 UTC
this is probably a duplicate of https://bugs.documentfoundation.org/show_bug.cgi?id=151017 and/or the fix there affects this
Comment 5 steve 2022-09-23 14:44:57 UTC
Fix is in and the poor visibility for hamburger menu is persisting due to the lack of contrast.
Comment 6 steve 2022-09-23 14:47:12 UTC
Adddendum: this is not about dark or light more (there is no dark mode on macOS and even dark application colors currently do not alter appearance of StartCenter.

Not sure what to expect here but if this is default icon behavior in regards to the colors used to display the icon this is not ideal.
Comment 7 Caolán McNamara 2022-09-23 15:00:16 UTC
This "Hamburger" menu button thing should also exist in the sidebar I think. How does it look there? I don't recall under macOS what icon-theme we pick by default, what is picked for tools, options, view, icon theme? maybe it's a specific icon that has a problem.
Comment 8 steve 2022-09-24 10:14:41 UTC
Comment on attachment 182514 [details]
dark

removed dark mode screenshot. There is no dark mode for Start Center on macOS.
Comment 9 steve 2022-09-24 10:22:45 UTC
Created attachment 182656 [details]
hamburger menu icon low contrast, sukapura icons
Comment 10 steve 2022-09-24 10:35:11 UTC
Created attachment 182657 [details]
hamburger menu icon correct contrast, breeze icons

Sukapura is the default icon set for macOS. The screenshot was created using that icon theme.

Switching to breeze and the hamburger menu icon shows with expected contrast. So issue is icon theme related.
Comment 11 steve 2022-09-24 10:36:26 UTC
Cáolan: wherein the left sidebar panel would you like to place that icon?
Comment 12 steve 2022-09-24 11:14:54 UTC
Created attachment 182660 [details]
sukapura hamburger menu icon sidebar correct

@Cáolan: sorry it just clicked, what you mean with sidebar, I was so focussed on StartCenter, I forgot about the actual sidebar in LO 😬

And yes, using Sukapura, the icon shows correctly in sidebar (see screenshot), so the contrast issue with the same icon seems limited to StartCenter.
Comment 13 Caolán McNamara 2022-09-25 11:05:54 UTC
This icon is icon-themes/sukapura/sfx2/res/menu.png

caolanm->rizmut: Maybe the bars are a little faint?
Comment 14 Rafael Lima 2022-10-10 23:17:38 UTC
The problem is not with the icon, but to the fact that in startcenter.ui a fixed icon name is used (open-menu-symbolic).

Changing it to a "File name" -> sfx2/res/menu.png will make it work.

Just one thing... it seems this icon does not exist for Breeze (dark).
Comment 15 Rafael Lima 2022-10-10 23:18:36 UTC
Here's what I tested:

diff --git a/sfx2/uiconfig/ui/startcenter.ui b/sfx2/uiconfig/ui/startcenter.ui
index 8120556f3d22..9a89de6f099a 100644
--- a/sfx2/uiconfig/ui/startcenter.ui
+++ b/sfx2/uiconfig/ui/startcenter.ui
@@ -38,7 +38,7 @@
   <object class="GtkImage" id="imActions">
     <property name="visible">True</property>
     <property name="can-focus">False</property>
-    <property name="icon-name">open-menu-symbolic</property>
+    <property name="pixbuf">sfx2/res/menu.png</property>
     <property name="icon_size">3</property>
   </object>
   <object class="GtkImage" id="impress_all_image">
Comment 16 Heiko Tietze 2022-10-11 07:04:36 UTC
(In reply to Rafael Lima from comment #15)
> -    <property name="icon-name">open-menu-symbolic</property>
> +    <property name="pixbuf">sfx2/res/menu.png</property>

Go for it.
Comment 17 Rizal Muttaqin 2022-10-11 07:10:00 UTC
(In reply to Rafael Lima from comment #14)
> The problem is not with the icon, but to the fact that in startcenter.ui a
> fixed icon name is used (open-menu-symbolic).
> 
> Changing it to a "File name" -> sfx2/res/menu.png will make it work.
> 
> Just one thing... it seems this icon does not exist for Breeze (dark).

Won't this change ignore SVG version?
Comment 18 Rizal Muttaqin 2022-10-11 07:11:43 UTC
Sorry, just ignore previous comment, others use .png as well.
Comment 19 Caolán McNamara 2022-10-11 08:00:28 UTC
For gen, which is where the problem is apparently reported, "open-menu-symbolic" is already mapped to sfx2/res/menu.png (vcl/inc/bitmaps.hlst IMG_MENU (used by vcl/source/window/builder.cxx)
Comment 20 Rizal Muttaqin 2022-10-11 08:45:07 UTC
(In reply to Caolán McNamara from comment #13)
> This icon is icon-themes/sukapura/sfx2/res/menu.png
> 
> caolanm->rizmut: Maybe the bars are a little faint?

So this is valid likely
Comment 21 Commit Notification 2022-10-11 13:50:14 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4b4160cb1aab3ab1ff8eec6b2736bf459afed408

tdf#151016 Fix paint hamburger icons in Start Center (Sukapura)

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Caolán McNamara 2022-10-12 08:16:51 UTC
done in trunk, backport tp 7-4 in gerrit
Comment 23 Commit Notification 2022-10-12 09:05:19 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a0892b1e404bc6b691fb7f6ad3b7520925786734

tdf#151016 Fix paint hamburger icons in Start Center (Sukapura)

It will be available in 7.4.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 steve 2022-10-16 11:59:14 UTC
verified - thanks Rizal.
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063
CPU threads: 8; OS: Mac OS X 12.6; UI render: default; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded