Description: Start Center: Thumbnail filter: hamburger menu icon lacks contrast and does not adapt dark mode. Tested on macOS, thought probably all os. Steps to Reproduce: Look at start center thumbnail filter hamburger menu icon. Actual Results: Light grey on light grey with too little contrast. Expected Results: Icon with good contrast respecting dark and light mode, which btw the thumbnail filter bar does, and that is great. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a3bbdfab809609bec3475613a918eda699fbdc29 CPU threads: 8; OS: Mac OS X 12.6; UI render: default; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded
Created attachment 182514 [details] dark
Created attachment 182515 [details] hamburger menu icon low contrast
It's a stock icon and should behave like any other on the system.
this is probably a duplicate of https://bugs.documentfoundation.org/show_bug.cgi?id=151017 and/or the fix there affects this
Fix is in and the poor visibility for hamburger menu is persisting due to the lack of contrast.
Adddendum: this is not about dark or light more (there is no dark mode on macOS and even dark application colors currently do not alter appearance of StartCenter. Not sure what to expect here but if this is default icon behavior in regards to the colors used to display the icon this is not ideal.
This "Hamburger" menu button thing should also exist in the sidebar I think. How does it look there? I don't recall under macOS what icon-theme we pick by default, what is picked for tools, options, view, icon theme? maybe it's a specific icon that has a problem.
Comment on attachment 182514 [details] dark removed dark mode screenshot. There is no dark mode for Start Center on macOS.
Created attachment 182656 [details] hamburger menu icon low contrast, sukapura icons
Created attachment 182657 [details] hamburger menu icon correct contrast, breeze icons Sukapura is the default icon set for macOS. The screenshot was created using that icon theme. Switching to breeze and the hamburger menu icon shows with expected contrast. So issue is icon theme related.
Cáolan: wherein the left sidebar panel would you like to place that icon?
Created attachment 182660 [details] sukapura hamburger menu icon sidebar correct @Cáolan: sorry it just clicked, what you mean with sidebar, I was so focussed on StartCenter, I forgot about the actual sidebar in LO 😬 And yes, using Sukapura, the icon shows correctly in sidebar (see screenshot), so the contrast issue with the same icon seems limited to StartCenter.
This icon is icon-themes/sukapura/sfx2/res/menu.png caolanm->rizmut: Maybe the bars are a little faint?
The problem is not with the icon, but to the fact that in startcenter.ui a fixed icon name is used (open-menu-symbolic). Changing it to a "File name" -> sfx2/res/menu.png will make it work. Just one thing... it seems this icon does not exist for Breeze (dark).
Here's what I tested: diff --git a/sfx2/uiconfig/ui/startcenter.ui b/sfx2/uiconfig/ui/startcenter.ui index 8120556f3d22..9a89de6f099a 100644 --- a/sfx2/uiconfig/ui/startcenter.ui +++ b/sfx2/uiconfig/ui/startcenter.ui @@ -38,7 +38,7 @@ <object class="GtkImage" id="imActions"> <property name="visible">True</property> <property name="can-focus">False</property> - <property name="icon-name">open-menu-symbolic</property> + <property name="pixbuf">sfx2/res/menu.png</property> <property name="icon_size">3</property> </object> <object class="GtkImage" id="impress_all_image">
(In reply to Rafael Lima from comment #15) > - <property name="icon-name">open-menu-symbolic</property> > + <property name="pixbuf">sfx2/res/menu.png</property> Go for it.
(In reply to Rafael Lima from comment #14) > The problem is not with the icon, but to the fact that in startcenter.ui a > fixed icon name is used (open-menu-symbolic). > > Changing it to a "File name" -> sfx2/res/menu.png will make it work. > > Just one thing... it seems this icon does not exist for Breeze (dark). Won't this change ignore SVG version?
Sorry, just ignore previous comment, others use .png as well.
For gen, which is where the problem is apparently reported, "open-menu-symbolic" is already mapped to sfx2/res/menu.png (vcl/inc/bitmaps.hlst IMG_MENU (used by vcl/source/window/builder.cxx)
(In reply to Caolán McNamara from comment #13) > This icon is icon-themes/sukapura/sfx2/res/menu.png > > caolanm->rizmut: Maybe the bars are a little faint? So this is valid likely
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4b4160cb1aab3ab1ff8eec6b2736bf459afed408 tdf#151016 Fix paint hamburger icons in Start Center (Sukapura) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
done in trunk, backport tp 7-4 in gerrit
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/a0892b1e404bc6b691fb7f6ad3b7520925786734 tdf#151016 Fix paint hamburger icons in Start Center (Sukapura) It will be available in 7.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
verified - thanks Rizal. Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063 CPU threads: 8; OS: Mac OS X 12.6; UI render: default; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded