Bug 118017 (macOS-Dark-Mode) - [META] macOS Dark Mode bugs and enhancements
Summary: [META] macOS Dark Mode bugs and enhancements
Status: NEW
Alias: macOS-Dark-Mode
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All macOS (All)
: medium enhancement
Assignee: Not Assigned
URL: https://developer.apple.com/design/hu...
Whiteboard:
Keywords: needsDevAdvice
: 130714 136425 148232 (view as bug list)
Depends on: 148505 152184 152263 152284 131286 151016 151017 151389 152183 152253 152262 152270 152317
Blocks: MacOS-Wishlist UI-Theming Desktop-Integration
  Show dependency treegraph
 
Reported: 2018-06-05 18:11 UTC by steve
Modified: 2022-11-30 15:27 UTC (History)
18 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
german pdf print of geo article against short sightedness (532.30 KB, application/pdf)
2020-04-02 09:37 UTC, paulystefan
Details
science black background against short sightedness (3.54 MB, application/pdf)
2020-04-02 09:45 UTC, paulystefan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2018-06-05 18:11:32 UTC
Description:
macOS 10.14 brings native dark mode. Not sure how this is integrated, but with a developer account for Apple, it should be possible to find out, how they are planning to deal with third party apps and which exact steps devs have to take to support this.

Steps to Reproduce:
macOS 10.14 dark mode but LO does not support it when switched to.

Actual Results:  
No dark mode on macOS.

Expected Results:
Support for dark mode.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 steve 2018-07-08 10:07:36 UTC
Interesting thoughts on dark mode from dev perspective:
https://mackuba.eu/2018/07/04/dark-side-mac-1/
Comment 2 Ariel 2019-08-09 13:38:04 UTC
+1

As of 6.3, there also doesn't seem to be any simple way to even manually change UI items 'consistently' to any desired tone/background.

E.g., Preferences > Personalization > select the dark gray box: background of the menu bar changes, but nothing else (application background and side bar remain light). Manually changing App Colors > application background > dark grey fixes the app background but the sidebar remains light gray = eye sore :)
Comment 3 Pedro 2019-12-08 12:52:23 UTC
Just an FYI.
NeoOffice, a fork of LibreOffice which is Mac specific, and available in the App Store supports Mac dark theme.
Not only that but it also has multiple Mac specific improvements.

https://www.neooffice.org/neojava/en/index.php

It is licensed under GPL3 as LO, so maybe we could bring their code to mainline LO.
Comment 4 V Stuart Foote 2020-02-17 00:58:59 UTC
*** Bug 130714 has been marked as a duplicate of this bug. ***
Comment 5 paulystefan 2020-04-02 09:37:55 UTC Comment hidden (off-topic)
Comment 6 paulystefan 2020-04-02 09:45:43 UTC Comment hidden (off-topic)
Comment 7 paulystefan 2020-04-02 09:56:10 UTC Comment hidden (off-topic)
Comment 8 steve 2020-05-17 09:25:10 UTC
@stefan: "Changing priority to 'high' since the number of duplicates is higher than 5 or the number of people in CC higher than 20" was reasoning for changing priority for windows bug. This bug here currently has 10 cc and one dupe so not matching that criteria.

Would love to see LO behave smart and follow the system default. It's possibel to get to an okayish dark mode on macOS if you adjust Preferences > View Icon Style, Preferences > Personalization and Preferences > Application Colors.

That seems fairly simple, although this should be automated and two defaults (light / dark) should be defined and applied according to macOS system setting with option to choose light / dark overruling the system pref.

But I am pretty sure design team is aware and the dev resources are very thin, so not sure when this will be implemented.
Comment 9 Julien Nabet 2020-09-03 09:15:22 UTC
*** Bug 136425 has been marked as a duplicate of this bug. ***
Comment 10 paulystefan 2021-07-10 12:39:59 UTC
@steve: "Changing priority to 'high' since the number of duplicates is higher than 5 or the number of people in CC higher than 20" was the reasoning for changing priority for windows bug. This bug here currently has 10cc and one dupe so not matching those criteria.

How many Mac bugs are with high priority by all mac bugs? 0%, 1%, one of thousand?
There are 10 times more users in Linux and windows.

So there is another level system of importance for bugs depending on the distribution like here macOS necessary.

Without other system bugs like this goes to a forever state.

Here is hope because the depending windows bug is in the high state.
Comment 11 Michael Warner 2021-11-10 18:53:19 UTC
(In reply to Pedro from comment #3)

> It is licensed under GPL3 as LO, so maybe we could bring their code to
> mainline LO.

LO is Mozilla Public License 2 --- and as far as I know it wants to stay that way --- so we certainly cannot drop GPL code into it. Other GPL components we use  are built as separate executables and then have some sort of IPC communication or we read their output files or something like that, but techniques like this won't be useful for adding in dark mode support.
Comment 12 Pedro 2022-03-17 11:13:47 UTC
https://developer.apple.com/documentation/uikit/appearance_customization/supporting_dark_mode_in_your_interface

Documentation from Apple's developer guide to add Dark mode support. Maybe this might be useful?
Comment 13 V Stuart Foote 2022-03-28 13:21:23 UTC
*** Bug 148232 has been marked as a duplicate of this bug. ***
Comment 14 dhina 2022-03-28 14:57:20 UTC
This is more than about dark mode 'enhancement', LibreOffice should either find a way to dismiss macOS dark mode entirely or support it, but not half way between. Indeed, if the macOS settings are in dark mode, then:

- the LO default background color is black, but not in Slide Show mode. Then all the default color text are illegible.
- the LO default text color is black, but not when the cursor is clicked in the text box, which makes the reading very difficult when editing slides.

Then, it is not possible to use Presentation anymore for these reasons. It is a quite major issue. The only solution to keep using LO is to change the entire macOS setting to 'light mode', which is a lot to ask for a single application.

So I think someone with the appropriate admin rights should change the "importance" of this bug from "enhancement" to "major".



Thanks,

Steps to Reproduce:
1. MacOS preference > General > Appearance > Dark
2. Open a new presentation in LibreOffice
3. Write something in the slide title
3bis. Slide Show > Start from first slide

Actual Results:
3. It change the white text color to dark grey which is very difficult to read

3bis. in presentation mode, the dark background is white, so all your white text are not readible.

Expected Results:
3. It should keep a light color to be readible in dark mode

3bis. The background should be black
Comment 15 V Stuart Foote 2022-03-28 15:47:22 UTC
Sorryu, it is still an enhancement requiring refactoring and API implementation of new native macOS theme handling introduced at macOS 10.14 Mojave. 

Additionally we can expect that as Apple moves forward with deprecation of Quartz (for OpenGL and the MoltanVK we need for Vulkan) there will likely be other more pressing issues than supporting macOS 'Dark Mode'.
Comment 16 dhina 2022-03-29 12:00:05 UTC
Presentation does not properly take MacOS's dark mode into consideration(In reply to dhina from comment #14)
> This is more than about dark mode 'enhancement', LibreOffice should either
> find a way to dismiss macOS dark mode entirely or support it, but not half
> way between. Indeed, if the macOS settings are in dark mode, then:
> 
> - the LO default background color is black, but not in Slide Show mode. Then
> all the default color text are illegible.
> - the LO default text color is black, but not when the cursor is clicked in
> the text box, which makes the reading very difficult when editing slides.
> 
> Then, it is not possible to use Presentation anymore for these reasons. It
> is a quite major issue. The only solution to keep using LO is to change the
> entire macOS setting to 'light mode', which is a lot to ask for a single
> application.
> 
> So I think someone with the appropriate admin rights should change the
> "importance" of this bug from "enhancement" to "major".
> 
> 
> 
> Thanks,
> 
> Steps to Reproduce:
> 1. MacOS preference > General > Appearance > Dark
> 2. Open a new presentation in LibreOffice
> 3. Write something in the slide title
> 3bis. Slide Show > Start from first slide
> 
> Actual Results:
> 3. It change the white text color to dark grey which is very difficult to
> read
> 
> 3bis. in presentation mode, the dark background is white, so all your white
> text are not readible.
> 
> Expected Results:
> 3. It should keep a light color to be readible in dark mode
> 
> 3bis. The background should be black

I resume what I have just written. My issue is actually not related to macOS dark mode, but to LO dark scheme. Actually my LO was set to Dark scheme, which I did not know. I don't have these issues if I set LO scheme to normal. Sorry about the confusion.
Comment 17 Pedro 2022-03-29 13:11:07 UTC
You should open a bug report requesting a toggle be added to the LibO options to toggle between Light and Dark modes, since that would be a different requirement.

Lack of MacOS dark mode isn't great, and it is one of the many problems with LibO. I would recommend you to use Neooffice if that's important for you. They are based on LibO, but have a functioning dark mode that cannot be used in LibO since it is released under a more restrictive license.
Comment 18 steve 2022-04-26 09:44:33 UTC
Since dark mode is most likely a process rather than a state as there will be a ton of related bugs and followup issues turning this into a meta bug for all things macOS dark mode.
Comment 19 steve 2022-11-23 09:45:52 UTC
Kudos to Caolán who took a huge step for dark mode on macOS in https://gerrit.libreoffice.org/c/core/+/141435

This is available in todays main build: https://dev-builds.libreoffice.org/daily/master/current.html

It would be great if we all could give it a try and file new issues about the remaining problems and link those in the "Depends on:" section of this meta-bug here.
Comment 20 Pedro 2022-11-23 09:51:36 UTC
This is amazing. Thank you Caolan!
If I had a Mac I would test run and help submit bugs to polish the dark version of MacOS.