Bug 153949 - Widgets and buttons unreadable in dark mode after printing on macOS
Summary: Widgets and buttons unreadable in dark mode after printing on macOS
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0 target:7.5.3 target:7.5.2.2
Keywords:
Depends on:
Blocks: macOS-Dark-Mode
  Show dependency treegraph
 
Reported: 2023-03-03 19:04 UTC by Axel Bock
Modified: 2023-03-17 12:25 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
page properties dialog using dark mode after a while (178.60 KB, image/png)
2023-03-03 19:04 UTC, Axel Bock
Details
Unreadable dialog box (47.25 KB, image/png)
2023-03-16 11:38 UTC, Wim M
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Bock 2023-03-03 19:04:40 UTC
Created attachment 185735 [details]
page properties dialog using dark mode after a while

steps to reproduce:

- mac switches to dark mode based on time in sytem preferences
- open libreoffice write document
- open format -> page properties dialog (all looks just fine)
- do some stuff ... not clear which, i tried printing a couple of pages
- open page properties again
- it looks like in the attachment


expected result:

an actually readable dialog
Comment 1 steve 2023-03-14 10:51:32 UTC Comment hidden (obsolete)
Comment 2 steve 2023-03-14 19:08:49 UTC
I saw this in 7.5.x thus setting to new. This is not a dupe as this problem here seems different from the white on white buttons in the notification banner.
Comment 3 steve 2023-03-14 19:12:48 UTC
There was speculation that this issue here could be triggered when having the mac set to automatically switch between light and dark mode for day / night. But this does not apply to my setup (dark mode only), so that is likely not the cause for the problem.
Comment 4 Caolán McNamara 2023-03-14 20:02:49 UTC
wrt https://bugs.documentfoundation.org/show_bug.cgi?id=153416#c20 I wonder if this is still reproducible with a recent daily build to see if the change mentioned there made any difference.
Comment 5 Wim M 2023-03-16 11:38:20 UTC
Created attachment 185994 [details]
Unreadable dialog box

Confirming this bug on the most recent release (7.5.1.2). The text in dialog boxes has become unreadable even though initially this was not the case.

I have my Mac set to dark mode permanently, so the day-night change is not relevant in my case. However, it did only occur for the first time after I had printed a document, while I also have Skia/Metal switched on. Not sure if either is relevant, but in https://bugs.documentfoundation.org/show_bug.cgi?id=153416#c20 Patrick Luby noted that his patch resets the settings after printing so if that patch is not in 7.5.1.2, it might fix this. I am unfortunately not able to test a nightly build to see if it still occurs.

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Metal; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 6 Stéphane Guillou (stragu) 2023-03-16 12:51:20 UTC
(In reply to Wim M from comment #5)

> I have my Mac set to dark mode permanently, so the day-night change is not
> relevant in my case. However, it did only occur for the first time after I
> had printed a document

Thank you for that, Wim, I could reproduce with these exact steps:

1. Dark Mode for macOS
2. Open Writer, go to Format > Page style: dialog is readable
3. File > Print, send a job to a printer
4. Format > Page style: unreadable fields and buttons (but same can already be seen with the size and font selection dropdowns)

Tested on macOS 13.2.1 with LO 7.5.0.3

Now to test a daily build to see if 57b88be1e10e131aea429e205fd426b7dab2ba2d fixed it.
Comment 7 Stéphane Guillou (stragu) 2023-03-16 13:10:56 UTC
Yes, it is fixed in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5da513c1f34f657f910d2a9d1af7761cf649574f
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I'm going to assume this was said commit 57b88be1e10e131aea429e205fd426b7dab2ba2d, by Patrick. Thanks Patrick!

I added the 7.6 target, not sure yet which 7.5 point-release will get it.
Comment 8 Wim M 2023-03-16 14:14:02 UTC
Thanks for confirming and for checking the nightlies, Stéphane. Would indeed be good to get Patrick's patch into the 7.5 branch as well since printing is probably a fairly common activity among LO users.
Comment 9 Patrick (volunteer) 2023-03-16 14:39:46 UTC
(In reply to Wim M from comment #8)
> Thanks for confirming and for checking the nightlies, Stéphane. Would indeed
> be good to get Patrick's patch into the 7.5 branch as well since printing is
> probably a fairly common activity among LO users.

The fix just got committed and should be included starting in the next LibreOffice 7.5.2 Release Candidate:

https://gerrit.libreoffice.org/c/core/+/148698