Bug 152622 - Dashed edges in Impress slides are not visible in dark mode
Summary: Dashed edges in Impress slides are not visible in dark mode
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0 target:7.5.1 target:7.5.0
Keywords:
Depends on:
Blocks: macOS-Dark-Mode
  Show dependency treegraph
 
Reported: 2022-12-20 19:02 UTC by Rafael Lima
Modified: 2023-01-25 18:42 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot in light mode (OK) (39.18 KB, image/png)
2022-12-20 19:02 UTC, Rafael Lima
Details
Screenshot in dark mode (NOK) (31.47 KB, image/png)
2022-12-20 19:02 UTC, Rafael Lima
Details
macOS 2022-12-22 (33.32 KB, image/png)
2022-12-22 09:54 UTC, steve
Details
Darkmode - Printscreen - Impress (69.20 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-01-16 13:34 UTC, Sophie Sipasseuth
Details
New screenshot showing the problem (77.84 KB, image/png)
2023-01-17 17:08 UTC, Rafael Lima
Details
Screenshot of the proposed fix (41.41 KB, image/png)
2023-01-19 18:30 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-12-20 19:02:36 UTC
Created attachment 184274 [details]
Screenshot in light mode (OK)

When you create an empty slide with Title and Text, the 2 main areas have gray dashed lines around them.

However, in dark mode these lines retain a dark color and are barely visible.

See attached images for more information. In light mode all is OK... the problem is when a dark mode is used.

Tested with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f0652cb46e4e162032a763f8515354506d1683ed
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Rafael Lima 2022-12-20 19:02:59 UTC
Created attachment 184275 [details]
Screenshot in dark mode (NOK)
Comment 2 steve 2022-12-22 09:54:09 UTC
WHile I can't confirm this on macOS (the dotted lines are there), they don't show great in dark mode since they display in dark grey on a light grey background.


Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2e8776c181d0e38a8d25481ac0eb33389940bf95
CPU threads: 8; OS: Mac OS X 13.1; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 3 steve 2022-12-22 09:54:57 UTC
Created attachment 184309 [details]
macOS 2022-12-22
Comment 4 Sophie Sipasseuth 2023-01-16 13:34:05 UTC
Created attachment 184685 [details]
Darkmode - Printscreen - Impress
Comment 5 Sophie Sipasseuth 2023-01-16 13:35:21 UTC
Hello,

I tried to repeat your bug on windows 10, Version: 7.4.3.2 (x64) / LibreOffice Community.
And the bug is not present.
I attached a document to illustrate it.
Comment 6 Rafael Lima 2023-01-17 17:08:38 UTC
Created attachment 184714 [details]
New screenshot showing the problem

(In reply to Sophie Sipasseuth from comment #4)
> Created attachment 184685 [details]
> Darkmode - Printscreen - Impress

Hi Sophie,

Note that the dashed lines in your screenshot are black over a dark background. These dashed lines should have better contrast.

I took a screenshot of the file you've just attached and annotated where the bug is.
Comment 7 Rafael Lima 2023-01-19 18:30:29 UTC
Created attachment 184783 [details]
Screenshot of the proposed fix

Here's a patch proposed for this fix:
https://gerrit.libreoffice.org/c/core/+/145800

The screenshot shows how it looks with the patch applied.
Comment 8 Commit Notification 2023-01-23 09:13:58 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd20a17ab703e97191b4e3421527267ef82a704f

tdf#152622 Fix color of Object Boundaries in dark mode

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-01-23 14:26:45 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/e6b93b66aee8184da05d7d45443693438f4d4eea

tdf#152622 Fix color of Object Boundaries in dark mode

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Rizal Muttaqin 2023-01-24 04:12:47 UTC
Sorry a little bit out of topic. IMHO in dark color, the canvas or slide are does not need to have a blurry shadow.
Comment 11 Commit Notification 2023-01-24 21:38:23 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-5-0":

https://git.libreoffice.org/core/commit/bb5371bc7e05a9f2ae4baa73f618babe732272a3

tdf#152622 Fix color of Object Boundaries in dark mode

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 steve 2023-01-25 13:10:46 UTC
Cannot verify the fix in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e125e6623fa1c0f39d927bb37547ca6d1e299cb1
CPU threads: 8; OS: Mac OS X 13.2; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded

@Rafael: do you have a way to double check this on macOS?
Comment 13 Rafael Lima 2023-01-25 13:35:27 UTC
(In reply to steve from comment #12)
> @Rafael: do you have a way to double check this on macOS?

Unfortunately I do not have a way to check it on macOS.

Maybe you'll need to reset "User interface modifications" in safe mode. Have you tried that?
Comment 14 steve 2023-01-25 18:42:21 UTC
I think it is fine. It ran briefly in safe mode and was looking good.

After adapting the UI reset and restarting I ended up https://bugs.documentfoundation.org/show_bug.cgi?id=147342 preventing any further meaningful interaction with LO 😬