Created attachment 182530 [details]
Source file

Repro.

Call stack on master:

> vcllo.dll!`anonymous namespace'::CffSubsetterContext::emitAsType1(`anonymous-namespace'::Type1Emitter & rEmitter, const unsigned int * pReqGlyphIds, const unsigned char * pReqEncoding, int nGlyphCount, FontSubsetInfo & rFSInfo) Line 2052	C++
> vcllo.dll!FontSubsetInfo::CreateFontSubsetFromCff() Line 2081	C++
> vcllo.dll!FontSubsetInfo::CreateFontSubset(FontType nReqFontTypeMask, _iobuf * pOutFile, const char * pReqFontName, const unsigned int * pReqGlyphIds, const unsigned char * pReqEncodedIds, int nReqGlyphCount) Line 94	C++
> vcllo.dll!vcl::CreateCFFfontSubset(const unsigned char * pFontBytes, int nByteLength, const rtl::OString & rSysPath, const unsigned int * pGlyphIds, const unsigned char * pEncoding, int nGlyphCount, FontSubsetInfo & rInfo) Line 1923	C++
> vcllo.dll!vcl::font::PhysicalFontFace::CreateFontSubset(const rtl::OUString & rToFile, const unsigned int * pGlyphIds, const unsigned char * pEncoding, const int nGlyphCount, FontSubsetInfo & rInfo) Line 301	C++
> vcllo.dll!vcl::PDFWriterImpl::emitFonts() Line 2686	C++
> vcllo.dll!vcl::PDFWriterImpl::emitResources() Line 2918	C++
> vcllo.dll!vcl::PDFWriterImpl::emitCatalog() Line 4597	C++
> vcllo.dll!vcl::PDFWriterImpl::emit() Line 5737	C++
> vcllo.dll!vcl::PDFWriter::Emit() Line 54	C++
> pdffilterlo.dll!PDFExport::Export(const rtl::OUString & rFile, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rFilterData) Line 1012	C++
> pdffilterlo.dll!PDFFilter::implExport(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rDescriptor) Line 185	C++
> pdffilterlo.dll!PDFFilter::filter(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rDescriptor) Line 248	C++
> sfxlo.dll!SfxObjectShell::ExportTo(SfxMedium & rMedium) Line 2492	C++
> sfxlo.dll!SfxObjectShell::SaveTo_Impl(SfxMedium & rMedium, const SfxItemSet * pSet) Line 1560	C++
> sfxlo.dll!SfxObjectShell::PreDoSaveAs_Impl(const rtl::OUString & rFileName, const rtl::OUString & aFilterName, const SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 2979	C++
> sfxlo.dll!SfxObjectShell::CommonSaveAs_Impl(const INetURLObject & aURL, const rtl::OUString & aFilterName, SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 2769	C++
> sfxlo.dll!SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t,std::char_traits<char16_t>> aFileName, SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 318	C++
> sfxlo.dll!SfxBaseModel::impl_store(const rtl::OUString & sURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & seqArguments, bool bSaveTo) Line 3146	C++
> sfxlo.dll!SfxBaseModel::storeToURL(const rtl::OUString & rURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 1782	C++
> ...

Khaled: do you have an idea how to handle this?

My local build is unusable right now, but from the traceback it seems to be this line https://git.libreoffice.org/core/+/refs/heads/master/vcl/source/fontsubset/cff.cxx#2052, so may be something wen wrong around maFontBBox.

I checked the PDF file and the CFF table has an all 0’s bbox, so may be that is what is tripping this code.

(In reply to خالد حسني from comment #3)

Yes, and maFontBBox is empty, with the code above (line 475) never executed when preparing. My question is rather what would be the correct way to calculate the bounding box when it's absent in the font - should it be generated from the exported subset, and how?

For now, I'm going to use the same approach that was used in line 1835 - i.e., use a default set when the size of the matrix is not 4.

(In reply to Mike Kaganski from comment #4)
> (In reply to خالد حسني from comment #3)
> 
> Yes, and maFontBBox is empty, with the code above (line 475) never executed
> when preparing. My question is rather what would be the correct way to
> calculate the bounding box when it's absent in the font - should it be
> generated from the exported subset, and how?
> 
> For now, I'm going to use the same approach that was used in line 1835 -
> i.e., use a default set when the size of the matrix is not 4.

I’d do the simple thing and output an all 0's one, garbage in, garbage out.

A slightly better fix is to use the equivalent font extents from head table, but this particular code has access to the CFF table only and not the rest of the font tables, so that is not easy to pull (CFF table was shoehorned to OpenType, it is a standalone font format and duplicate some data available elsewhere in OpenType and the code here is written on the assumption accessing CFF table is enough, which is generally true).

Calculating extents from the glyphs is slow, so I wouldn’t do this.

The issue should be reported to the font developers as well.

https://gerrit.libreoffice.org/c/core/+/140121

Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1f985cb4779b581a77d419605ceb084707d408b8

tdf#151039: use the same defaults also for FontSubsetInfo::m_aFontBBox

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Thank you for your prompt reaction and correction.
I have test it with daily build of 7.5.0 and it works.

May I recall bug 138325, not yet addressed.
It seems to be a similar bad analysis or use of OTF tables when there are not duplicated in old TTF ones.
Thanks.

Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/3890b65ffa04c2cb9b4956ac65409d64b5c7f11c

tdf#151039: use the same defaults also for FontSubsetInfo::m_aFontBBox

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

*** Bug 151852 has been marked as a duplicate of this bug. ***