Bug 151253 - [UI] drag-and-drop handles in sub-toolbar dropdowns look bad in KF5 and QT5
Summary: [UI] drag-and-drop handles in sub-toolbar dropdowns look bad in KF5 and QT5
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.1.2 release
Hardware: All Linux (All)
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Toolbars
  Show dependency treegraph
 
Reported: 2022-09-30 18:36 UTC by Rafael Lima
Modified: 2023-02-24 07:46 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (23.69 KB, image/png)
2022-09-30 18:36 UTC, Rafael Lima
Details
Video taken from LO 7.5+ (425.23 KB, video/mp4)
2022-09-30 18:38 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-09-30 18:36:40 UTC
Created attachment 182758 [details]
Screenshot showing the problem

Since LO 7.4.1.2 I started seeing these artifacts on tools with dropdown items.

For instance, see the attached image taken from Impress using the "Basic Shapes" tool. A white bar appears on top of the dropdown widget.

This issue does not happen in 7.3.6.

In LO 7.5 master the issue got worse, with the dropdown widget appearing at a lower position in the window (will attach a video showing this).

First noticed the problem in

Version: 7.4.1.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

Problem does not exist in

Version: 7.3.6.2 / LibreOffice Community
Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 1 Rafael Lima 2022-09-30 18:38:19 UTC
Created attachment 182759 [details]
Video taken from LO 7.5+

This video was recorded using LO 7.5 built from master.

Notice that in addition to the white bar, the dropdown widget is now appearing at a lower position than expected.
Comment 2 csyu.279 2022-11-28 18:38:32 UTC
I was able to reproduce the bug in both 7.5.0.0 and 7.4.2.3. I could see artifacts in Impress and Draw but not Writer or Calc. The artifact on my screen looked like a bar with horizontal dots.

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 3 Stéphane Guillou (stragu) 2023-02-23 14:40:34 UTC
The area can be used to drag sub-toolbars off the toolbar and as independent toolbars.
It is also visible (with a different look) in gen and win VCLs (as reported by csyu), but in my opinion only looks bad in kf5 and qt5 (thick white horizontal bands).
I don't see a bar in GTK3.

Bibisected with linux-64-7.4 repo to f9da0b8d72753664d9fb342db244d8014515ea43 which points to a fix for bug 143688:

commit 7edadf64047b367f8d9cc0031008d6c6b46a55fd
author	Heiko Tietze <tietze.heiko@gmail.com>	Fri Jul 15 11:18:07 2022 +0200
committer	Adolfo Jayme Barrientos <fitojb@ubuntu.com>	Mon Jul 25 10:37:14 2022 +0200
tree f308b25d9cf35f8fa5c1626cc0e0ae719476a9cc
parent fd948aed2230e50cce9c4aa7f1eb30e7cc8c4f8f
Resolves tdf#143688 - Allow detaching of sub-toolbars when locked
Change-Id: I36669d953eb9438df73256676e2dfbfe3c263031
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137100

Heiko, what are your thoughts on the odd look for KF5 and QT5? Some kind of implementation error?

(In reply to Rafael Lima from comment #0)
> 
> In LO 7.5 master the issue got worse, with the dropdown widget appearing at
> a lower position in the window (will attach a video showing this).

This applies to many many dropdowns and is already covered in bug 149805.
Comment 4 Heiko Tietze 2023-02-24 07:46:22 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> Heiko, what are your thoughts on the odd look for KF5 and QT5? Some kind of
> implementation error?

The big white bar is there for me with gtk3 too (gtk4 does not expand the widget), qt5 and qt6. It is white independent from dark/light system theme. The fact that it look particular awkward on qt5 results from the double line indicator.

I could imagine that making it transparent solves the problem. Maybe we need to ensure the visibility of the drag handler, currently black lines on white background.

(In reply to Stéphane Guillou (stragu) from comment #3)
> Bibisected to f9da0b8d72753664d9fb342db244d8014515ea43... 
> Resolves tdf#143688 - Allow detaching of sub-toolbars when locked

The widgets were always the same AFAIR. The mentioned patch is unrelated and just made these floating widgets detachable even when the parent toolbar is locked.