Created attachment 182810 [details] Video showing the problem In Impress, the Bullets and Numbering dialog is not wide enough to fit the preview image. See attached video for more details (video uses kf5). Steps to reproduce 1) Create a new Impress presentation 2) Create a numbered list 3) Select the list; right-click, go to Bullets and Numbering 4) Click the Indent field (do not type anything) 5) Press the Tab key 6) Notice the preview will update and its size will be updated so that it won't fit the dialog and will appear above the existing controls Notice that when the dialog opens, the preview already is not fully visible. Then when the preview updates, it is re-positioned in the dialog. We should make this dialog wider so the preview fits inside of when the dialog first opens. Notice that in gtk3 the issue still exists but it appears a bit different. When you click tab, the preview is not placed above the dialog controls, but it remains not fully visible. Hence the width of the dialog is still insufficient to handle the preview. Weirdly enough, sometimes I get in kf5 the same behavior as in gtk3. System info (used in the video) Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 93925ec1f610d95a426231baf9a42128c773bb38 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded
I would say this is similar to bug 101953 that was fixed in Writer, but not in Impress.
Also, I've just noticed that the preview is not showing the numbers, which is yet another bug.
Version: 7.5.0.0.alpha0+ / LibreOffice This issue is found in impress but not in writer. In the preview its showing the same number to all the levels. Its not showing the consecutive number to all levels. Also the preview is not fitting inside the dialog box
I don't repro the change in the video. I also tried in 7.5 bibisect repo with a commit from Nov 2022, but no change. Do you still see this? Arch Linux 64-bit, X11 Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b63bffc2bb5a68d1f21e4035dde9a60429c9173c CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 16 February 2023
(In reply to Buovjaga from comment #4) > I don't repro the change in the video. I also tried in 7.5 bibisect repo > with a commit from Nov 2022, but no change. Do you still see this? Still repro with: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 29d795b772cb75ee1d12cc6bcd4d905f1c520a79 CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded I can also reproduce the problem with: Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: 50(Build:3) CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.5.0~rc3-0ubuntu0.22.10.1~lo1 Calc: threaded
BTW the problem also happens in gen and in gtk3, but in a different way. In gtk3 the dialog is not wide enough to fit the preview, but pressing Tab won't change the dialog layout as in kf5. In gen the problem is identical to what happens in kf5. Pressing Tab will try to resize the columns to fit the preview.
Code pointers: In the .ui file the size is fixed at 150, which is the initial size we get in the preview. Notice the "width-request" of 150 for the widget. https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/bulletandposition.ui?r=3170799c#1071 And the reason why the preview is resized is here: https://opengrok.libreoffice.org/xref/core/sd/source/ui/dlg/BulletAndPositionDlg.cxx?r=c91ec113#1188 Notice an apparent hack that explicitly uses 300 as a fixed size after changing the spin buttons. m_aPreviewWIN.set_size_request(aLastLevelLSpace, 300);
Can't reproduce the change in size either on Ubuntu 20.04 with GNOME 3.36.8 + Wayland, with either kf5 or gen: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 05ac57f85eb622b798719db03bbdd07b79e1703a CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 05ac57f85eb622b798719db03bbdd07b79e1703a CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+wayland) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 05ac57f85eb622b798719db03bbdd07b79e1703a CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Do you use any scaling?
(In reply to Stéphane Guillou (stragu) from comment #8) > Do you use any scaling? I'm not using any scaling (it's set to 100%). Can you please share a screenshot of how the dialog looks in your PC? Also, are you running the kf5 plugin from within Gnome or Plasma?
Created attachment 185567 [details] Normal bullets dialog Have you tried in Safe Mode Arch Linux 64-bit, X11 Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f12e547c42103a3b934b393b6b63c2b096bbd06e CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 24 February 2023
Created attachment 185568 [details] Screenshot of how the dialog should look Notice that the screenshot you've just shared is cropping the preview. If you had larger indent spaces, then some levels would fall outside the preview. Here's a screenshot of what the preview should look like. Notice that it's not cropping the preview image (excuse the lack of numbers in the preview, which is a separate bug since they're using COL_AUTO).
Ok, I was focusing on step 6. Let's set to NEW, then.
(In reply to Buovjaga from comment #12) > Ok, I was focusing on step 6. Let's set to NEW, then. Got it... IDK why the resizing of the preview (after pressing Tab) did not happen in your case. I'll take a look if I can fix issue by resizing the dialog according to the final preview size.