Description: UI: Keep ratio setting lost after opening Image properties Position and Size dialog, a change, OK and reopening the dialog Steps to Reproduce: 1. Open the attached file 2. Select the image 3. Press F4 or Format -> Image -> Properties -> Position and Size Tab 4. Notice keep ratio being checked (fine) 5. Press Up in the Width spinbox to change the width -> Goes in sync (with keep ratio) -> Fine 6. Press OK 7. Press F4 or Format -> Image -> Properties -> Position and Size Tab Actual Results: Keep ratio unchecked at reopening the dialog Expected Results: Still checked Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 9063d99ff5ee43cc1239fc1dbb5d9897bdda1c9b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
Created attachment 182869 [details] Example file
I confirm it with Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL
Still the case with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a4522ef5ce6a625054d83ec907aee07c156e94ed CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US for the example file attached here. *Not* for a newly created document, though, interestingly?
Reproduced in recent daily build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7a895ec4205659038aa95941b65715fed1a3e7be CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded ... and in 7.3.7, but no repro in: Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL Bibisected with linux-64-7.3 repo to first bad build [596229b236011767a88288b8f3e10a929e95577b] which is 27b03993c49b3c8a3bafa736db9ca25e834a2195, a cherrypick of: commit a59952f64c6e78f8e5bad6d6ab8373879f6a826f author Caolán McNamara Wed Feb 09 13:54:42 2022 +0000 committer Caolán McNamara Wed Feb 09 20:59:06 2022 +0100 Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggled Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129730 Caolán, can you please have a look?
bug#132591 has to keep working along with this case
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0702a3f17c1fbd1b8ffb9ca0b275943e1a1f442 Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
seems good in trunk, backport to 24.2 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/bf877f3e10c3a2ce7267335a0c9c7cd828c373ca Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 194588 [details] 'Keep ratio' tick button in image properties dialog F4.png Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: pl-PL (pl_PL); UI: en-US Calc: threaded There's still some issue with "Keep ratio" tick button after the Writer Reopening. Steps: 1) Open the attached file for the first time. 2) Select image, press F4 (or go to the image properties dialog another ways). 3) Unselect 'Keep ratio'. 4) Click OK. 5) Enter image properties dialog (F4) once again. Actual result: -- 'Keep ratio' is still checked Expected result: -- Unselecting should be applied successfully. This problem occurs until the first change of size, but only in the Image properties dialog (F4). Resizing on the page does not repair this behavior.
(In reply to Piotr Osada from comment #9) I confirm Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: e3bd3c7e3178dc091fd002628f052666b4db3be6 CPU threads: 4; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded I'm inclined to say, lets file a new (follow up) bug for this. Seems cleaner, IMHO