Description: Freeze deleting an image with Track Changes Record ON Steps to Reproduce: 1. Open the attached file 2. Select the image on page 1 (page filling) and hit delete Actual Results: Freeze Expected Results: Same as with Track Changes disabled Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9cd0f4c2d25462feba0ffcbd906c199273821243 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
Created attachment 183379 [details] Example file
Still OK with Version: 7.1.8.0.0+ (x64) / LibreOffice Community Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
REPRODUCIBLE with Installation of Version:7.4.2.3 (x64) Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE | Calc: threaded | ElementaryTheme | My normal User Profile
Already REPRODUCIBLE with Server Installation of Version: Version: 7.2.5.2 (x64) Build ID 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE | Calc: CL | Colibri Theme | Special devUserProfile NOT reproducible with Server Installation of Version: 6.0.7.3 (x64) Build-ID dc89aa7a9eabfd848af146d5086077aeed2ae4a5; CPU-Threads: 12; BS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL, Special devUserProfile
This seems to have begun at the below commit. Adding Cc: to Jim Raykowski ; Could you possibly take a look at this one? Thanks From this commit LO crash after delete d267c44c1503c7f93a83d60d3ec4a2bb6a1278f2 is the first bad commit commit d267c44c1503c7f93a83d60d3ec4a2bb6a1278f2 Author: Jenkins Build User <tdf@pollux.tdf> Date: Fri May 14 06:18:42 2021 +0200 source 6b09276d157abada74e1a4989700139167207778 https://git.libreoffice.org/core/+/6b09276d157abada74e1a4989700139167207778 From this commit LO freeze after delete d715c2f7fdacdba9480311099068fd21259610f0 is the first bad commit commit d715c2f7fdacdba9480311099068fd21259610f0 Author: Jenkins Build User <tdf@pollux.tdf> Date: Wed Aug 11 15:28:34 2021 +0200 source d3f5f1b0068b8ab57f7aae9588cc0cff4af1db54 https://git.libreoffice.org/core/+/d3f5f1b0068b8ab57f7aae9588cc0cff4af1db54
Hi All, This is a difficult one to bisect due to a bug during a period in 7.2 when outline folding is on that causes a crash when delete is pressed. I turning off outline folding to bisect, Menu > Tools > Options... > LibreOffice Writer > View > uncheck 'Show outline-folding buttons'. I never got a hang on delete in 7.2 but did run into an X being placed across image94 on the third bisect and later in the bisect process no X but also no delete. My bisect effort came up with this in 7.2: commit d6322bcedc197a654abc7d64bfea8cf570f123bf Author: László Németh <nemeth@numbertext.org> Date: Mon Apr 26 09:33:45 2021 +0200 tdf#59463 track changes: record deletion of images and in 7.3 commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b Author: László Németh <nemeth@numbertext.org> Date: Sun Jul 11 13:04:54 2021 +0200 tdf#142701 track changes: fix layout regression of image deletion I stepped through the code and saw that the hang occurs here: SwWrtShell::DelRight Insert( OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) + OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) ); https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/delete.cxx?r=70973680#475 I always get expected results, image deleted, no hang, when Track Changes is turned off, Menu > Edit > Track Changes > Record unticked.
(In reply to Jim Raykowski from comment #6) > Hi All, > > This is a difficult one to bisect due to a bug during a period in 7.2 when > outline folding is on that causes a crash when delete is pressed. I turning > off outline folding to bisect, Menu > Tools > Options... > LibreOffice > Writer > View > uncheck 'Show outline-folding buttons'. I never got a hang > on delete in 7.2 but did run into an X being placed across image94 on the > third bisect and later in the bisect process no X but also no delete. > > My bisect effort came up with this in 7.2: > > commit d6322bcedc197a654abc7d64bfea8cf570f123bf > Author: László Németh <nemeth@numbertext.org> > Date: Mon Apr 26 09:33:45 2021 +0200 > > tdf#59463 track changes: record deletion of images > > and in 7.3 > > commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b > Author: László Németh <nemeth@numbertext.org> > Date: Sun Jul 11 13:04:54 2021 +0200 > > tdf#142701 track changes: fix layout regression of image deletion > > > I stepped through the code and saw that the hang occurs here: > > SwWrtShell::DelRight > > Insert( OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) + > OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) ); > > https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/delete. > cxx?r=70973680#475 > > I always get expected results, image deleted, no hang, when Track Changes is > turned off, Menu > Edit > Track Changes > Record unticked. adding CC to László