Description: Hi, I've tested different icon sets (SVG), and other icons are clear and sharp, but only icons on sidebar, "Font Color" icon, and "Highlight" icon are blurry. OS: Fedora 36 Desktop: Wayland Resolution: 3840x2160 Scale: 200% Source: RPMs from Official Website Steps to Reproduce: 1. Launch any LibreOffice app Actual Results: Blurry icons Expected Results: All icons should appear clear and sharp Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.2.3 / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 16; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL
Created attachment 183411 [details] Screenshot indicating the blurry icon issue
Confirmed using Colibre (SVG) on Debian testing, 175% scaling. Version: 7.4.2.3 Build ID: 40 (Build:3) CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Debian package version: 1:7.4.2-2
The font and highlight get the current color painted into them, so there's probably a round trip through an intermediate bitmap which squeezes the hidpi out of them. Not sure about the sidebar, something else must be happening there.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb8a05bfccf77d5217f4f2e20b5898d6a24f990d Related: tdf#151898 set origin for implLoadRepositoryImage XGraphics It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for the quick response! So far version 7.5.0.0.alpha0+ still has the issue. I'll keep an eye on the future builds. Cheers
yeah, "Related" patch doesn't do anything user useful yet, just a necessary preliminary step.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/397f5daa850e59f0f4d3881cb99d110b50e34e3d tdf#151898 if svgs are used in hidpi get a high quality GtkImage It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/758163bf5a754160e692dfff511f0a8a750b6bba Related: tdf#151898 use more of the code path that can use scaled svgs It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I think I see a route to getting those last runtime-generated cases working
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c2c37eadf32c80bcd8f168b9fc67f32002b3cb07 Related: tdf#151898 consider surface scaling if prescale with Bitmap::Scale It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c3da84a10260b3260ee42df900e2ff01119e4f7c Resolves: tdf#151898 get hidpi font/highlight color icons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
done in trunk, backports to 7-4 in gerrot
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/44463562732fb57c4009ecf54bb0c4ffa5df5034 Related: tdf#151898 set origin for implLoadRepositoryImage XGraphics It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/3cfeeb2ea83edbf99d4e3bb6e0b67538f03f783d Related: tdf#151898 consider surface scaling if prescale with Bitmap::Scale It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/b10615a204469846508ad94c5858d5434260664a tdf#151898 if svgs are used in hidpi get a high quality GtkImage It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/82934c0ab5bc917c2f00676a0758199964fac285 Resolves: tdf#151898 get hidpi font/highlight color icons It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This fix breaks build in 7.4.4 in Arch Linux: In file included from /build/libreoffice-fresh/src/libreoffice-7.4.4.2/vcl/unx/gtk4/gtkinst.cxx:19: /build/libreoffice-fresh/src/libreoffice-7.4.4.2/vcl/unx/gtk4/../gtk3/gtkinst.cxx: In function ‘void {anonymous}::picture_set_from_xgraphic(GtkPicture*, const com::sun::star::uno::Reference<com::sun::star::graphic::XGraphic>&)’: /build/libreoffice-fresh/src/libreoffice-7.4.4.2/vcl/unx/gtk4/../gtk3/gtkinst.cxx:5117:42: error: too many arguments to function ‘std::unique_ptr<utl::TempFile> {anonymous}::getImageFile(const com::sun::star::uno::Reference<com::sun::star::graphic::XGraphic>&)’ 5117 | if (auto xTempFile = getImageFile(rPicture, false)) | ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ /build/libreoffice-fresh/src/libreoffice-7.4.4.2/vcl/unx/gtk4/../gtk3/gtkinst.cxx:4861:36: note: declared here 4861 | std::unique_ptr<utl::TempFile> getImageFile(const css::uno::Reference<css::graphic::XGraphic>& rImage) | ^~~~~~~~~~~~ reverting it allows to finish the build. gcc 12.2.0 / gtk3 3.24.36 / gtk4 4.8.3
https://gerrit.libreoffice.org/c/core/+/145421 to fix the 7-4 gtk4 build
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/42d7d6a6f5b7701d9ec6c14dae6ffb48eb4b4035 Related: tdf#151898 fix gtk4 build in 7-4 It will be available in 7.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
7.4.5 was a hotfix release, updating target in status-whiteboard