Bug 122113 - Icons blurry with visible artifacts in various cases like with increased font scaling (kf5/gen/gtk3/Win with SVG icons)
Summary: Icons blurry with visible artifacts in various cases like with increased font...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: x86-64 (AMD64) All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 133066 144264 145799 146517 (view as bug list)
Depends on:
Blocks: Icon-Themes-Code-SVG
  Show dependency treegraph
 
Reported: 2018-12-14 21:42 UTC by [REDACTED]
Modified: 2024-09-20 10:32 UTC (History)
13 users (show)

See Also:
Crash report or crash signature:


Attachments
System info (123.97 KB, image/png)
2018-12-14 21:44 UTC, [REDACTED]
Details
Font scaling set to 1.5 (117.09 KB, image/png)
2018-12-14 21:44 UTC, [REDACTED]
Details
Blurry icons with visible artifacts (74.58 KB, image/png)
2018-12-14 21:45 UTC, [REDACTED]
Details
Pixelated icons in Calc (53.95 KB, image/png)
2023-04-03 11:19 UTC, Dan Dascalescu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description [REDACTED] 2018-12-14 21:42:20 UTC
Description:
Using Fedora 29 64-bit, Cinnamon (v4.0.5) edition.

Icons become blurry with visible artifacts when font scaling is set above 1.0

https://imgur.com/a/4AZXs6f

Steps to Reproduce:
1. Set font scaling to 1.5 in system settings
2. Open LibreOffice

Actual Results:
Icons are blurry with visible artifacts

Expected Results:
Icons not blurry with no visible artifacts, icons should scale perfectly.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Comment 1 [REDACTED] 2018-12-14 21:44:05 UTC
Created attachment 147562 [details]
System info

System info
Comment 2 [REDACTED] 2018-12-14 21:44:48 UTC
Created attachment 147563 [details]
Font scaling set to 1.5

Font scaling set to 1.5
Comment 3 [REDACTED] 2018-12-14 21:45:30 UTC
Created attachment 147564 [details]
Blurry icons with visible artifacts

Blurry icons with visible artifacts
Comment 4 Xisco Faulí 2018-12-18 15:01:03 UTC
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.
Comment 5 Xisco Faulí 2019-01-24 11:19:11 UTC
I can reproduce it in

Version: 6.3.0.0.alpha0+
Build ID: 0d46fb02f3f19d11db40b6c5335d78a3894502d7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

but not in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default;
Comment 6 Xisco Faulí 2019-01-24 11:25:43 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=69b6ab1f8de08b3418fd42d56076a73d40a29229

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2016-10-28 23:24:30 +0200
committer	Tomaž Vajngerl <quikee@gmail.com>	2016-10-29 21:47:41 +0000
commit 69b6ab1f8de08b3418fd42d56076a73d40a29229 (patch)
tree b9d3ced7be6ab7c70388a91cd8b56b68d3651d07
parent a86144696df87cd81795e071a30b74af127c7948 (diff)
tdf#100164 change scaling unit to precentage for *.5x factors

Bisected with: bibisect-linux-64-5.3

Adding Cc: to Tomaž Vajngerl
Comment 7 Telesto 2022-01-02 05:38:33 UTC
*** Bug 146517 has been marked as a duplicate of this bug. ***
Comment 8 Telesto 2022-01-02 05:38:48 UTC
*** Bug 145799 has been marked as a duplicate of this bug. ***
Comment 9 Telesto 2022-01-02 05:44:46 UTC
It's blurry in macOS by definition. Increasing screen DPI to say 135 on Linux also makes it noticeable. 
Icons are also slightly fuzzy on windows with 96dpi screen without scaling
Comment 10 Telesto 2022-01-02 05:46:25 UTC
*** Bug 144264 has been marked as a duplicate of this bug. ***
Comment 11 Telesto 2022-01-02 12:23:52 UTC
Raising priority a bit as a poke, because this matters for the first impression (and overall experience). It's optics issue only and not happening in all systems (you need to diverge from default, except for macOS. Ror the latter: the issue is also attributed to bug 141065

I leave it up to other to decide if the priority can be kept.. 

Number of people in CC is low (suggesting low importance), but well that was also the case for bug 100164 at implementation time...
Comment 12 Heiko Tietze 2022-01-03 10:22:11 UTC
Workaround is to use SVG icon themes.
Comment 13 Telesto 2022-01-03 10:33:59 UTC
(In reply to Heiko Tietze from comment #12)
> Workaround is to use SVG icon themes.

Nope SVG quality really bad on Windows and macOS
Comment 14 Telesto 2022-12-21 23:23:09 UTC
@Patrick
A poke. The toolbar icons are really fuzzy (read low resolution pixelated) especially with a high resolution display like a Retina-display. macOS dark mode makes it even more noticeable, IMHO. It's not nice to look at, esthetically.

Screenshot: attachment 176406 [details] (inspect for example the new document icon)

Not limited to macOS, though.
Comment 15 Dan Dascalescu 2023-04-03 11:19:09 UTC
Created attachment 186436 [details]
Pixelated icons in Calc

I see pixelated icons in Calc as well.

Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 20; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL threaded

BTW, is this a dupe of bug #51733 ?
Comment 16 Patrick (volunteer) 2024-05-01 17:51:09 UTC
(In reply to Telesto from comment #14)
> @Patrick
> A poke. The toolbar icons are really fuzzy (read low resolution pixelated)
> especially with a high resolution display like a Retina-display. macOS dark
> mode makes it even more noticeable, IMHO. It's not nice to look at,
> esthetically.
> 
> Screenshot: attachment 176406 [details] (inspect for example the new
> document icon)
> 
> Not limited to macOS, though.

I have committed a fix for SVG icons for macOS only in tdf#130678 in the following comment:

https://bugs.documentfoundation.org/show_bug.cgi?id=130678#c10

Note: the fix is only for SVG icons.
Comment 17 steve 2024-05-06 14:10:54 UTC
Removing macOS from title as per fix in https://bugs.documentfoundation.org/show_bug.cgi?id=130678
Comment 18 Patrick (volunteer) 2024-05-06 14:30:51 UTC
So the headless code already has a fix for this. For macOS, I largely copied the headless code by adding the following method in the macOS subclass of SalGraphicsAutoDelegateToImpl:

virtual bool ShouldDownscaleIconsAtSurface(double* pScaleOut) const override;

Maybe for Windows and Linux, the following macOS patch can be used as a template? The ShouldDownscaleIconsAtSurface() method in the Windows and Linux subclasses of SalGraphicsAutoDelegateToImpl only really needs to set pScaleOut to screen resolution for pixel (i.e. 2.0 for Retina display on macOS):

https://gerrit.libreoffice.org/c/core/+/166867
Comment 19 Rizal Muttaqin 2024-05-23 22:09:08 UTC
Still reproducible with

KF5:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 101b08fe1ec77ffe8c1a9b2b8f9f20884269a1ed
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded

GTK3:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 101b08fe1ec77ffe8c1a9b2b8f9f20884269a1ed
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


Operating System: KDE neon 6.0
KDE Plasma Version: 6.0.4
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.0
Kernel Version: 6.5.0-35-generic (64-bit)
Graphics Platform: X11
Processors: 12 × 12th Gen Intel® Core™ i7-1255U
Memory: 15.3 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: LENOVO
Comment 20 Buovjaga 2024-09-20 10:32:01 UTC
*** Bug 133066 has been marked as a duplicate of this bug. ***