Bug 151941 - Alt_Shift_P does not show as shortcut key for Format>Page Style
Summary: Alt_Shift_P does not show as shortcut key for Format>Page Style
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Aditya Sahu
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, implementationError, skillDesign, topicUI
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency tree / graph
 
Reported: 2022-11-06 23:36 UTC by TorrAB
Modified: 2024-11-02 15:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2022-11-06 23:36:18 UTC 
Format>Parag shows Alt_Shift_P as shortcut key; yet, Tools>Customize>keyboard shows no attribution for Alt_Shift_P.
Comment 1 Aron Budea 2022-11-07 05:35:30 UTC 
Alt+Shift+P is Format -> Page Style, right? I can confirm in LO 7.5.0.0.alpha0+ (cfc8a8f5d841b3f84d207196153be67da7f60652) / Ubuntu.

Same with Styles -> Edit Style..., which opens the Paragraph Style dialog, the accelerator is Alt+P.

These accelerators were added in:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=856887cbc8a0a2fd04b90ee2170948d34c8ff9c4
Comment 2 Maxim Monastirsky 2022-11-07 09:01:47 UTC 
These shortcuts were set globally, not just for Writer, therefore one need to switch to the "LibreOffice" context (instead of "Writer") at the top right part of the dialog to see their assignment. But I think that setting them globally was wrong, as at least the Page Style command is Writer specific.
Comment 3 TorrAB 2022-11-07 13:54:22 UTC 
(In reply to Aron Budea from comment #1)
> Alt+Shift+P is Format -> Page Style, right?

Yes. Sorry.
Comment 4 Buovjaga 2024-09-14 16:06:02 UTC 
Adding commit hash again to get a permanently working link: 856887cbc8a0a2fd04b90ee2170948d34c8ff9c4
Comment 5 Heiko Tietze 2024-09-16 09:22:16 UTC 
The task is to move the node oor:name="P_SHIFT_MOD2" from <node oor:name="Global"> to <node oor:name="com.sun.star.text.TextDocument"> in officecfg/registry/data/org/openoffice/Office/Accelerators.xcu.
Comment 6 Aditya Sahu 2024-10-20 00:30:14 UTC 
Taking this up as I'm trying to re-warm myself up with the codebase
Comment 7 Aditya Sahu 2024-10-20 00:50:03 UTC 
Please review my commit as an attempt to fix the issue:
https://gerrit.libreoffice.org/c/core/+/175249
Comment 8 Commit Notification 2024-10-21 11:38:03 UTC 
Aditya Sahu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c32210fdf31e57e7e91cd494dbbc36dd5ff6f088

tdf#151941: Show Alt_Shift_P as shortcut key for Page Style

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.