Bug 152043 - Database Properties dialog UI (connectionpage.ui) is too narrow when Creating New
Summary: Database Properties dialog UI (connectionpage.ui) is too narrow when Creatin...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.7.2 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0
Keywords: regression
Depends on:
Blocks: UI
  Show dependency treegraph
 
Reported: 2022-11-14 18:36 UTC by jcsanz
Modified: 2022-11-17 10:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Test database (2.10 KB, application/vnd.sun.xml.base)
2022-11-14 18:39 UTC, jcsanz
Details
Dialogs showing the issue with Spanish and English interface (23.13 KB, image/png)
2022-11-14 18:41 UTC, jcsanz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jcsanz 2022-11-14 18:36:59 UTC
Description:
Depending on language, buttons are hardly visible in the Database Properties dialog with Firebird External database, but if visible, in all languages tested, the caption of the buttons are incomplete. Also, the label on the left of the button is incomplete in all languages tested (Spanish, English and French).
The dialog is not resizable, so it is not possible to resize to made room. 

Steps to Reproduce:
To test this issue, it is needed an external Firebird database, so we will create a Firebird external database file (it is not needed to have Firebird server installed). 

Once the .odb file has been created, the Firebird file is not needed, so you can use the attached database Test2.odb instead of creating it.

To create the database:

1. Open Base
2. Select Connect to an existing database
3. In the dropdown list, select Firebird external. Click Next
4. Click on Create new button
5. In the Save as dialog, choose a suitable place and give a name to the Firebird database file, for example Test1.fdb. Click on Save, then Click Next
6. In the Setup the user authentication step, do not change anything. Click Next
7. In the Save and proceed step, click on No, do not register the database (it is not needed register).
8. Click on Finish.
9. Give a name to the Base .odb file, for example Test2.odb

Once the database file has been created (or if use the attached one), to see the issue:

1. Open the database file Test2.odb
2. In the menu, select Edit > Database > Properties to show the Database Properties dialog
3. Observe that in the Spanish interface the buttons are hardly visible. In the English interface the caption of the Create new button is incomplete, furthermore, the label on the left of the Create new button is incomplete in any case.

Actual Results:
- Buttons are hardly visible (LO 7.x Spanish) or totally invisible (LO 6.4.x Spanish)
- Label on the left of the button is not visible completely

Expected Results:
- Buttons visible
- Label complete or a way to see it completely


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL
--------------------
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 1; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: es-ES (es_ES.UTF-8); UI: es-ES
7.4.2-2
Calc: threaded
Comment 1 jcsanz 2022-11-14 18:39:42 UTC
Created attachment 183594 [details]
Test database

A test database configure to use firebird, so not need create it
Comment 2 jcsanz 2022-11-14 18:41:09 UTC
Created attachment 183595 [details]
Dialogs showing the issue with Spanish and English interface
Comment 3 Stéphane Guillou (stragu) 2022-11-14 22:49:08 UTC
I can reproduce with VCLs kf5 and gen but not gtk3:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6e66b5d75b4cda0314b64f4d12ef9e4350751470
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6e66b5d75b4cda0314b64f4d12ef9e4350751470
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Seems to be a regression as I can't reproduce with:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 V Stuart Foote 2022-11-15 00:20:04 UTC
It is welded but strings don't fit within the .UI pushing action buttons and labels off screen.

https://opengrok.libreoffice.org/xref/core/dbaccess/uiconfig/ui/connectionpage.ui
Comment 5 V Stuart Foote 2022-11-15 00:20:52 UTC
(In reply to V Stuart Foote from comment #4)
s/off screen/off the dialog frame
Comment 6 Caolán McNamara 2022-11-15 11:10:57 UTC
The width (in characters) of these is set to a default of 56 (the WIZARD_PAGE_X define) which could also be expanded. But never the less we should be doing a better job of layout here
Comment 7 Commit Notification 2022-11-15 13:18:41 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/09df29aed07223fa2cdb0913b6e8ddf4da347706

Resolves: tdf#152043 line wrap the label

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2022-11-15 13:19:20 UTC
labels should be fully readable now in trunk
Comment 9 Stéphane Guillou (stragu) 2022-11-17 10:19:23 UTC
Verified as fixed in:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a81e957f5026373f3935390c786c21416fc74fcc
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Caolán!