Bug 152769 - Insert - Header and Footer - Footer: "MarkTopUndoAction() suspicious call" warning with debug LO; can't undo-redo header/footer addition
Summary: Insert - Header and Footer - Footer: "MarkTopUndoAction() suspicious call" wa...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Header-Footer Undo-Redo
  Show dependency tree / graph
 
Reported: 2022-12-31 11:02 UTC by BogdanB
Modified: 2024-10-12 19:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BogdanB 2022-12-31 11:02:41 UTC 
Description:
Open a new Writer document. Insert - Header and Footer - Footer.

In the dbg build of LibreOffice I get in terminal this warning:
warn:svl:1583500:1583500:svl/source/undo/undo.cxx:1070: SfxUndoManager::MarkTopUndoAction(): suspicious call!

This is NOT the case with Insert - Header and Footer - Header.

Steps to Reproduce:
see description

Actual Results:
warning

Expected Results:
no warning


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2022-12-31 15:36:51 UTC 
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I tested undoing and redoing the footer addition: it's not possible to re-add the footer that way, even if some text was added in the footer before undoing everything.

The loss of undo/redo history happens since 7.2:

Version: 7.2.7.2 / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2023-02-15 21:01:12 UTC 
Assumed to have started with the fix for bug 46561, so not a regression as we could not even reach a state before the footer addition.

I also get the same warning when adding a header.
Comment 3 BogdanB 2023-08-03 15:43:47 UTC 
Retested with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0e17d8ddccdee7d4f46b256153853e1cab87c99e
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

warn:svl:347292:347292:svl/source/undo/undo.cxx:1073: SfxUndoManager::MarkTopUndoAction(): suspicious call!
Comment 4 BogdanB 2024-06-08 07:27:46 UTC 
warn:svl:56004:56004:svl/source/undo/undo.cxx:1083: SfxUndoManager::MarkTopUndoAction(): suspicious call!

Retested with
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 5 BogdanB 2024-10-12 19:40:19 UTC 
warn:svl:5387:5387:svl/source/undo/undo.cxx:1104: SfxUndoManager::MarkTopUndoAction(): suspicious call!

This warning can be triggered by many options.
See bug: 
https://bugs.documentfoundation.org/show_bug.cgi?id=152794
But in this other bug we have also 2 warnings that can be generated by different locations.