Bug 153080 - RTL UI messed up
Summary: RTL UI messed up
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium major
Assignee: Aron Budea
URL:
Whiteboard: target:7.6.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTL-UI
  Show dependency treegraph
 
Reported: 2023-01-18 07:34 UTC by Aron Budea
Modified: 2023-01-18 21:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Start center screenshot (143.93 KB, image/png)
2023-01-18 07:34 UTC, Aron Budea
Details
Screenshot of toolbars (30.08 KB, image/png)
2023-01-18 07:39 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2023-01-18 07:34:06 UTC
Created attachment 184728 [details]
Start center screenshot

Open LibreOffice in an RTL language (screenshots are in Hebrew, but it's the same with Arabic).

=> Parts of the UI is missing, eg. the column of launcher icons in the start center, or the sidebar opener icons in the app, and the toolbar is wrong as well, icons disappear after hovering over them.

Observed using LO 7.6.0.0.alpha0+ (f1830bff71847a9c17715cff52383956719847fe) / Windows.

Bibisecting it using the win-64-7.6 repo revealed that this is a regression from the following commit.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6f43f00279252265fe4892b46fe0b4686ff721ed
author		Noel Grandin <noel.grandin@collabora.co.uk>	2022-12-20 18:02:32 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2022-12-21 06:44:59 +0000

No need for bool return value here
Comment 1 Aron Budea 2023-01-18 07:37:57 UTC
https://gerrit.libreoffice.org/c/core/+/145704
Comment 2 Aron Budea 2023-01-18 07:39:00 UTC
Created attachment 184729 [details]
Screenshot of toolbars
Comment 3 Commit Notification 2023-01-18 09:20:24 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/305e5fe1ba3df1dbe1f961509fe2c691b5193a6f

tdf#153080 RTL UI was misbehaving

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Eyal Rozenberg 2023-01-18 19:58:10 UTC
So, did this start happening in a recent nightly, then quickly fixed?
Comment 5 Aron Budea 2023-01-18 21:19:37 UTC
Fairly recent, albeit almost a month old, the regressing commit was merged on 2022-12-21 (and only added to trunk, so 7.5 is unaffected):
"committer	Noel Grandin <noel.grandin@collabora.co.uk>	2022-12-21 06:44:59 +0000"

I encountered it on Windows, I can't tell if it affected Linux as well.