Bug 153223 - Red wavy lines under misspelt words disappears when viewing page at zoom factor of 160% or greater (macOS)
Summary: Red wavy lines under misspelt words disappears when viewing page at zoom fact...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.7.2 release
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
: 151972 153230 (view as bug list)
Depends on:
Blocks: Spell-Checking
  Show dependency treegraph
 
Reported: 2023-01-26 16:48 UTC by Darren Poynton
Modified: 2023-06-07 13:26 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darren Poynton 2023-01-26 16:48:44 UTC
Description:
When viewing text documents at a zoom factor of 160% or greater, the red wavy line indicating misspelt words is not visible.

Steps to Reproduce:
1. Turn Automatic Spell Checking on
2. Type a mispelt word
3. Zoom out to a factor of 160% or greater

Actual Results:
Red wavy lines disappear

Expected Results:
Red lines should remain


Reproducible: Always


User Profile Reset: Yes

Additional Info:
--
Comment 1 Telesto 2023-01-26 21:06:54 UTC
Confirm
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 102846d45cb9660805e209b6954c7b8d707b8288
CPU threads: 8; OS: Mac OS X 12.3.1; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

fine with Skia Raster rendering
Comment 2 Telesto 2023-01-26 21:08:57 UTC
No issue with
Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 3 Telesto 2023-01-27 03:39:15 UTC
*** Bug 153230 has been marked as a duplicate of this bug. ***
Comment 4 Stéphane Guillou (stragu) 2023-01-27 10:26:43 UTC
Heiko, I haven't bibisected but I'm wondering if this has to do with the fix for bug 70519 that made it into 7.3?

https://git.libreoffice.org/core/commit/4141c13da8245b5ed46be3b7034d014d75f433f9

Cheers!
Comment 5 Anandhi k 2023-01-29 07:34:53 UTC
NO not Reproduced

Steps to Reproduce:
1. Turn Automatic Spell Checking on
2. Type a mispelt word
3. Zoom out to a factor of 160% or greater

Actual Results:
Red wavy lines disappear

Expected Results:
Red lines should remain

Actual Result and Expected Result mached 

Environment: Linux Mint 21 Cinnamon
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 620ad1b7ae06d6f053fb2c9b57af96b736c04e57
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded
Comment 6 Kollien 2023-01-29 15:51:04 UTC
The disappearing of the red line is a combination of selected font and zoom factor. 
On my MacBook 16, font Arial shows the bug at zoom 122%. Font Monaco raise the problem at 99%. Maybe the selected screen resolution is a second factor.
Comment 7 Heiko Tietze 2023-01-31 11:43:20 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
> I'm wondering if this has to do with the fix for bug 70519

Yes, after reverting this code wavy lines are drawn at 160%. However, after undoing everything and recompiling the original source code everything works well too!
Comment 8 Heiko Tietze 2023-01-31 12:08:08 UTC
(In reply to Heiko Tietze from bug 70519 comment 14)
> ...patch at https://gerrit.libreoffice.org/c/core/+/125038 does is to take the
> zoom factor into account and increase the line size and wavyness. Drawback
> is that it becomes cut-off on huge zoom levels.

The calculation rounds >150 to a line width >1, which obviously fails. We can revert the patch and find alternatives for bug 70519, depending on priority.
Comment 9 Stéphane Guillou (stragu) 2023-01-31 22:27:58 UTC
*** Bug 151972 has been marked as a duplicate of this bug. ***
Comment 10 csyu.279 2023-02-13 19:13:03 UTC
No repo on Windows OS:

Version: 7.4.4.2 (x64) / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b4dc43b6d01d85802d5674c3a27789d6354e39a8
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 11 Kollien 2023-02-13 23:07:17 UTC
That’s because it is a macOS relevant bug as mentioned in the title.
Comment 12 Heiko Tietze 2023-06-05 07:10:36 UTC
Dup of bug 138918?
Comment 13 Stéphane Guillou (stragu) 2023-06-07 13:26:31 UTC
(In reply to Heiko Tietze from comment #12)
> Dup of bug 138918?

This one is a 7.3 regression that is so far macOS-specific and not reproduced with skia/raster, whereas bug 138918 is an older one, seen on Windows, and reproduced with skia/raster. Not dupes in my opinion.