Bug 153789 - Icons needed for new Uno commands WatchWindow and StackWindow in the Basic IDE
Summary: Icons needed for new Uno commands WatchWindow and StackWindow in the Basic IDE
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Icon-Request
  Show dependency treegraph
 
Reported: 2023-02-23 13:20 UTC by Rafael Lima
Modified: 2023-05-17 13:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the new commands (42.02 KB, image/png)
2023-02-23 13:20 UTC, Rafael Lima
Details
Basic IDE highlighting the Object Catalog and Watch window (132.51 KB, image/png)
2023-03-18 18:09 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-02-23 13:20:46 UTC
Created attachment 185545 [details]
Screenshot of the new commands

The fix for bug 146518 introduced the new Uno commands .uno:WatchWindow and .uno:StackWindow, which simply toggles (shows/hides) the Watch and Stack windows in the Basic IDE.

They work similarly to the existing Object Catalog toggle accessible via the View menu and the standard toolbar.

The attached screenshot shows the new commands in the View menu. After they get icons, they'll also be added to the standard bar beside the Object Catalog button.
Comment 1 Rizal Muttaqin 2023-03-17 11:52:51 UTC
I have no idea at all how the icon should looked like
Comment 2 Rafael Lima 2023-03-18 18:09:57 UTC
Created attachment 186053 [details]
Basic IDE highlighting the Object Catalog and Watch window

The attached image shows the current Basic IDE window and highlights the existing "Object Catalog" toggle. These two new commands will be placed right beside the "Object Catalog" command and will focus on toggling the Watched Expressions and Call Stack windows that are placed in the lower area of the window.

An icon already exists for removing watch variables (it is also highlighted in the image), so this might be used as inspiration for the Watch Window toggle.

As a side note, I think the existing Remove Watch icon could be replaced by something that better resembles a "remove" action.

The Watch window's objective is to watch the content of variables during execution, hence the use of an eye in this icon. I think we could use binoculars or a microscope to represent the same idea.

The Call Stack window "allows you to monitor the sequence of procedures and functions during the execution of a program. The procedures are functions are displayed bottom to top with the most recent function or procedure call at the top of the list." (text from the help)

There's an image in the link below that is a good representation of a stack and I believe it'll inspire the creation of an icon.

https://stackoverflow.com/questions/62725430/what-is-the-different-between-stack-and-call-stack-in-javascript
Comment 3 Rizal Muttaqin 2023-03-20 07:55:17 UTC
(In reply to Rafael Lima from comment #2)

> 
> An icon already exists for removing watch variables (it is also highlighted
> in the image), so this might be used as inspiration for the Watch Window
> toggle.

Yes, This was already coming to my head before I saw your actual comment
 
> As a side note, I think the existing Remove Watch icon could be replaced by
> something that better resembles a "remove" action.

That should be another bug report

> The Watch window's objective is to watch the content of variables during
> execution, hence the use of an eye in this icon. I think we could use
> binoculars or a microscope to represent the same idea.
> 
> The Call Stack window "allows you to monitor the sequence of procedures and
> functions during the execution of a program. The procedures are functions
> are displayed bottom to top with the most recent function or procedure call
> at the top of the list." (text from the help)
> 
> There's an image in the link below that is a good representation of a stack
> and I believe it'll inspire the creation of an icon.
> 
> https://stackoverflow.com/questions/62725430/what-is-the-different-between-
> stack-and-call-stack-in-javascript

Would be better if we see to look at icon in other IDEs? Understanding the concept will be easier if there is something that can be imitated haha
Comment 4 Rafael Lima 2023-03-20 19:41:27 UTC
(In reply to Rizal Muttaqin from comment #3)
> Would be better if we see to look at icon in other IDEs? Understanding the
> concept will be easier if there is something that can be imitated haha

These are the icons used by MS (see Watch Window and Call Stack):

https://www.fmsinc.com/microsoftaccess/Module-Coding-Tools/debugging/shortcuts.htm

Here's a nice idea for a Call Stack icon:

https://www.clipartmax.com/middle/m2H7G6i8Z5H7m2H7_layers-papers-stack-icon-icon/
Comment 5 Commit Notification 2023-04-26 00:12:14 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d91dc9ffd57d749946dd6062a3d961fab47ec607

tdf#153789 KJ: icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-05-15 01:23:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/73b35219cc9ed42072506ed18a5767f072e1da02

tdf#153789 Breeze icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-05-15 08:50:51 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d1dce8d84ad9d19897007823d5af5b9e69f3f564

tdf#153789 elementary icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-05-15 20:11:04 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dc60f3b9f90ebd4d76bbc28cd2a1f1131e84a4d3

tdf#153789 Sukapura icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-05-15 20:11:07 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/172aa5d1ed851366f78375c297a5d458416f7d03

tdf#153789 Colibre icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-05-16 02:57:54 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1303d88047e21fd40c0d1cf056727efc7d690d9c

tdf#153789 sifr icons for Watched Expressions and Call Stack

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Rafael Lima 2023-05-17 13:37:58 UTC
Thanks @Rizal for the new icons.

Verified with:

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 00ede35a5241925d7060dd44fb81b71f7b03091c
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded