Bug 154295 - Standardize size of the Remove Watch icon
Summary: Standardize size of the Remove Watch icon
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-20 19:52 UTC by Rafael Lima
Modified: 2023-03-21 09:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Remove watch in Galaxy icon theme (3.77 KB, image/png)
2023-03-20 23:48 UTC, Rizal Muttaqin
Details
Remove Watch in Different Icon Themes (45.64 KB, image/jpeg)
2023-03-21 08:56 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-03-20 19:52:41 UTC
This is a spinoff of bug 153789.

See attachment 186053 [details] from bug 153789. Notice that the existing icon used for the "Remove Watch" command does not make it clear that it is a "remove" operation.

In its current state, this icon would be more suitable for toggling the Watch Window instead of removing a watch.

Maybe we could improve this icon so that it conveys more clearly that a Watch is going to be removed.
Comment 1 Rizal Muttaqin 2023-03-20 23:48:50 UTC
Created attachment 186101 [details]
Remove watch in Galaxy icon theme

Seems the icon is cut off, there's a 'x' symbol there but the button size is not enough to show them. With Galaxy icon, we can see the icon as a whole.
Comment 2 Rizal Muttaqin 2023-03-21 01:43:22 UTC
What makes me confuse while the Galaxy icon has 26px*26px in size, the other themes use different size : 16px*16px, 22px*22px, 24px*24px which is lower than Galaxy's obviously but those size produces cut offed appearance. 

The icon itself is res/baswatr.(png/svg). I just cand find the icon definition within /basctl/uiconfig/basicide/ui/dockingwatch.ui line 8:

<property name="icon_name">res/baswatr.png</property>

Someone has to provide a code pointer to standardize these icon sizes. Or maybe it's better to follow the user's icon size settings (small, large, very large).

Added Heiko
Comment 3 Heiko Tietze 2023-03-21 08:16:38 UTC
Why not just redraw all icons in the same size? We use 16px for all statusbar icons in bug 153344.

find . -name baswatr.png -exec file {} \;
./icon-themes/sifr/res/baswatr.png: PNG image data, 16 x 16, 8-bit colormap, non-interlaced
./icon-themes/breeze/res/baswatr.png: PNG image data, 18 x 16, 8-bit colormap, non-interlaced
./icon-themes/breeze/svx/res/baswatr.png: PNG image data, 16 x 16, 8-bit colormap, non-interlaced
./icon-themes/breeze_dark/res/baswatr.png: PNG image data, 18 x 16, 8-bit colormap, non-interlaced
./icon-themes/breeze_dark/svx/res/baswatr.png: PNG image data, 16 x 16, 8-bit colormap, non-interlaced
./icon-themes/elementary/res/baswatr.png: PNG image data, 24 x 24, 8-bit/color RGBA, non-interlaced
./icon-themes/sukapura/res/baswatr.png: PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
./icon-themes/karasa_jaga/res/baswatr.png: PNG image data, 24 x 24, 8-bit/color RGBA, non-interlaced
./icon-themes/sifr_dark/res/baswatr.png: PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
./icon-themes/sukapura_dark/res/baswatr.png: PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
./icon-themes/colibre/res/baswatr.png: PNG image data, 16 x 16, 8-bit colormap, non-interlaced
./icon-themes/colibre_dark/res/baswatr.png: PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
Comment 4 Rizal Muttaqin 2023-03-21 08:56:46 UTC
Created attachment 186109 [details]
Remove Watch in Different Icon Themes

(In reply to Heiko Tietze from comment #3)
> Why not just redraw all icons in the same size? We use 16px for all
> statusbar icons in bug 153344.

That's the problem, if the size is not 26px*26px like Galaxy, the icon will be cropped. while 26px*26px is the past size.
Comment 5 Heiko Tietze 2023-03-21 09:04:29 UTC
True, it's not a static statusbar icon but an image associated with a command, or at least it should be. Can look into it.