Bug 154242 - The explanatory image in UI Chooser (.uno:ToolbarModeUI) looked blurred
Summary: The explanatory image in UI Chooser (.uno:ToolbarModeUI) looked blurred
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-17 14:49 UTC by Rizal Muttaqin
Modified: 2023-03-21 05:59 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Eagle eye can see the bluriness here (36.04 KB, image/png)
2023-03-17 14:49 UTC, Rizal Muttaqin
Details
Graphic asset to be tested (8.44 KB, image/png)
2023-03-17 15:41 UTC, Rizal Muttaqin
Details
Here the capture of the dialog with the new graphic (33.15 KB, image/png)
2023-03-17 15:43 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2023-03-17 14:49:52 UTC
Created attachment 186026 [details]
Eagle eye can see the bluriness here

Steps to reproduce
1. Open any LibreOffice module (except Math and Base)
2. Click View > User Interface ...
Comment 1 V Stuart Foote 2023-03-17 15:21:22 UTC
That looks to be a 250 x 94 px bitmap, of course it is going to be blurry. No different than the thumbnail views on startcenter.

I suppose you could attempt to dynamically compose the from component SVG icons for HiDPI use, but at 90-115 dpi typical monitor resolutions the bitmap suffices.

Don't see too much value to the effort other than doing it dynamically would allow us to also preview color theme response.
Comment 2 Rizal Muttaqin 2023-03-17 15:41:45 UTC
Created attachment 186031 [details]
Graphic asset to be tested

I have created my own graphic with 321px*125px exact canvas size. Of course the graphic also fir perfectly with gridline. But somehow the result is still blurry.

To test, copy the file to the /opt/libreofficedev(version)/share/toolbarmode/ directory.
Comment 3 Rizal Muttaqin 2023-03-17 15:43:01 UTC
Created attachment 186032 [details]
Here the capture of the dialog with the new graphic
Comment 4 Rizal Muttaqin 2023-03-17 15:45:58 UTC
(In reply to V Stuart Foote from comment #1)
> That looks to be a 250 x 94 px bitmap, of course it is going to be blurry.
> No different than the thumbnail views on startcenter.

No, all the bitmaps size are 321px*125px.

> I suppose you could attempt to dynamically compose the from component SVG
> icons for HiDPI use, but at 90-115 dpi typical monitor resolutions the
> bitmap suffices.

I use 100% global scale and 1920x1080 resolution. No HiDPI so it's not related. Put it for further use case.
Comment 5 Rizal Muttaqin 2023-03-18 05:04:04 UTC
(In reply to Rizal Muttaqin from comment #2)
> Created attachment 186031 [details]
> Graphic asset to be tested
> 
> I have created my own graphic with 321px*125px exact canvas size. Of course
> the graphic also fir perfectly with gridline. But somehow the result is
> still blurry.
> 
> To test, copy the file to the
> /opt/libreofficedev(version)/share/toolbarmode/ directory.

Sorry the mistake was mine for not looking carefully at the starting point of the grid. Now every image is very crisp as expected. Patches follow
Comment 6 Rizal Muttaqin 2023-03-18 05:05:46 UTC
Patch:
https://gerrit.libreoffice.org/c/core/+/149077
Comment 7 Commit Notification 2023-03-18 12:50:22 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/60901415ef727622c4820cc30bf6324b0cc6b0a3

tdf#154242 Explanatory images of UI Chooser (.uno:ToolbarModeUI)

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 V Stuart Foote 2023-03-19 00:57:06 UTC
Compared recent against current nightly, the new images do look more crisp.

Notice we only deploy the share/toolbarmode PNG precompiled. Any benefit to dynamically creating from SVG on os/DE scaling like done for the icon themes? Or best to wait and just directly use the SVG in the UI?

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 183c3d58fbaf20a61b589d8f8f29bffc07fbe7dd
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 9 Commit Notification 2023-03-19 08:58:10 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/3c91c89a1a89a9f237780106efdd4125550cc76b

tdf#154242 Explanatory images of UI Chooser (.uno:ToolbarModeUI)

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-03-21 03:38:40 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a542956c8c2f80f4dd660aa0eef3f1dbab340ba3

tdf#154242 and tdf#154143 Asset images for UI Chooser and ToTD

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-03-21 05:59:56 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/882a7c9144cd99eb2ae9c5c8e7d87ef16f239b37

tdf#154242 and tdf#154143 Asset images for UI Chooser and ToTD

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.