Created attachment 186043 [details] Names of the dafault layers In each modify layer dialogue for all three default layers is the name of the layer not localised. Although the names are not editable, they should be translatable. 1. Open Draw. 2. Open the modify layer dialogue via double-click on a layer in the layer tab bar. Occurs in Version: 7.4.6.2 (x86) / LibreOffice Community Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded and Version: 7.4.6.2 (x64) / LibreOffice Community Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded
Thank you for the report. Yes, they should use the same string that is already used in the tabs. Reproduced French UI in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1b463f697405e64a03378fb38a32172c4d3c25e6 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: fr-FR Calc: threaded
Bibisected with linux-64-6.2 repository to first bad commit 5f599610abef8efb0c0bca0593fcef941fbe2ebc which points to the fix for bug 67248 and bug 119956: commit a9ec212c1b545d745285f0ab3119a80713b1d1f2 author Regina Henschel <rb.henschel@t-online.de> Fri Sep 14 18:56:23 2018 +0200 committer Regina Henschel <rb.henschel@t-online.de> Fri Sep 21 11:32:34 2018 +0200 tdf#67248 Use localized layer name only for display in UI Reviewed-on: https://gerrit.libreoffice.org/60507 Regina, what are your thoughts? The greyed-out name in the dialog does look like a bug currently, and should display the localised name in my opinion. We can use the UI name there while still disallowing the use of the internal name when the field is editable. In addition, instead of the error message string: "The name chosen already exists." We could use the more transparent: "This name can't be used: it is either reserved or the name of another layer."
(In reply to Stéphane Guillou (stragu) from comment #2) > Regina, what are your thoughts? The greyed-out name in the dialog does look > like a bug currently, and should display the localised name in my opinion. > We can use the UI name there while still disallowing the use of the internal > name when the field is editable. I don't know, whether it is possible to use the UI name in the field. On the other hand you now see, which terms are internally actually used and therefore forbidden for own layers. So for me it is not a bug to show the internal names. > > In addition, instead of the error message string: > "The name chosen already exists." > We could use the more transparent: > "This name can't be used: it is either reserved or the name of another > layer." That is possible. You need to create a new STR_WARN_LAYER_NAME_DUPLICATE because the current STR_WARN_NAME_DUPLICATE is also used for line ends.