Bug 154409 - A single click on a shape/image with frame should select the frame, instead of the image
Summary: A single click on a shape/image with frame should select the frame, instead o...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Frame Caption
  Show dependency treegraph
 
Reported: 2023-03-26 22:12 UTC by Telesto
Modified: 2023-03-29 21:41 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-03-26 22:12:11 UTC
Description:
A single click on a shape/image with frame should select the frame, instead of the image

Steps to Reproduce:
1. Open Writer
2. Insert an image
3. Add a caption frame
4. Deselect the frame/image
5. Try reselecting the frame with a mouse click (and without using the navigator)

Actual Results:
You mostly click on the image inside, and you get bugs like this.. bug 154402. Same issue for accessing the properties of the frame by right click

Expected Results:
Single left click on image with frame (if unselected) -> select frame
Right click on image in frame (if unselected) -> context menu for frame
Double click on image in frame 'enter shape', so selecting the image as such


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1cfeb4bd8ce7f7727a81136bd3e2d6ebea976895
CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 1 Eyal Rozenberg 2023-03-26 22:45:23 UTC
I don't have a strong opinion about this. Could live with both kinds of behavior personally. Convince me?
Comment 2 m_a_riosv 2023-03-27 01:47:06 UTC
I agree that it's a bit confusing the actual behavior. Even seems to have the intention to facilitate the access to the image.

I think it could match on how it happens with charts, first click select the object and the context menu it's for the object, double-click selects the chart and context menu give access to chart properties. Or with shapes to select the text in them.

But being a long time behavior, If at least it was possible, some kind of indication helping about what you are selecting.
Comment 3 Heiko Tietze 2023-03-27 09:11:10 UTC
If the frame contains text you definitely want to edit it rather than moving things around. We have a large number of tickets around this topic some use cases demand for quick editing other for the opposite (your shape with caption example).

A possible solution is to have a design vs. edit modus that needs to be switched manually (where per button or per double click). We could also define a (larger) range/area/zone around the frame that wouldn't go into the edit mode but key here is the feedback as most users would click in the middle of the object to move. I imagine some bluish highlighting of the the frame activation zone on hover.
Comment 4 m_a_riosv 2023-03-27 10:33:02 UTC
(In reply to Heiko Tietze from comment #3)
> ... I imagine some bluish highlighting of the the
> frame activation zone on hover.

Seems to me the simpler and helpful way to go.
Comment 5 Telesto 2023-03-27 12:39:06 UTC
(In reply to Heiko Tietze from comment #3)
> If the frame contains text you definitely want to edit it rather than moving
> things around.

True

> We have a large number of tickets around this topic some use
> cases demand for quick editing other for the opposite (your shape with
> caption example).

Even faster? You can directly click on text in frame at this point? But yes, I would be very disturbing if clicking on caption text would entail selecting the frame. [Example: Insert a text box. type some text. Deselect the text. Click on the text]

> A possible solution is to have a design vs. edit modus that needs to be
> switched manually (where per button or per double click).

Yes

> We could also define a (larger) range/area/zone around the frame that wouldn't >go into the edit mode but key here is the feedback as most users would click in > the middle of the object to move. I imagine some bluish highlighting of the  
> the frame activation zone on hover.

Also fine with me :-)

--

The perceived problem at this point:
* accidentally select modify the position of the image within the frame by drag.
* accidentally select the image and modifying the anchor of the image within the frame, instead of the anchor of the frame
* accidentally change the wrap of the image within the frame
* resize the image as such, instead of frame + image (note: there is bug that image doesn't scale with frame, if frame exceeding the page margins)

--
I personally conceptualize caption frame as grouped object. The main reason for proposing the single click select group/double click to enter group system.

The nicest thing would be if it would be possible exclude the text area of the frame of the 'grouped' effect. So click on the caption text would directly access the text itself. This actually how Impress handles things, I think.

Else you end up with something like select frame & press F2, but that's less intuitive
Comment 6 Stéphane Guillou (stragu) 2023-03-29 21:41:52 UTC
I agree with the idea here, as long as we keep the direct access to caption text. It would help avoid quite a few mishaps, as Telesto listed.
Seems there is widespread agreement on this enhancement, so setting to new.