Bug 154493 - Default "Presentation Style" is an empty/dummy style
Summary: Default "Presentation Style" is an empty/dummy style
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.3 target:7.5.8
Keywords:
Depends on:
Blocks: ImpressDraw-Styles GTK3
  Show dependency treegraph
 
Reported: 2023-03-30 21:44 UTC by Eyal Rozenberg
Modified: 2024-04-22 23:49 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Impress window with the empty modification dialog (93.45 KB, image/png)
2023-03-31 08:18 UTC, Eyal Rozenberg
Details
what I get (99.11 KB, image/png)
2023-03-31 09:42 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-03-30 21:44:51 UTC
By default, in a new presentation, on the first slide and with no slide element selected, the select Presentation Style (which isn't a presentation style, see bug 154492) is "Background".

Regardless of whether that is an appropriate situation or not - if one modifies this default style, a window opens with no content displayed except for 4 buttons: Help, Reset, Cancel, Ok. If one tries to enlarge the window - its main area is empty.
Comment 1 Eyal Rozenberg 2023-03-30 21:45:32 UTC
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 2 Heiko Tietze 2023-03-31 07:48:39 UTC
When I start a new presentation without a template the first slide has a title and a content. The background is set to "None" aka no color. Sounds correct to me. What do you expect?
Comment 3 Eyal Rozenberg 2023-03-31 08:18:38 UTC
Created attachment 186352 [details]
Impress window with the empty modification dialog

Illustration of the problem: Note the empty dialog with only buttons and no controls for actually modifying the style.
Comment 4 Eyal Rozenberg 2023-03-31 08:20:27 UTC
(In reply to Heiko Tietze from comment #2)
> When I start a new presentation without a template the first slide has a
> title and a content. The background is set to "None" aka no color. Sounds
> correct to me.

It is correct, but it's just not what this bug report is about, please re-read. I've even added a screenshot to emphasize.
Comment 5 Heiko Tietze 2023-03-31 08:30:09 UTC
(In reply to Eyal Rozenberg from comment #3)
> Created attachment 186352 [details]
> Impress window with the empty modification dialog

Caolan, this is a gtk issue. With kf5/qt6 I get the usual dialog (with a lot of white space but still sized according the needed space), starting with gtk3/gtk4 I run into an assertion

soffice.bin: /home/ht/Sources/libreoffice/vcl/unx/gtk3/gtkinst.cxx:8910: int (anonymous namespace)::GtkInstanceNotebook::remove_page(GtkNotebook *, std::string_view): Assertion `nPageNumber != -1 && "asked to remove page that doesn't exist"' failed.

(and Eyal gets a minimized window with the official fresh version)
Comment 6 Eyal Rozenberg 2023-03-31 08:35:44 UTC
(In reply to Heiko Tietze from comment #5)
> (and Eyal gets a minimized window with the official fresh version)

It's not just minimized; if I enlarge it there's still nothing in there.
Comment 7 Caolán McNamara 2023-03-31 09:42:22 UTC
is this sidebar, presentation styles, right click on background, edit style? If so I'm not seeing what is shown in the screenshot
Comment 8 Caolán McNamara 2023-03-31 09:42:39 UTC
Created attachment 186356 [details]
what I get
Comment 9 Heiko Tietze 2023-03-31 10:30:20 UTC
(In reply to Caolán McNamara from comment #8)
> what I get

Happens if you start from a page with no background color (the default without template).
Comment 10 Eyal Rozenberg 2023-03-31 10:39:04 UTC
(In reply to Caolán McNamara from comment #7)
> is this sidebar, presentation styles, right click on background, edit style?

The context menu item is "Modify...", but yes.

I'll note I don't see this with kf5.
Comment 11 Eyal Rozenberg 2023-03-31 10:40:02 UTC
(In reply to Eyal Rozenberg from comment #10)
> I'll note I don't see this with kf5.

... nor with qt5.
Comment 12 Caolán McNamara 2023-03-31 15:28:37 UTC
I don't reproduce with a debugging self build, but I do see it in my distro libreoffice-7.4.6.2
Comment 13 Stéphane Guillou (stragu) 2024-04-22 23:49:56 UTC
Resolved by Caolán McNamara with:
https://git.libreoffice.org/core/commit/9150c8c09645be12849cdb5aad484ee344b7b313
Resolves: tdf#157515 only remove RID_SVXPAGE_PARA_ASIAN once

Checked with linux-64-24.2 bibisect repo.

Thanks Caolán!