Bug 154583 - Split button Color Picker regression, attempting a color pick now opens the Line or Area object dialog
Summary: Split button Color Picker regression, attempting a color pick now opens the L...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords: bibisected, bisected, regression
: 155063 155338 155404 155686 (view as bug list)
Depends on:
Blocks: Color-Picker-Widget
  Show dependency treegraph
 
Reported: 2023-04-03 13:37 UTC by surbun
Modified: 2023-06-08 05:05 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
File to show bug (81.63 KB, image/jpeg)
2023-04-03 13:38 UTC, surbun
Details

Note You need to log in before you can comment on or make changes to this bug.
Description surbun 2023-04-03 13:37:36 UTC
Description:
On choosing, color either for line color or fill color, from the dropdown menu, a opoup window appears instead applying the chosen color

Steps to Reproduce:
1.Open Draw or Impress
2.Draw anything eg: a square
3.Click in the arrow to choose a color
4.c Choose any color

Actual Results:
Popup window appears

Expected Results:
Chosen color is applied


Reproducible: Always


User Profile Reset: Yes

Additional Info:
I tried with different user's interfaces.
I got the same result

I tried to see if the same thing happens in Impress
Same result in this module
Comment 1 surbun 2023-04-03 13:38:16 UTC
Created attachment 186438 [details]
File to show bug
Comment 2 Stéphane Guillou (stragu) 2023-04-03 14:00:51 UTC
Thank you, surbun.

Can you please paste here the information copied from Help > About LibreOffice?

Thank you!
Comment 3 V Stuart Foote 2023-04-03 18:36:48 UTC
Confirmed, however I don't see this as an issue.

A click on the split button will assign the 'currently' shown color. While opening the palette color picker and making a color selection (needed to change the active color selection) does open an object attribute dialog:  "Line..." in this example.

You can set a color as expected. And that color will become the active color of the split button.  But with the dialog open, other drawing object attributes are also exposed.

Same behavior with the area fill split button, and drawing polygonal shape objects expose the "Area..." dialog.

Seems consistent and functional. Assume it is intentional.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b463f697405e64a03378fb38a32172c4d3c25e6
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 4 V Stuart Foote 2023-04-03 18:40:48 UTC
Yes you have to pick a color from the palette "twice", but with the dialog open you can directly adjust ~ALL attributes of the drawing shape. 

Believe that is intended behavior of the split button's for the line and area color buttons.
Comment 5 surbun 2023-04-05 09:41:15 UTC
(In reply to Stéphane Guillou (stragu) from comment #2)
> Thank you, surbun.
> 
> Can you please paste here the information copied from Help > About
> LibreOffice?
> 
> Thank you!

information asked for 

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 96aad0d0497c8486f8affc8fed79e63a060c9a59
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

Thanks for working on this issus
Comment 6 surbun 2023-04-05 09:48:30 UTC
(In reply to V Stuart Foote from comment #4)
> Yes you have to pick a color from the palette "twice", but with the dialog
> open you can directly adjust ~ALL attributes of the drawing shape. 
> 
> Believe that is intended behavior of the split button's for the line and
> area color buttons.

This dropdown menu is assigned to change only color of the shape or line.
If ever the end-user has to change much more than the color, another button is assigned for this.
Actually, there's 2 buttons doing the same thing rather than belaving as it is there on all prior versions.
Comment 7 V Stuart Foote 2023-04-05 13:14:56 UTC
SO, NAB or an implementation issue? Someone did it intentionally.

My take => NAB
Comment 8 Stéphane Guillou (stragu) 2023-04-05 13:32:18 UTC
Stuart, I think what surbun is referring to is that clicking on a colour in the colour selector dropdown opens the Line or Area dialogs respetively (in 7.6) instead of simply assigning the colour to the button (in 7.5 and before).

Bibisecting with linux-64-7.6 repo, the behaviour starts with commit 68b6676065f94a623f6b41d8769cfdf77a8839d8 which is core commit:

commit 855f7c08d1feab7669670bfbc4ed2b3b3225db16
author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	Sat Feb 11 11:24:05 2023 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	Wed Mar 01 12:57:21 2023 +0000
send theme info when changing color (in the picker) via UNO command
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146817

Prior to that commit, consistent with other components like Writer, selecting a colour applies the colour to the selection (if something is selected) or just changes the active colour for the button (if nothing is selected).

Tomaž, I assume this is an unintended consequence of your change, correct?
Comment 9 V Stuart Foote 2023-04-05 13:35:04 UTC
(In reply to Stéphane Guillou (stragu) from comment #8)

Agree, adjusted the issue summary accordingly...
Comment 10 Stéphane Guillou (stragu) 2023-04-05 13:44:05 UTC
(In reply to V Stuart Foote from comment #9)
> (In reply to Stéphane Guillou (stragu) from comment #8)
> 
> Agree, adjusted the issue summary accordingly...

Ah yes sorry, the pleasures of synchronous editing :)
Comment 11 Tomaz Vajngerl 2023-04-06 07:10:30 UTC
(In reply to Stéphane Guillou (stragu) from comment #8)
> Tomaž, I assume this is an unintended consequence of your change, correct?

Yes, it's not an intentional change :) The command for the color picker can behave differently depending on the input parameters. My change must have triggered a wrong code path.
Comment 12 Stéphane Guillou (stragu) 2023-04-28 10:21:24 UTC
*** Bug 155063 has been marked as a duplicate of this bug. ***
Comment 13 Stéphane Guillou (stragu) 2023-05-16 08:14:36 UTC
*** Bug 155338 has been marked as a duplicate of this bug. ***
Comment 14 Stéphane Guillou (stragu) 2023-05-19 10:32:19 UTC
*** Bug 155404 has been marked as a duplicate of this bug. ***
Comment 15 Xisco Faulí 2023-06-05 12:18:56 UTC
*** Bug 155686 has been marked as a duplicate of this bug. ***
Comment 16 Xisco Faulí 2023-06-05 12:19:26 UTC
Increasing importance based on number of duplicates
Comment 17 surbun 2023-06-07 08:01:12 UTC
(In reply to Xisco Faulí from comment #16)
> Increasing importance based on number of duplicates

Thanks to pay a particular attention to this bug
Comment 18 Stéphane Guillou (stragu) 2023-06-07 08:46:52 UTC
(setting back to "major" severity, I assume surbun's change was unintentional)
Comment 19 Tomaz Vajngerl 2023-06-08 01:24:20 UTC
Fixed with [1].. I put the duplicate bug number in the git comment by mistake. 

[1] https://gerrit.libreoffice.org/c/core/+/152713