Bug 155153 - Calc: menu item "Format - Group" should be more clear
Summary: Calc: menu item "Format - Group" should be more clear
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.2.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2023-05-05 08:01 UTC by levtoji
Modified: 2024-09-04 11:19 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description levtoji 2023-05-05 08:01:43 UTC
Description:
When selecting rows and clicking Format - Group (or something like this, using german version) the menu is greyed out. When using the shortcut F12, it works.


Steps to Reproduce:
1. Select rows
2. Pick Format - Group
3. Greyed out menu

Actual Results:
Nothing

Expected Results:
Grouping works


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 16; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

NixOS build
Comment 1 ady 2023-05-05 10:25:09 UTC
It is... Kind of a repro, but not exactly.

Keyboard shortcut F12 is equivalent to menu Data > Group and Outline > Group.

And, indeed, within the Format > Group submenu, the entries are all grayed out.

So maybe this is about documentation, or better labeling the current Format > Group menu?
Comment 2 Roman Kuznetsov 2023-05-05 12:56:17 UTC
Format - Group menu is from shapes grouping. And I think it's in our documentation (that nobody read)

I agree with ady - we need some changes here. 

Fromat - Shapes Group may be?
Comment 3 levtoji 2023-05-06 14:35:52 UTC
You are of course right, the function I searched for was Data > Group and Outline > Group. When searching online for the functionality, I found an instruction for the other menu. I was not searching for a long time, so we can maybe blame it on me.
Comment 4 Heiko Tietze 2023-05-08 13:40:49 UTC
(In reply to Roman Kuznetsov from comment #2)
> Format - Shapes Group may be?

+1, yet it reads strange
Comment 5 Heiko Tietze 2023-05-08 13:50:48 UTC
Code pointer: 

.uno:GroupMenu in [1] and in [2] (both labels are "Group")

AFAICS all apps (sw*, sc, sd*) collect the commands .uno:FormatGroup, .uno:FormatUngroup, .uno:EnterGroup, and .uno:LeaveGroup under this submenu. 

Calc has a context menu for drawing objects with this submenu.

[1] officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
[2] officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
Comment 6 Roman Kuznetsov 2023-05-11 19:15:18 UTC
Set to NEW by Comment 4.

EasyHack for beginners, code pointers are above
Comment 7 BogdanB 2024-08-24 14:45:54 UTC
Changes are in gerrit. Please check:

https://gerrit.libreoffice.org/c/core/+/172278
Comment 8 BogdanB 2024-08-24 14:50:23 UTC
Also, if this changes are correct, those are changes neded for Help:
https://help.libreoffice.org/latest/ro/text/shared/01/05290000.html?DbPAR=SHARED#bm_id741693143580680 

Choose Format - Group. -> Choose Format - Shapes Group.

Also here
https://help.libreoffice.org/latest/ro/text/sdraw/main_shape.html?DbPAR=DRAW
Group -> Shapes Group
Groups keep together selected objects, so that they can be moved or formatted as a single object.
Comment 9 Commit Notification 2024-09-02 14:56:49 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1a95aa91f7cfe7765a5277cca09b35c398638a23

tdf#155153 Change "Group" to "Group Shapes" and remove duplicated node.

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Buovjaga 2024-09-03 14:13:05 UTC
(In reply to BogdanB from comment #8)
> Also, if this changes are correct, those are changes neded for Help:
> https://help.libreoffice.org/latest/ro/text/shared/01/05290000.
> html?DbPAR=SHARED#bm_id741693143580680 
> 
> Choose Format - Group. -> Choose Format - Shapes Group.
> 
> Also here
> https://help.libreoffice.org/latest/ro/text/sdraw/main_shape.html?DbPAR=DRAW
> Group -> Shapes Group
> Groups keep together selected objects, so that they can be moved or
> formatted as a single object.

Do you plan to work on it?
Comment 11 BogdanB 2024-09-03 14:53:38 UTC
(In reply to Buovjaga from comment #10)
> (In reply to BogdanB from comment #8)
> > Also, if this changes are correct, those are changes neded for Help:
> > https://help.libreoffice.org/latest/ro/text/shared/01/05290000.
> > html?DbPAR=SHARED#bm_id741693143580680 
> > 
> > Choose Format - Group. -> Choose Format - Shapes Group.
> > 
> > Also here
> > https://help.libreoffice.org/latest/ro/text/sdraw/main_shape.html?DbPAR=DRAW
> > Group -> Shapes Group
> > Groups keep together selected objects, so that they can be moved or
> > formatted as a single object.
> 
> Do you plan to work on it?

Yes, in the next days. I was on vacation for some days.
Comment 12 Commit Notification 2024-09-04 10:44:42 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/ef0468c99468c3f58211d9d327f8d8deaae90d86

tdf#155153 Change "Group" to "Group Shapes"