Bug 155182 - XHTML-Export: Min-Width is set to 0cm together with bullets
Summary: XHTML-Export: Min-Width is set to 0cm together with bullets
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.2.0.3 rc
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.5.5 target:7.6...
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: (X)HTML-Export
  Show dependency treegraph
 
Reported: 2023-05-08 05:41 UTC by Robert Großkopf
Modified: 2023-06-09 08:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2023-05-08 05:41:10 UTC
Open attachment
https://bugs.documentfoundation.org/attachment.cgi?id=120369
from bug 95662.
Go to File → Export.
Chose export to xhtml.
All content will be shown starting on left border.
Margin-left and min-width will both be set to 0cm.

This bug first appears with LO 7.2.0.3 on OpenSUSE 15.4 64bit rpm Linux.
Reading this it is already bisected:
https://bugs.documentfoundation.org/show_bug.cgi?id=95662#c27
Comment 1 BogdanB 2023-05-08 19:37:00 UTC
Confirm with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5619fc438273cd15e78539e78b8af751bca24b1a
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 2 Franklin Weng 2023-05-10 06:40:06 UTC
I sent a commit which will create the same result before this commit: https://git.libreoffice.org/core/+/9d3b39cf9fed9a305ac23d1ecaaafc8f7caaeeb0%5E%21 

It seems that the variable minLabeWidth test condition was not correctly set so it always returns true.

But the result is still not exactly the same as in the sample odt file.  To fully simulate the result in odt file, the <li> tag should have list-style-type attribute set (currently the item bullet character was displayed as a text) and margin-left value set with <p> tag so that texts in an item can aligned correctly after the bullet character.
Comment 3 Svante Schubert 2023-06-08 06:57:45 UTC
Hi Franklin,

Thank you for the patch!

I have checked your patch an can confirm that now - with your fix - the attribute 
@text:min-label-width is no longer taken as first option if it has the value 0.

I looked it up: The value of the attribute @text:min-label-width is none negative:
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#property-text_min-label-width


The fix becomes apparent in test document of 
https://bugs.documentfoundation.org/show_bug.cgi?id=146264

@Michael Stahl: Likely the regression tests have to be adopted, right?


Best regards,
Svante
Comment 4 Commit Notification 2023-06-08 15:27:52 UTC
Franklin Weng committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7f5e2fc7c1ae7c0c2bec76809e11365b255601d5

tdf#155182 : fix test of $minLabelWidth which is always true

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-06-08 17:21:02 UTC
Franklin Weng committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/e66251c6a30e2ab6bd8052c07ff3f69bbe85ca54

tdf#155182 : fix test of $minLabelWidth which is always true

It will be available in 7.5.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-06-09 08:40:41 UTC
Franklin Weng committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/12b216ba8d9ca66924a2ed74c5e21b063f1ef6a3

tdf#155182 : fix test of $minLabelWidth which is always true

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.