Created attachment 187477 [details] document with several index entries Enhancement proposal/request for "Edit Index Entry" dialog. At present, the only function of the "Apply" button in the dialog is to "save" the currently changed index entry (before using the "Close" button to close the dialog). (if you use the navigation arrows in the dialog, then you will see that changing from one index entry to another results in any changes being applied automatically). Proposal 1: Make the "Close" button automatically save any changes that are made in the current index entry. Proposal 2: Change the functionality of the "Apply" button (and relabel it to "Reset") so that it "resets" any changes to the current entry that have not yet been applied. Reasons: For proposal 1 -- eliminates an extra step/click in the workflow. For proposal 2 -- at present the "Apply" button is only needed for closing a just-changed entry. If proposal 1 is implemented, then, in principle, the "Apply" button could be deleted. But even better would be to offer the possibility to reset the current entry from any changes that were made (by accident). This would also allow resetting the entry before closing, if necessary. [To see the dialog, use Insert - Table of Contents and Index - Index Entry to insert an index entry, then right-click in the entry and choose "Edit Index Entry". It can be useful to insert several entries so that the Navigation buttons appear, or use the attached test document which has several inserted index entries. Make sure that "View - Field Shadings" (Ctrl+F8) is enabled to find the entries.]
I'm always a friend of consistency through the different dialogs. So I won't rename "Apply" button, because it is actually in line with Apply button in many (all?) other dialogs. Instead we should add "OK" button, because in many (all?) other dialogs this saves changes and closes the dialog. Let's ask design-team
(In reply to Dieter from comment #1) > won't rename "Apply" button... Clarification: proposal is to *replace* (not "rename") "Apply" with another button with a different functionality.
(In reply to sdc.blanco from comment #0) > At present, the only function of the "Apply" button in the dialog... Before v7.6 the button was labelled "Ok". > ...is to "save" the currently changed index entry Doesn't it apply? The dialog is amodal allowing you to go through many entries not just via next/prev but also per interaction with the document text. > Proposal 1: Make the "Close" button automatically save any changes that are > made in the current index entry. If Close is Apply/Save how do you apply without closing? > Proposal 2: Change the functionality of the "Apply" button (and relabel it > to "Reset") so that it "resets" any changes to the current entry that have > not yet been applied. Reset means to revert changes made before, ie. using the attributes from the parent in case of styles.
(In reply to Heiko Tietze from comment #3) > Doesn't it [Apply] apply? Yes, but in general, it is not necessary to use this button, because simply navigating to another entry is sufficient to "save/apply" a change in an entry (without having to use the "Apply") button. > > Proposal 1: Make the "Close" button automatically save any changes that are > > made in the current index entry. > If Close is Apply/Save how do you apply without closing? At present, "Close" is *not* "Save". If you change a entry (and do not navigate to another entry) and "Close", then nothing is saved. It is necessary to "Apply" before "Close". (afaict, this is the only situation where, at present, the "Apply" button is actually needed/useful.) > Reset means to revert changes made before, ie. using the attributes from the > parent in case of styles. In this case, the "before" state would be index entry before making any editing changes. The idea is that if a mistake is made in editing the entry (and you have not navigated to another entry), then "Reset" would return the entry to the state it had before editing. This idea would be relevant/necessary if Proposal 1 is followed (with Save on Close), because "Reset" would be useful (to allow resetting an edited entry before using "Close"). All these points can be seen/confirmed by using the attachment, which already has some index entries.
(In reply to Heiko Tietze from comment #3) > (In reply to sdc.blanco from comment #0) > > At present, the only function of the "Apply" button in the dialog... > Before v7.6 the button was labelled "Ok". When did this rename take place? I still see "Ok" with a relatively recent nightly.
(In reply to Eyal Rozenberg from comment #5) > When did this rename take place? 22 May 23 - see bug 154186, comment 12
We discussed the topic in the design meeting. The workflow is not intuitive and the proposed modification not a complete solution. One issue that wouldn't be addressed is the fact that Close won't apply changes while next/prev and Apply do, non give proper feedback. Apply is handy at the moment if you have only one entry or want to change only one entry. We pondered over disabling Apply until changes are made, labels for prev/next with a hint for apply. Ultimately the verdict for this request is WF but we encourage to create follow-up tickets.