Insert index entry, then right-click on entry and choose "Index Entry" to edit. Actual: lower right corner of dialog has an "OK" button. It does not seem to do anything, and may not be needed (because there is a "Close" button). If it has no function, then maybe it should not be shown.
I can't reproduce it in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0483b0a4bbd41f026a53ff35ab3162b57bee1a91 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11 Locale: en-US (es_ES.UTF-8); UI: en-US Calc: threaded Could you please paste the info from Help - about LibreOffice ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the information has been provided
Created attachment 185954 [details] problematic document Have retested (also in Safe Mode). With a new document (both with and w/o Safe Mode), I can insert a index entry, edit the entry, and "OK" works. With the attached document (which I have been using for testing), when I edit an index entry, then "OK" does not work. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ee5dbd193fa24b46fb980ddd8a6c39ca349d0d01 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded
Created attachment 185968 [details] another document where OK does not work Here is a another document where "OK" does not work. Open attachment, edit an index entry. Press "OK". Nothing happens (using same version of LO as named in previous comment). => issue is not specific to one document.
@Xisco, insert at least two index entries, then Edit one of them and try the OK button. (this critical information was not in the OP) @UXEval: For Edit Index Entry dialog (screenshot in next comment) Propose: A. "Ok" -> "Apply" Reasons: 1. "Ok" is often used in LO to close a dialog box, but does not in this case, unless there is a single index entry. 2. "Apply" is often used in LO to apply changes, without closing the dialog, which is what happens (except for the single entry case). 3. OP and comments 2 and 3 demonstrate that I totally misunderstood how to use the dialog, but probably would not have had trouble if "Ok" was labeled "Apply" B. Change position of buttons to: [Help] [Delete] [Apply] [Close] Reasons: 1. "Close" position would correspond to the usual place for closing a dialog. 2. (afaict) The only time that "OK/"Apply" is ever needed is when one wants to close a dialog that has just gotten a change but has not switched to another entry, so the sequence is felicitous. C. Add a tooltip to "Close" , something like: "Closes dialog without saving non-applied changes" More ambitious proposal (in terms of work involved): 1. Replace "OK"/"Apply" with "Reset" (which would reset the current entry), and 2. Make "Close" also save a current (modified) entry.
Created attachment 185982 [details] Screenshot of Edit Index Entry dialog
(In reply to sdc.blanco from comment #4) > A. "Ok" -> "Apply" Makes sense (and should be a guideline).
Set to NEW by Comment 6 (and change it to enhancement)
https://gerrit.libreoffice.org/c/core/+/151195
(In reply to sdc.blanco from comment #8) > https://gerrit.libreoffice.org/c/core/+/151195 The sequence of confirmative (Ok, Apply) and destructive (Close, Cancel) buttons differs between Windows and (most/all?) Linux variants vs. macOS. We have a function that shuffles the buttons into the right order, IIRC. Do I, Caolan?
we have sort_native_button_order (which is typically run automatically with a dialog is shown) and (stable) sort them according to their names
(In reply to Caolán McNamara from comment #10) > we have sort_native_button_order (which is typically run automatically with > a dialog is shown) and (stable) sort them according to their names vcl/source/window/layout.cxx: getButtonPriority(std::u16string_view rType) sorts the buttons save, yes, ok, discard, no, cancel (In reply to sdc.blanco from comment #4) > B. Change position of buttons to: > [Help] [Delete] [Apply] [Close] It seems that changing Ok to Apply wont sort this button anymore, but Close becomes the right-most item anyway, if necessary. It other words keep [Help] [Close] [Delete] [Apply]
Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/098e9426ad0b66b3da873a519c10047cb3955b0f tdf#154186 change "OK" to "Apply" and rearrange button position It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
"Ok" is changed now to "Apply" -- but no changes to the ordering of the buttons. Closing as FIXED, and opening bug 155471 for further enhancements.