Bug 156260 - multipage floating table collapses when entering text outside of the table
Summary: multipage floating table collapses when entering text outside of the table
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:24.2.0 target:7.6.1
Keywords:
Depends on:
Blocks: DOCX-Floatingtable
  Show dependency treegraph
 
Reported: 2023-07-12 15:55 UTC by Regina Henschel
Modified: 2023-08-03 09:56 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
document with floating frame as I have received it (45.00 KB, application/vnd.oasis.opendocument.text)
2023-07-12 15:55 UTC, Regina Henschel
Details
Screenshot of the result (63.11 KB, image/png)
2023-07-12 15:55 UTC, Regina Henschel
Details
tdf156260 long table floating plus text (24.19 KB, application/zip)
2023-07-16 12:34 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2023-07-12 15:55:16 UTC
Created attachment 188338 [details]
document with floating frame as I have received it

Hi Miklos, do this:
Open attached file. That is the file you have sent to me.
Scroll down to the start of page 5. There is a paragraph mark outside the table.
Set curse there, press dt, then F3 to insert the dummy text.
The table now collapses to one page, see attached screenshot.

I have used Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fcbae818b793a9ee97a1b5ddc53902be7a2376f5
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

It would be good to have the original, non-odt file too.
Comment 1 Regina Henschel 2023-07-12 15:55:49 UTC
Created attachment 188339 [details]
Screenshot of the result
Comment 2 Miklos Vajna 2023-07-13 06:28:30 UTC
> It would be good to have the original, non-odt file too.

This is originally attachment 75671 [details] from bug 61594, a DOCX file.
Comment 3 Justin L 2023-07-13 19:51:34 UTC
confirmed using the DOCX from comment 2.

Regina - I think you should just leave the Hardware settings to ALL/ALL unless you know for certain that your reported problem is limited to certain specific environments. The vast majority of the time it is not OS/platform specific.
Comment 4 Regina Henschel 2023-07-15 18:21:04 UTC
If I open attachment 75671 [details] and save it immediately to odt, I get a file with five <draw:frame> elements. That is in contrast to the intension to have one table in one frame.
Comment 5 Regina Henschel 2023-07-16 12:34:15 UTC
Created attachment 188394 [details]
tdf156260 long table floating plus text

I see the overlap too when the attached docx file is opened in LibreOffice. Tested with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fcbae818b793a9ee97a1b5ddc53902be7a2376f5
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 6 Miklos Vajna 2023-07-17 06:58:23 UTC
Thanks, will try to investigate & fix, perhaps after bug 120262.
Comment 7 Commit Notification 2023-08-01 07:59:49 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/073072f0a3abacfe4f9cc920b8138d7abc84db70

tdf#156260 sw floattable: avoid overlapping flys on anchor change

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Miklos Vajna 2023-08-01 09:02:46 UTC
There is no collapse now, but some text still goes to page 4 from page 5, that still needs fixing.
Comment 9 Commit Notification 2023-08-02 06:06:41 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5e19348fb9507882827d29f875696ab225198be2

tdf#156260 sw floattable: avoid overlapping flys on anchor change

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-08-02 08:57:18 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6a22e2be79cd874c7526107a6793fae692620dc

tdf#156260 sw floattable: avoid moving text from the last anchor to its precede

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Miklos Vajna 2023-08-02 09:46:54 UTC
Now this is OK on master, I think.
Comment 12 Commit Notification 2023-08-03 09:56:03 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/262a1ae36eaf20e741759cd2c216456bbb472f7c

tdf#156260 sw floattable: avoid moving text from the last anchor to its precede

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.