Bug 156431 - Math: Undo doesn’t reset save document status
Summary: Math: Undo doesn’t reset save document status
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo ModifiedStatus
  Show dependency treegraph
 
Reported: 2023-07-23 11:54 UTC by maison
Modified: 2024-10-01 03:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description maison 2023-07-23 11:54:05 UTC
SUMMARY
Unlike most software, if you modify something in a saved document, then revert this change, LO doesn’t remember that the document is identical to what is has already saved.

STEPS TO REPRODUCE
1. Open a [new] file or save your current open document.
2. Change one or more things.
3. Cancel once or several times according to what you did in step 2.

OBSERVED RESULT
The Save (floppy disk) icon has a red dot showing the document has to be saved. If you want to close the document, LO will ask you to save it first.

EXPECTED RESULT
By reverting the changes, you brought the document in the original status, therefore it is identical to what is saved, thus there is no need to save.

SOFTWARE/OS VERSIONS
Windows: 7

ADDITIONAL INFORMATION
Unlike LO, many software (should I mention its main competitor?) remember this correctly. Not having to save will avoid an unnecessary question if you opened (let’s say) a spreadsheet, filtered some data to check, reverted that, then you want to close the file. It will avoid unnecessary doubts from the user during the workflow (did I save the file when necessary?) And it saves time on big files or external devices if you have to save “just by precaution”.
Comment 1 Stéphane Guillou (stragu) 2023-07-24 10:45:20 UTC
I can't reproduce with:

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I opened a new document, wrote some text, undid and the status bar icon was reset to its "no change" state.
I also tried with a previously-saved file.

Can you please provide more precise steps, exactly what actions you used, for the problem to arrise? Once you provide those, you can set the status back to "unconfirmed".
If the issue is about Calc, maybe it is already covered in bug 69972

Thank you!
Comment 2 maison 2023-07-24 11:27:04 UTC
Indeed, it doesn’ț seem to affect all the components, at least not Writer.
I mostly use Calc, where this forever bug is very annoying on large documents.
It also affects Impress, Draw, Math…
Comment 3 Stéphane Guillou (stragu) 2023-07-24 13:13:09 UTC
Thanks, maison. I can reproduce in Math:

1. Open Math
2. Type one character in Formula editor; alternatively, insert a symbol using the Elements pane.
3. Ctrl + Z and confirm that there is nothing left to undo (Undo button is greyed out)

Result:
Status icon is in its "unsaved" status. Closing the document prompts to save it.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 94caaf5c9e2917a3202cf515d61eaa9399b2c2b5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same in OOo 3.3, so marking as inherited.

Let's keep this one about the Math module.
For Impress/Draw, we already have bug 93519.
For Calc, we already have bug bug 69972.