Bug 93519 - Impress: Should reset the modified flag after undoing all changes
Summary: Impress: Should reset the modified flag after undoing all changes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ModifiedStatus
  Show dependency treegraph
 
Reported: 2015-08-18 22:35 UTC by Thangamani
Modified: 2021-12-12 09:57 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thangamani 2015-08-18 22:35:47 UTC
Steps to reproduce:

1. Open Impress
2. In the 'Click to add title' field type "Impression"
3. Click File -> Save
4. Give a valid filename(File01.odp) and save the file.
5. Close the file.
6. Open the File01.odp
7. Goto File -> Save. You can see the Save menu item is disabled as there is    nothing done to save.
8. Now add a letter to the text "Impression" making it "Impressions"
9. Goto File -> Save. You can see the Save menu item is enabled now.
10. Click Edit -> Undo (this resets the only change which was done earlier)
11. Goto File -> Save. 

Observed behavior:
The Save menu item remains enabled

Expected behavior:
The Save menu item should be disabled as the only change which was done is being undone and the application knows that there is nothing new/modified to be saved.
Comment 1 Buovjaga 2015-09-09 13:27:36 UTC
Not reproduced.

Win 7 Pro 64-bit, Version: 5.0.1.2 (32-bit)
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: fi-FI (fi_FI)
Comment 2 Buovjaga 2016-02-12 16:53:07 UTC
Save is now enabled all the time: https://bugs.documentfoundation.org/show_bug.cgi?id=96590#c18
Comment 3 Maxim Monastirsky 2016-02-13 20:06:48 UTC
Confirmed.

(In reply to Beluga from comment #2)
> Save is now enabled all the time:
Right, but the toolbar button will show the "modified" icon, as well as the status bar, and when closing you'll get the "Save changes to document before closing?" prompt. So still valid bug IMHO. Ideally we should reset the modified flag after undoing all changes.
Comment 4 QA Administrators 2017-03-06 15:41:57 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2019-12-03 14:44:59 UTC Comment hidden (obsolete)
Comment 6 Andrew Watson 2020-07-19 15:42:15 UTC
Bug confired present in:

Version: 7.0.0.2
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

Bug confirmed present in:

Version: 5.4.5.1
Build ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-GB (en_GB.UTF-8); Calc: group

Bug confired present in:

Version: 5.2.7.2
Build ID: 1:5.2.7-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; 
Locale: en-GB (en_GB.UTF-8); Calc: group

Bug confirmed present in:

Version 4.0.6.2 (Build ID: 2e2573268451a50806fcd60ae2d9fe01dd0ce24)
(Running under Mac OS X 10.11.6)

Bug confirmed present in:

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
(Running under Mac OS X 10.11.6)

Here's a clearer set of "Steps to reproduce" for the same bug on all LO versions:

1. Use File>New>Presentation (or, in some versions, File>Presentation) to create a new Impress presentation (in some LO versions you'll have to click "Cancel" on the "Select a Template" dialog that appears; on others a plain Impress slide appears straight away).

2. Ensure that View>Status Bar is selected, so that you have a status bar at the bottom of the window. This will include a "Document Modified" icon; the exact appearance of the icon varies from version to version, but hovering the mouse over it will give text saying "The document has not been modified since the last save".

3. Click in the slide, and type the words "Test Test Test" anywhere. Observe that the "Document modified" icon in the Status bar now shows that the document has been modied. On Mac OS, the red window "Close" button in the top left will also have a dot in it, to signify the same thing.

4. Use File>Save to save the document with some random name (e.g. "Thing.odp"). Observe that the "Document Modified" icon is now unset (and on Mac OS, the close button dot disappears).

5. Select one of the three "Test" words by double-clicking the mouse. Press the delete key. Observe that the "Document Modified" icon is now set (and on Mac OS, the close button has a dot).

6. Select Edit>Undo.

Observed behavior:
The "Document Modified" icon is set.

Expected behavior:
The "Document Modified" icon should be unset, since the only change made to the saved file has now been undone.

For comparison, try the same sequence of actions in Writer (i.e. create blank file, insert three words, save file, delete one word, undo delete). Unlike Impress, Writer will correctly reset the "Document Modified" icon.


Set Earliest affected version to "Inherited from OOo"; set operating systems to "All"; set Hardware to "All".
Comment 7 Andrew Watson 2021-02-21 10:11:55 UTC
Bug still present in:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 8 Andrew Watson 2021-12-12 09:57:57 UTC
Bug still present in:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded