Bug 156707 - FORMCONTROLS: Textboxes will be created with flat Border - 3D won't be shown after reopening Document
Summary: FORMCONTROLS: Textboxes will be created with flat Border - 3D won't be shown ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5 all versions
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:25.2.0
Keywords: bibisected, bisected, regression
: 156697 157970 162085 163843 (view as bug list)
Depends on:
Blocks: Form-Controls
  Show dependency treegraph
 
Reported: 2023-08-10 09:01 UTC by Robert Großkopf
Modified: 2024-11-11 22:43 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Controls, created in LO 7.6.0.2 - default for textboxes will always be flat border (24.00 KB, application/vnd.oasis.opendocument.text)
2023-08-10 09:01 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2023-08-10 09:01:14 UTC
Created attachment 188896 [details]
Controls, created in LO 7.6.0.2 - default for textboxes will always be flat border

Have a look at the attached Writer document.

If you open this document with LO 7.6.0.2 you will see all text boxes with flat border. Text boxes have been created the same way the other controls have been created. Only the text box will be created by default with flat border, all other controls will be created 3D.

Now change on of the text boxes to 3D and save the document. Close the document and reopen the document. There won't be shown 3D. It will still show flat border.

Note: If you open the saved document in an older version of LO, for example LO 7.4.7.2, it will show 3D for the text box. So the information has been saved, but won't be shown in LO 7.6.0.2

Version: 7.6.0.2 (X86_64) / LibreOffice Community
Build ID: 41d6f628ba3f046f16b5fa9fa8db8d4c2ab3b582
CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded
Comment 1 Sophie Sipasseuth 2023-08-17 09:20:06 UTC
Hello Robert,

Thank you for reporting the bug.
Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem.
Please provide a clearer set of step-by-step instructions to "change on of the text boxes to 3D".
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided
Comment 2 Robert Großkopf 2023-08-17 09:44:42 UTC
(In reply to Sophie Sipasseuth from comment #1)
> Please provide a clearer set of step-by-step instructions to "change on of
> the text boxes to 3D".

Open the attached document.
Set Form → Design Mode
Click on the first Text Box → Right Mouse click → Control Properties
Dialog "Properties: Text Box" will open.
Move down in Folder "General" to the entry "Border" (20. Entry).
Switch from "Flat" to "3D look".
Close the dialog "Properties: Text Box".
The border of the text box will be changed to 3D.
Save the document and close the document.

Open the document again and the text box will be shown with flat border.
Comment 3 Alex Thurgood 2023-08-22 11:19:12 UTC
Confirming also with dev master build dating from before the release of 7.6rc2

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 6256d5fe2e7cb1bb002d5fe59527d3a3fbf6963f
CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Metal; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded


The change seems to work when it is made in the control properties dialog, but then on switching out of design mode, saving the document, closing, and reloading, the appearance of the control has reverted back to flat.

Confirming & regression.
Comment 4 HTK300 2023-08-23 13:13:04 UTC
confirmed as with WRITER 7.6.0.3 (X86_64) and duplicate to my bug 156697
Comment 5 raal 2023-08-23 18:32:30 UTC
This seems to have begun at the below commit in bibisect repository/OS XXXX.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks
 29a39b72408b7090b1c3d439dc83b54416224599 is the first bad commit
commit 29a39b72408b7090b1c3d439dc83b54416224599
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Oct 4 21:42:03 2022 +0200

    source ca46afebb7dc0ec4375e995fa90edccbed6c2530

140947: default to 'flat' instead of '3D Look' for form controls | https://gerrit.libreoffice.org/c/core/+/140947
Comment 6 Kira Tubo 2023-11-03 01:30:58 UTC
*** Bug 157970 has been marked as a duplicate of this bug. ***
Comment 7 Robert Großkopf 2023-11-03 07:50:26 UTC Comment hidden (obsolete)
Comment 8 Robert Großkopf 2023-12-15 16:39:00 UTC
*** Bug 156697 has been marked as a duplicate of this bug. ***
Comment 9 HTK300 2023-12-16 09:05:35 UTC
Hi Robert, 
just tested this behaviour with LO V24.2.0.0 beta1, but text boxes remain with its properties to revert back to flat, even I edited it as 3D, saved it, reopened the base file.

let me know If I could further test anything
Comment 10 m_a_riosv 2024-07-18 21:35:03 UTC
*** Bug 162085 has been marked as a duplicate of this bug. ***
Comment 11 Justin L 2024-10-09 19:38:55 UTC
attachment 196982 [details]: textboxControl3D.odt: one flat and one 3d text box form control created in LO 7.5.9

The difference in the ODS is that the flat control has fo:border="solid #000000" while the 3D control simply has fo:border="#000000". [I don't see any mention of what fo:border values mean in the documentation.]

There is no use of form:visual-effect (which accepts flat or 3d) - this is only used for checkboxes/radio-boxes.

comment 5's commit was replaced by 7.6/7.5.4 for tdf#152974 revert change to ORichTextModel::getPropertyDefaultByHandle

Apparently, any of these strings should be valid in order to chose flat (2) or 3d (1) or nothing (0) for the property ControlBorder
const SvXMLEnumMapEntry<sal_uInt16> aBorderTypeMap[] =
    { XML_NONE,     0 },
    { XML_HIDDEN,   0 },
    { XML_SOLID,    2 },
    { XML_DOUBLE,   2 },
    { XML_DOTTED,   2 },
    { XML_DASHED,   2 },
    { XML_GROOVE,   1 },
    { XML_RIDGE,    1 },
    { XML_INSET,    1 },
    { XML_OUTSET,   1 },

The handling code is in xmloff/source/forms/controlpropertyhdl.cxx as well as in xmloff/source/style/bordrhdl.cxx (since solid also indicates border style).
Comment 12 Commit Notification 2024-10-10 16:53:10 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a617f77ee803eb65051e93f659ef66433879052

tdf#156707 xmloff import: always provide ControlBorder property

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 m_a_riosv 2024-11-11 22:43:58 UTC
*** Bug 163843 has been marked as a duplicate of this bug. ***