Created attachment 189129 [details] Sample slide (PPTX) 1. Open document, observe how "Rancher by SUSE" is rendered. 2. Enter presentation mode. 3. Observe how "Rancher by SUSE" hardly is visible any longer. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b5aaf194866c5e416167cb54d37f9f04dabc5375 CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Not showing the *text* of the logo properly is regression that happened between Version: 7.2.8.0.0+ / LibreOffice Community Build ID: d293877ff029ae7c161ccfbade992485fd92fe75 CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-2, Time: 2022-04-26_20:29:27 and Version: 7.3.8.0.0+ / LibreOffice Community Build ID: 0f7fb0a2decec3f8869098ae5e47ee6055545486 CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US
Created attachment 189130 [details] How it should look like (PowerPoint)
Created attachment 189131 [details] How LibreOffice currently renders it
The missing logo is covered by bug #156902.
But the first RANCHER is not text but free forms. Reproducible with Version: 7.6.0.3 (X86_64) / LibreOffice Community Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Bibisected on win-7.3 to: https://git.libreoffice.org/core/+/a9f6d98859321e1b9029acc0c6e9347f4c1cf3b7 author Armin Le Grand (Allotropia) <Armin.Le.Grand@me.com> Mon Jan 31 19:44:19 2022 +0100 committer Xisco Fauli <xiscofauli@libreoffice.org> Fri Feb 11 20:36:00 2022 +0100 tdf#126319 Corrected bitmap creation from metafile Adding CC to: Armin Le Grand
1st note: Text is a group object, as a workarund un-grouping it makes it appear.
Created attachment 189517 [details] Reduced bugdoc Also happens with reduced bugdoc - only the group object remains. The original had quite some objects, nearly invisible, below the BG graphic.
Looked at the bibisect from comment 5 (thanks!), but that seems the wrong trace. What I found is that the group object created from PPTX import contains 9 objects where 'BY SUSE' is a group itself where 'BY' is a group with 2 FreeForm objects (the letters) an 'SUSE' is a single freeform. All objjects are freeforms, BUT the group contains an invisible shape (use TAB to select) that has size(0,0) and pos(0,0) and all attr on default (fill blue, ...). If this shape is deleted, all works fine. It could be that this empty shape 'irritates' the conversion for SlideSHow somehow, but I e.g. get no BP hit @GraphicExporter::GetGraphic that I would normally get (and where the changes of the mentioned change are).
Ah - I see. That shape at (0,0) size (0,0) *is* the missing logo. Thus this task will be fixed when that is fixed (bug #156902). The BoundRect includes that shape, so (0,0,w,h) is displayed @the coordinates without hat shape -> smaller visualization, what we see. I could try to find out and fix that a shape with that dimensions/missing logo is imported, but that may then collide with the fix for bug #156902. There is definitely a difference between BoundRect(old) and BoundRange(new) based on primitives, though: the 2nd one includes those shapes - what is in principle more correct.
Checked for getB2DRange, but as I thought: It's an object at (0,0) with size(0,0). To *not* merge it when using getB2DRange would be wrong. This task just needs fixing of task bug #156902.
This seems to be better since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e84ae94270f0f0037fa2662a5f2765b37a50c33e author Regina Henschel <rb.henschel@t-online.de> 2023-10-07 17:37:46 +0200 committer Regina Henschel <rb.henschel@t-online.de> 2023-10-07 21:52:48 +0200 commit e84ae94270f0f0037fa2662a5f2765b37a50c33e (patch) tdf#156902 Do not set glow on group shape in import Now both the cow shape is visible and the RANCHER text is not small in presentation mode. Remaining issue is that the cow does not glow, which is a missing feature (bug 157661 now). Maybe we can refocus this as a reminder to properly import grouped shapes' glowing effect from OOXML.
Let's close this, Gabor. The issue I originally reported here is resolved thanks to Regina, and bug #157661 tracking the missing feature explicitly talks about PPTX and has a sample document.
Verified with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US and some earlier builds.