Created attachment 189567 [details] screenshot of LO Calc 7.5.6.2 (left) vs 24.2 alpha0+ In 7.6, the default colour for the active row(s), column(s) and cursor has changed from blue to red, when other VCL plugins make use of the OS/DE's default highlight colour. (Ubuntu/GNOME's default orange is picked up correctly in gtk3, kf5 and qt5 in my tests.) This is despite the cell range highlight still being a shade of blue. Some blue also remains in the borders and the corner drag square, making it even more inconsistent. See attachment 189299 [details] (top is 7.5, bottom is 7.6). Started with the fix for bug 145080: commit 258686a58f909ab04c7281c05f15882eb400748e author Heiko Tietze Wed May 17 16:48:30 2023 +0200 committer Heiko Tietze Tue May 23 09:44:21 2023 +0200 Resolves tdf#145080 - Use accent color for focused cell Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887 ... which was supposed to be a macOS fix. Repro on Ubuntu 20.04 with GNOME 3.36.8 with: Version: 7.6.1.1 (X86_64) / LibreOffice Community Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded and a recent master build: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4942aa1533af25cf102da7516bd5e521c553aa07 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Confirmed in bug 156800 for XFCE + x11 as well.
Maroon colour is: RGB: 127 0 0 HEX: #7f0000 Blue colour is: RGB: 0 0 127 HEX: #00007f Which I think match our COL_RED and COL_BLUE respectively. I see the commit added: maAccentColor = COL_RED Maybe related?
(@nouvo09: please don't change the Version field to a more recent one, it's supposed to be the earliest version affected.)
Not really a regression but missing function. Caolan, should/can the generic VCL pick some *accent* color from the OS? The easy alternative is to default to what we used in the past resp. the highlight color.
Dear Stéphane Guillou (stragu), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug