Bug 157360 - Offline Help (DE) triggers contact attempt to to piwik.documentfoundation.org
Summary: Offline Help (DE) triggers contact attempt to to piwik.documentfoundation.org
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.4.7.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.3
Keywords:
Depends on:
Blocks: New-Help
  Show dependency treegraph
 
Reported: 2023-09-21 07:29 UTC by Elisabeth Dapper
Modified: 2023-09-28 14:06 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elisabeth Dapper 2023-09-21 07:29:47 UTC
The help2.js script contains a function that triggers a contact attempt to piwik.documentfoundation.org when the help is opened with Chrome or Edge, even though they are in file mode. FireFox does not attempt to connect.
Since an "offline help" should be completely offline, I think this is a bug.

This may also be the reason for bug ID 140983


This is the part of the script help2.js: 
...
// Test, if we are online
if (document.body.getElementsByTagName('meta')) {
    var _paq = _paq || [];
    /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
    _paq.push(['disableCookies']);
    _paq.push(['trackPageView']);
    _paq.push(['enableLinkTracking']);
    (function() {
    var u="//piwik.documentfoundation.org/";
    _paq.push(['setTrackerUrl', u+'piwik.php']);
    _paq.push(['setSiteId', '68']);
    var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
    g.type='text/javascript'; g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
    })();
    var system = getParameterByName("System");
} else {
    var system = getSystem();
}
...

Discovered in
Version LO 7.4.7.2 x64 Community
with Hilfe 7.4 (German) (LibreOffice_7.4.7_Win_x64_helppack_de.msi)
but also found in Hilfe 7.5 (LibreOffice_7.5.6_Win_x64_helppack_de.msi)
Comment 1 Commit Notification 2023-09-26 07:05:34 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/0c24f409c31e4ca8a85b6a1486e2c6eaf26942d6

tdf#157360 Local help should not phone home
Comment 2 Commit Notification 2023-09-27 10:44:54 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/help/commit/c10e043fdaf6ed01727d99dfa3bcccd49ba9c527

tdf#157360 Local help should not phone home