Bug 157591 - context menu: "add to dictionary" -- no need to deselect word before
Summary: context menu: "add to dictionary" -- no need to deselect word before
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2023-10-04 09:35 UTC by peter josvai
Modified: 2024-07-16 10:21 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Windows context menu with Add to Dictionary (8.36 KB, image/png)
2023-10-05 04:35 UTC, Kira Tubo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description peter josvai 2023-10-04 09:35:02 UTC
hi, 


When you have a word "underlined" for correction, you can "add [it] to dictionary", but only if it is NOT selected at that moment.. 
If it is, you have to deselect it beforehand...

This is illogical in every sense, and I'm sure it'd be a great enhancement if even a presently selected word could be added to dictionary...

We wouldn't look for the "add to dictionary" menu item in the context menu just to realize that "oh, I have it selected", and go deselect it, and then place the cursor in the middle of it, and then go, again, right click... (look for it), and select "add to dictionary"...

ANOTHER enhancement could be the indication of which dictionary it is going to be added to... like "Add to dictionary (dictionary name)"



- - - -  thank you for developing Writer - - - -
Comment 1 Kira Tubo 2023-10-05 04:35:19 UTC
Created attachment 190024 [details]
Windows context menu with Add to Dictionary

I'm not able to reproduce on 7.6.2.1. If I right click on a word that needs to be corrected, the word is automatically selected and the context menu pops up with "Add to Dictionary" available as an option. See attachment. 

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

@peter josvai, Not sure which version of LO or OS you are using. In LO, go to Help > About LibreOffice and click on the Copy button, then paste the info as a comment on this bug report. This will help us troubleshoot the issue. I set the status to NEEDINFO. Please update it back to UNCONFIRMED once you respond. Thanks!
Comment 2 peter josvai 2024-03-08 11:16:45 UTC
(In reply to Kira Tubo from comment #1)
> Created attachment 190024 [details]
> Windows context menu with Add to Dictionary
> 
> I'm not able to reproduce on 7.6.2.1. If I right click on a word that needs
> to be corrected, the word is automatically selected and the context menu
> pops up with "Add to Dictionary" available as an option. See attachment. 
> 
> Version: 7.6.2.1 (X86_64) / LibreOffice Community
> Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
> CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (en_US); UI: en-US
> Calc: CL threaded
> 
> @peter josvai, Not sure which version of LO or OS you are using. In LO, go
> to Help > About LibreOffice and click on the Copy button, then paste the
> info as a comment on this bug report. This will help us troubleshoot the
> issue. I set the status to NEEDINFO. Please update it back to UNCONFIRMED
> once you respond. Thanks!


Kira, 
you're right but you're actually wrong :)

When you see a word that's underlined (cause it needs to be corrected), 
and you right click on it, 
you will see it highlighted. Just as you said.
And you'll be able to add it to the dictionary.

All is well so far.

But try going the other way around.

Pick a word that's underlined.
Select it (double click "in" the word).
Now it is highlighted. But this is a different situation. And a different "highlight", too, very probably.

Cause now you can't add it to a dictionary.

So, there are two approaches:

A. right click on word, 

B. select word (double click it)

Both will make the word highlighted, but there will be two different "context menus" popping up...


in case A.:

suggestion(s)
_______________ (sperarator)

Ignore
Ignore all
Add to dictionary
Spelling
_____________ (separator)

Always autocorrect to
Autocorrect options
_______________ (separator)

Set language for selection
Set language for paragraph


WHEREAS in case B.:

Cut
Copy
Paste
Paste special
_________________

Clone formatting
Clear direct formatting
Character 
paragraph
list
________________

Insert comment
Page style
Comment 3 QA Administrators 2024-03-09 03:15:38 UTC Comment hidden (obsolete)
Comment 4 Kira Tubo 2024-03-21 05:01:18 UTC
@peter josvai, thanks for clarifying! This makes much more sense now. 

But I wonder if this is by design. Because the way I see it: 

1. Context menu of the unselected misspelled word gives the user the option to spell check/add to dictionary. 

2. Context menu of selected misspelled word gives the user the option to stylize the word (rather than correcting/add to dictionary). 

If we were to replace context menu from #2 with #1, the user will no longer be able to stylize a misspelled word from a context menu. 

If we were to add only 'Add to dictionary' to context menu of #2, I don't know if it would be right to just add this category without giving the user the option to also correct misspelled words. 

Or maybe we combine context menu #1 and #2 specifically for misspelled words so that the user can correct misspelled words, add to dictionary, stylize words, etc. regardless of whether or not the misspelled word is selected/deselected. 

Adding UX team to advise.
Comment 5 Shantanu 2024-03-21 05:49:05 UTC
>> Or maybe we combine context menu #1 and #2 
>> specifically for misspelled words so that the user can correct 
>> misspelled words, add to dictionary, stylize words, etc. 
>> regardless of whether or not the misspelled word is selected/deselected
Yes. That is what being asked. 
It looks like a reasonable feature request.
Comment 6 Heiko Tietze 2024-03-21 09:35:50 UTC
Selection also means that more than one word is selected. And I'm not sure we want to allow this (although it's possible since bug 154499 has been done).

The spellchecking context menu is hard-coded in spellmenu.ui and sw/source/uibase/lingu/olmenu.cxx, and it sounds like some work. We should consider also the other way where users for example want to remove direct formatting from a misspelled word - not possible because the context is now spelling, see bug 62745 (and likely many others too).
Comment 7 Heiko Tietze 2024-07-16 10:21:09 UTC Comment hidden (no-value)