Created attachment 190817 [details] screenshot in LO 24.2alpha0+ Split from bug 122080, see bug 122080 comment 20. Steps to reproduce: 1. Open Impress, cancel the Template dialog 2. Expand Master Slides sidebar deck, apply Midnightblue template Result: stock blue instead of dark blue. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 79f92d09ec52f0777fc03ff1d057a11b45e73f6d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Bibisected with linux-64-7.0 repo to build commit [a2599bf44bb9b7ba90f34601f2d48991beb8a5b4] which points to: commit 7f10ae03e161545d10cca50030461b1ae530302e author andreas kainz Tue Apr 28 13:48:49 2020 +0200 committer andreas_kainz Tue Apr 28 17:29:48 2020 +0200 tdf#132138 Update Midnightblue impress template Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93061 Andreas, can you please have a look?
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded
Color is defined in Midnight template as a modification of "Accent 1" style. This modification is lost when changing master page. In Midnightblue template, color should be defined as an overloading of an existing style to be preserved.
(In reply to Laurent Balland from comment #2) > Color is defined in Midnight template as a modification of "Accent 1" style. > This modification is lost when changing master page. > In Midnightblue template, color should be defined as an overloading of an > existing style to be preserved. Thanks for the upcoming fix! I noticed what I understand to be an associated issue: 1. Open Impress, cancel template dialog, apply Midnightblue template from sidebar 2. View > Master Slide 3. Right-click on the top dark-blue rectangle > Edit Style... Because the style does not exist, the master view is stuck and can't be interacted with anymore. Your fix to the template does fix this issue, but I feel like we should still fail better when interacting with such broken master slides. I could imagine an error message like "The style does not exist, please apply a different one." What do you think?
(In reply to Stéphane Guillou (stragu) from comment #3) > I noticed what I understand to be an associated issue: I think it is more likely because my fix is not correct. I need more time to think about it.
(In reply to Laurent Balland from comment #4) > (In reply to Stéphane Guillou (stragu) from comment #3) > > I noticed what I understand to be an associated issue: > I think it is more likely because my fix is not correct. I need more time to > think about it. Ah yes, it does happen with you fixed template too, I hadn't noticed.
(In reply to Stéphane Guillou (stragu) from comment #3) > I noticed what I understand to be an associated issue: > 1. Open Impress, cancel template dialog, apply Midnightblue template from > sidebar > 2. View > Master Slide > 3. Right-click on the top dark-blue rectangle > Edit Style... The problem disappears when inheriting from "standard" instead of "Accent 1". Let's fix like that.
Laurent Balland committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b77c15fd6a12803073a0077a946b1e38d8a9107b tdf#158204 Midnightblue template correct color It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Laurent Balland committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/a5998d38b0f22fb0db713986ff20712b5e37e9dc tdf#158204 Midnightblue template correct color It will be available in 7.6.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 619500d6919c227e734b119481a4b334972e0b7b CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thank you!