Bug 158344 - FILEOPEN DOCX Crash on opening file
Summary: FILEOPEN DOCX Crash on opening file
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.3.2 release
Hardware: All All
: medium critical
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.7 target:7.6.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Table-Layouting DOCX-Floatingtable
  Show dependency treegraph
 
Reported: 2023-11-23 22:22 UTC by Gabor Kelemen (allotropia)
Modified: 2024-04-02 20:46 UTC (History)
6 users (show)

See Also:
Crash report or crash signature: ["SwTabFrame::MakeAll(OutputDevice*)"]


Attachments
Example file from Word 2016 (43.34 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-11-23 22:22 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-11-23 22:22:02 UTC
Created attachment 191006 [details]
Example file from Word 2016

Attached file crashes LO upon opening.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/8c24bc5baa1f501943bf955e07787d80cb7a5763

author	Michael Stahl <michael.stahl@allotropia.de>	Fri Aug 25 18:31:42 2023 +0200
committer	Michael Stahl <michael.stahl@allotropia.de>	Mon Aug 28 13:48:54 2023 +0200

(related? tdf#155177) sw: layout: fix another RemoveFollowFlowLine SNAFU
Comment 1 Stéphane Guillou (stragu) 2023-11-24 12:42:10 UTC
Crash on 7.6.3.2 with signature  SwTabFrame::MakeAll(OutputDevice*) : https://crashreport.libreoffice.org/stats/crash_details/e28823bd-e90b-4113-9af0-a6f8c930138d

Version: 7.6.3.2 (X86_64) / LibreOffice Community
Build ID: 29d686fea9f6705b262d369fede658f824154cc0
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Recent trunk build also crashes:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No crash in:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: f718d63693263970429a68f568db6046aaa9df01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Julien Nabet 2023-11-25 12:16:13 UTC
Just for the record no crash here on pc Debian x86-64 with master sources updated today + gtk3 rendering.
Comment 3 Julien Nabet 2023-11-25 12:17:06 UTC
I could also go to the last page (page 50)
Just noticing these last lines on console:
warn:legacy.osl:31045:31045:sw/source/core/layout/tabfrm.cxx:6202: Warning! Trying to prevent a crash
warn:legacy.osl:31045:31045:sw/source/core/layout/tabfrm.cxx:6202: Warning! Trying to prevent a crash
warn:unotools.config:31045:31045:unotools/source/config/lingucfg.cxx:399: unexpected property handle
warn:legacy.osl:31045:31045:sw/source/core/layout/tabfrm.cxx:6400: FollowTable without Lower
warn:sw.layout:31045:31045:sw/source/core/layout/tabfrm.cxx:942: Cannot remove in-use Follow Flow Line
Comment 4 Matt K 2024-02-09 02:12:14 UTC
No crash here, although it did hang for a few seconds upon opening:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 82ddb3809e6c4bf6c0f11830bd819864576daf65
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting to NEEDINFO
Comment 5 Gabor Kelemen (allotropia) 2024-03-08 20:30:26 UTC
Seems to be fixed in 24.2 since:

https://git.libreoffice.org/core/+/223d2fac61e061478721a7a4a89b1362f5037d8f

author	Miklos Vajna <vmiklos@collabora.com>	Wed Nov 22 08:31:17 2023 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	Wed Nov 22 09:57:04 2023 +0100

sw floattable: fix crash by trying harder to split tables

Thanks Miklos :)
Comment 6 Stéphane Guillou (stragu) 2024-03-12 11:54:12 UTC
Indeed, no crash anymore in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f42363c51672a5b3685b0b9b11e932680530dce3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Thanks everyone!
Comment 7 Commit Notification 2024-03-12 17:24:42 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/34fceee624ae1e478af145af37b76444780f8457

tdf#158344: sw floattable: fix crash by trying harder to split tables

It will be available in 7.6.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2024-03-13 09:39:53 UTC
Verified in

Version: 7.6.7.0.0+ (X86_64) / LibreOffice Community
Build ID: 34fceee624ae1e478af145af37b76444780f8457
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 9 Commit Notification 2024-03-19 17:05:08 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-6":

https://git.libreoffice.org/core/commit/660b60281d0626a73a4bc1b626a813a2ab1b9ee0

tdf#158344: sw floattable: fix crash by trying harder to split tables

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.