Description: Crash with floating table when changing to specific font size Steps to Reproduce: 1. Open attachment 191005 [details] (bug 158344 and bug 160106) 2. Place the cursor in the table 3. CTRL+A (2x) 4. Change fontsize to 24 -> Crash Bonus: 5. Change font size to 26 -> Freeze Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0020fc1167b3760d0631001689a44427b72b816e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL threaded
Reproducible Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Crash at opening with Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded I have tried to resave with Word but no success, still crash at opening. Added crash report signature.
Regarding the fileopen crash: (m_a_riosv, your crash report https://crashreport.libreoffice.org/stats/crash_details/2aae081f-3599-4d36-9506-8365850dac7b doesn't lead to anything, not sure why.) I also get a crash on open in 7.6.6.3 and 24.2.2.2: https://crashreport.libreoffice.org/stats/crash_details/209449ce-fa0d-4f03-98cb-05e6716f9a7c (same signature ["SwTabFrame::MakeAll(OutputDevice*)"] as for bug 158344) ...but it is fixed in master. In linux-64-24.8, it stopped crashing at build [ba26d9d81765ca45f3e8383714cf2b8eb077c07f] which is: commit 186de7178c6065e1de13fd216b46ac9b716e44c5 author Miklos Vajna Thu Feb 29 08:17:41 2024 +0100 committer Miklos Vajna Thu Feb 29 11:39:54 2024 +0100 tdf#158801 sw floattable: fix crash with headers and interactive editing Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164136 The cherrypick to 24.2 hasn't been merged yet: https://gerrit.libreoffice.org/c/core/+/164119 @miklos, you'd rather not get that in 7.6 because https://gerrit.libreoffice.org/c/core/+/163805 is not cherrypicked to that branch, correct? --- Regarding the font size crash: I reproduce in a recent trunk build too. It already crashes at the above quoted commit.
Created attachment 193479 [details] bt with console logs On pc Debian x86-64 with master sources updated today, I could reproduce this. Layout pb according to the bt.
> @miklos, you'd rather not get that in 7.6 Writer layout patches are always a bit risky, so at this point it's probably useful if floating table commits are only backported to 24.2 and not further. But as you like. :-) My suggestion was just that if a backport happens, then you don't selectively pick a specific fix, but all fixes up to that fix should also be backported, since I always just test master with and without a fix, not out of order fixes.
(In reply to Miklos Vajna from comment #4) And that's perfectly understandable, happy to go with your preference here if the chain of fixes is too hairy to backport :) Just noting that this document's fileopen: - started freezing in in 7.6.1 at 7278c1facfd675dd1972a01370de4425704d9a16 - started crashing in 7.6.2 at 9e453a7af284cf17cb0debd2ab027f626e6e4a62 But given that the signature is quite rare (9 reports currently), we can assume it doesn't affect many users, so let's just stick to 24.2 fixes: https://crashreport.libreoffice.org/stats/signature/SwTabFrame::MakeAll(OutputDevice*) Let's focus on the font size change crash then, targetting 24.2 and trunk!