Bug 158440 - Filter for background should take colors in empty cells
Summary: Filter for background should take colors in empty cells
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.4 target:7.6...
Keywords:
Depends on:
Blocks: Data-Filter
  Show dependency treegraph
 
Reported: 2023-11-29 14:52 UTC by Timur
Modified: 2024-10-29 08:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample (254.31 KB, application/vnd.oasis.opendocument.text)
2023-11-29 14:52 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2023-11-29 14:52:55 UTC
Created attachment 191114 [details]
Sample

Libreoffice has Color background filter, it works, except with empty cells.

Expected: all cells with a background colour are taken into account when making filter by color in Autofilter or Standard filter.
Comment 1 Timur 2023-11-29 14:55:23 UTC
This is now fixed in master 24.2. with:

https://gerrit.libreoffice.org/c/core/+/159238
sc: extend backcolor area

If the filter background color is selected,
the automatic selection area should include,
the attribute of background cell color too.

Signed-off-by: Henry Castro <hcastro@collabora.com>

https://gerrit.libreoffice.org/c/core/+/159905
sc: fix back color filter entries

The function "GetFilterEntries" iterates only that contains cell
data value entries, the background color filter feature requires
to iterate background color attribute which is not stored in multi
type vector cells.

Signed-off-by: Henry Castro <hcastro@collabora.com>
Comment 2 Xisco Faulí 2023-11-29 14:58:30 UTC
Thanks a lot Timur
Comment 3 Timur 2023-11-29 15:09:46 UTC
To search (hoepfully no regressions, but just in case):
sha 4abe6c83e76f825319e8b2a0c0b8b8e92177da65
sha 8b2369236dea7d6863c2df3d4ce5e356c9c8010c
Comment 4 Regis Perdreau 2023-11-29 18:05:25 UTC
Seems ok.
Comment 6 Commit Notification 2024-02-07 15:50:14 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5a609bc2dc1d1b4c1b9215d9ac8f5f1ba0939569

tdf#158440: do not extend transparent color

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-02-07 19:28:46 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/43451b31969db882cd6c36054f43915ffbd8f252

tdf#158440: do not extend transparent color

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-02-08 16:11:05 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d2ba2fa1123a07a9853124218342cc83c5176491

tdf#158440: do not extend transparent color

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-02-12 13:10:58 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cca29491a338cb7d43c373107bb73822e1d4e4a4

tdf#158440: sc: Add UItest

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-02-15 20:35:35 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-5":

https://git.libreoffice.org/core/commit/721c55f84684185fa8e4000f13dd46f12560fd09

tdf#158440: do not extend transparent color

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.