Description: Attached document does all of these extremely slowly: - Loading/Opening from scratch - Jumping to last page - PAGE UP from last page Steps to Reproduce: TEST #1: OPENING DOCUMENT 1) Double-Click on attached DOCX to open it. Microsoft Word 2016: - 43 secs LibreOffice 7.6.3: - 10 mins 20 secs While: - Microsoft Word initially opens it faster - LibreOffice is staring at a white loading screen After opening, they both still take quite a while to generate all the pages too... - - - - - - - - - - - TEST #2: JUMP TO FINAL PAGE + PAGE UP After document load: 1) Press Ctrl+End. - (To jump to the end of the document.) 2) After reaching final page and document finishes loading: - Press PAGE UP on keyboard. This is how long it takes: Microsoft Word 2016: 1) 28 secs 2) instant LibreOffice 7.6.3: 1) 7 mins 42 secs 2) >37 mins - (I gave up after 37 mins.) Actual Results: >1 hour of waiting. Expected Results: <2 minutes of waiting. Reproducible: Always User Profile Reset: No Additional Info: NOTE ON DOCUMENT: This was a DOCX document I generated by using ABBYY Finereader 12 to: - OCR a PDF. - Export to DOCX. It is a dictionary that is ~2 million words + ~1450 DOCX pages. (Original was ~910 pages of dense, triple-column text.) - - - Tested on: Version: 7.6.3.2 (X86_64) / LibreOffice Community Build ID: 29d686fea9f6705b262d369fede658f824154cc0 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded
Created attachment 191261 [details] The.Century.Dictionary.-.Volume.3[cu31924091890602].docx
There are apparently 895 headers (and 76 footers) in this document. That seems to be where the time is spent, importing those.
It is always good idea to test previous versions. File loaded in 80 seconds for me, until the regression commit from bug 133560, already in 7.5.6, 7.6.0 beta and 24.2 master: source ba07bfcda6b9f256f636708e52283be0f3a90c8a
Above commit is the main slow down, per my script bisect, that should be confirmed by opening file. Previous small slow down from 80 secs to 120 secs was in 7.3, 7.4, 7.5 d0a8f6857e93f1f4a26f05615618ff733bfb4851 author Vasily Melenchuk <vasily.melenchuk@cib.de> Mon Dec 27 2021 tdf#143703 sw: always assign name for fly section But somehow I was still seeing 80 secs before Mike's commit. For me, moral from this and other regression bugs I see is that changes should not be backported, except those for crashes or data loss.
(In reply to Timur from comment #4) > For me, moral from this and other regression bugs I see is that changes > should not be backported, except those for crashes or data loss. This is debatable :-) I tend to agree, when you backport to X.Y.7 - which will be the last in the branch. But otherwise, this regression shows why it is *a good thing* to backport: currently I still remember that patch, and it could help me fixing it; while if it wouldn't be backported, it only got filed 6+ months later, and recalling the details would be much harder (although for this case, I have no idea how to fix it - we should be correct first, *then* fast; and I am not an expert in perf bugs).
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dcae6615ed254cf7884fa6415f64561f85b93588 tdf#158556: provide objects anchored to node as a hidden property It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
So with the change I merged now, it is almost twice as fast opening this bugdoc on my system. Not as fast as before the change mentioned in comment 3, but that is likely as far as I can improve it; the change that introduced the more expensive algorithm can't be reverted completely, because that would make import wrong, as opposed to slow :-) Hopefully the problem of DOCX documents with hundreds images wouldn't be too widespread.
Note that the merged change doesn't address the other points mentioned in comment 0: slow navigation after opening. I guess, that that aspect (unrelated to the opening time regression) needs an own report, where it could be handled independently.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/2f9ecce61b0c806a33a9f641e43f4a71ed699fee tdf#158556: provide objects anchored to node as a hidden property It will be available in 24.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
On 24.8.0.0alpha0 (2024-01-06 02:53:39), it took: - 7 mins 49 secs for first paint... so about 25% better load speed for me. - - - This was the daily I used to test: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 25276df12abd9d002f7f899900434617b256f745 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - > I guess, that that aspect (unrelated to the opening time regression) needs an own report, where it could be handled independently. Should we treat Ctrl+End (then Page Up) as 2 separate performance bugs? Or just submit them as 1? Side Note: And while this document is still a tiny bit faster to paint... it's still *extremely* slow. (And the second I moved the mouse after load, I got another big white screen/freeze.)
(In reply to Tex2002ans from comment #10) > On 24.8.0.0alpha0 (2024-01-06 02:53:39), it took: > > - 7 mins 49 secs > > for first paint... so about 25% better load speed for me. Heh, it basically matches my findings - from the commit message: LibreOffice 7.6.0.3 (TDF build): real 8m37.386s Current master (my no-debug build): real 10m6.776s Current master with this patch (my no-debug build): real 5m41.524s ... so when I wrote "almost twice as fast", I only compared "immediately before the patch vs. after the patch", and something additionally slowed down the things between 7.6.0.3 and master ... > > I guess, that that aspect (unrelated to the opening time regression) needs an own report, where it could be handled independently. > > Should we treat Ctrl+End (then Page Up) as 2 separate performance bugs? Or > just submit them as 1? Please file it as a single bug. If that proves later to be different things, of course it might require a third one - but that's never a problem to do later :-D
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/241e2d68664e0e53cf02fe9986462c4a9ecd8d42 tdf#158556 speedup docx load It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/e4519e38d3598c3e26f2585bbc2553bc7ff5db4c tdf#158556 speedup docx load It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/284d80825ec7cf3c39af91959e4bf3d539b066f4 tdf#158556 speed up SwNodes::RemoveNode It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ab29c857c669bcca3d8eea8a5a9e6ad5eae622d7 tdf#158556 speedup docx load It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/77224aaec6ba89194a404805d7190f88e92fcc9f tdf#158556 speedup docx load It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The root of the remaining problem is how we create and update SwPageDesc. It is a very heavy object, and when we update it, we create one, then copy it to the destination document, then delete it. We should surely be able to short circuit this process somehow, by passing ownership of the new SwPageDesc to the document, but I'm not sure how, given how many constituent parts the SwPageDesc has.
Fantastic. Thank you so much, Noel. I can't wait to test the dailies again and see how much faster it got. :) (According to your notes, looks like it's ~30% the load time compared to a week ago!)
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/4126c6b94e87f7ad2a1aa93d66bbb3edf67ec790 tdf#158556 speedup docx load It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Comparing the opening times on my system, I see ~110s using LO v.7.2.0, and ~105s using v.24.2.3. Thanks to the immense Noel's work, I believe that this regression can be closed now?
(In reply to Mike Kaganski from comment #20) > Comparing the opening times on my system, I see ~110s using LO v.7.2.0, and > ~105s using v.24.2.3. Thanks to the immense Noel's work, I believe that this > regression can be closed now? Noel has one more patch for this one https://gerrit.libreoffice.org/c/core/+/167791
(In reply to Roman Kuznetsov from comment #21) > Noel has one more patch for this one > https://gerrit.libreoffice.org/c/core/+/167791 Sadly my patch did not work out. I believe there is still a lot of scope for improving the loading of this document, but I lack the requisite skills to work out what needs to be done. I am pretty sure we can bypass 2 or more layers of code and talk directly to the writer core.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f96e7720f765d4e5e8fdef6a2a2b8cbb75c81ef Revert "tdf#158556 speedup docx load" It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/f6f00606282f36b206ced9857b378e399d00dc65 Revert "tdf#158556 speedup docx load" It will be available in 24.8.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/da09d0110663108481ddeac0eb5b0613e8ed1a99 Revert "tdf#158556 speedup docx load" It will be available in 24.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2-5": https://git.libreoffice.org/core/commit/6e7906406a8e004774c5baf0f347573aacf63603 Revert "tdf#158556 speedup docx load" It will be available in 24.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4f222adca86d88ce8ee18c50b31485253a5398f9 tdf#158556 avoid unnecessary work It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cfd94adadb88ce0518d61269d47585192b0f0dfa tdf#158556 flatten SwStyleBase_Impl a little It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4a42fe00169c3a7d46db2e1a09d4b58b56dfccba tdf#158556 bypass some logic for toggle properties It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/60aeca980bbe6cd35d9ce530ea8704bc4ade7b7b tdf#158556 bypass some more logic for toggle properties It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/16c9053fe54b7c751b5c8c41ec7609199ebd6610 tdf#158556 move m_vIndices to SwNode It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/afe19beb79c3f88e42fd4b1d9b87cd324092197f tdf#158556 cache SwDocStyleSheet It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4f5d694e5840b0b9bda15dc120e8b07d18d4cbd0 tdf#158556 ByteGrabber does not need a mutex It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/79b931027ef682c71040cea8833a6f65e27f7982 tdf#158556 improve FindNumRulePtr It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14599c131345cc8847cdb72cfd6fe9e8239d5d1f tdf#158556 only set header flags once It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17aae4ddab1aad624779347d0fb914f635e7a4c7 tdf#158556 avoid dynamic_cast It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ef8fd1a72a6b45bfb046efad47e61c11e8277e4a tdf#158556 no need to create another cursor here It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d78a07573eac1960c8c6c736e6c05bf304f96cb1 tdf#158556 make SvxTabStopItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e0d424c707a380205f4c6e1530013ac3a3ea66cc tdf#158556 map->unordered_map It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c0c485676b753ad520f6fdaa83f3c6698fbb7369 tdf#158556 map->unordered_map It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d255a8306e7a26476fe11dbdcf38f6cb5665a48b tdf#158556 return 'const Value*' from Sprm::getValue It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0b49ac534a532b00bee69e96c4e9bc352fc82c4e tdf#158556 make SvxGrfCrop hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fc37b184eeaecee2f4d1d5cc7d6d032e59802cae tdf#158556 make SvxBoxItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/086fd5d0de83e5dbff8b69ed86b85274d9fa1c7a tdf#158556 make SfxInt16Item hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7e241c2babf3ad705619a120ffc71e475ce7bb7a tdf#158556 make SvxULSpaceItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7d3817289586d8765e066fee6551b66ddb5d0ab3 tdf#158556 improve SvxTabStopItem::hashCode It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ba0f68732ed89e11157dc618a697bfeb173c6252 tdf#158556 make SvxTextLeftMarginItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2b6a04f37e24e47984eb2539771a86cf7b08d4b tdf#158556 make SvxFirstLineIndentItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25541338ae51435b9c23fe69cfa4219096e2dd50 tdf#158556 make SfxGrabBagItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a111a1eff73b141c28b5ab87715eed62696f91a3 tdf#158556 make SwFormatPageDesc hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c4b613cda515e678a914a9bde4af3cc557532a6 tdf#158556 make SvxColorItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01d183d2290668c310d592bf2e4c298ddcfb10b4 tdf#158556 make SvxBrushItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e9594ac00a65c0a55286900265eadaa997e3f6ec tdf#158556 make SwGammaGrf hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7a648f23ecb67fbdbd29ac7a1d81db19f769ebb3 tdf#158556 make SwFormatDrop hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/978f0071425e89d21225bdd2976abe15e964b6c1 tdf#158556 make SvxLineSpacingItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/513b20a5f38cb3492d31e0262f0b278d77f653b0 tdf#158556 make SvxRightMarginItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1ba2b87ba52bf26e8cef667a35bfb7f2232acf11 tdf#158556 make SvxAdjustItem hashable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6e62e021e88f244c2de9a53a104e67b676fc2913 tdf#158556 simplify StylePool API It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/780728041982ff6980a9552a5b84dd9db6b9680c tdf#158556 no need to clone in OOXMLPropertySetValue::getProperties It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a6ad198d097fb4a503c8d5831d484ff46721134b tdf#158556 use more comphelper::ByteReader It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1a47d1e00ddadce2c4dc9e6d10fc815f8c7d9e59 tdf#158556 unnecessary temporary OUString in ZipFile It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9d806a68f4d8b21d80b8c0f35cb3a38d4b460aa tdf#158556 prevent lambda from allocating on heap It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fcc1b0d637807830c684741aad885986bc5b86db tdf#158556 avoid some temporary OOXMLPropertySet It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bf1099e360193e18c29e7b042dcc1480050a4e48 tdf#158556 reduce allocations in ZipFile It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b076e6a0b92ee989d31a8525cfab4636737b30dc tdf#158556 avoid a ton of temporary OUString It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.