Bug 158682 - Calc: Move rows with protected cells does not give warning
Summary: Calc: Move rows with protected cells does not give warning
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Cell-Sheet-Protection
  Show dependency treegraph
 
Reported: 2023-12-13 11:46 UTC by Timur
Modified: 2024-01-12 10:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2023-12-13 11:46:44 UTC
In Calc, have a sheet with some protected cells. 
Select a row or more containing some protected cells.
Mouse move those rows.
Move not possible, but there should be a warning message "Protected Cells Cannot be Modified".
Comment 1 Stéphane Guillou (stragu) 2023-12-27 15:33:15 UTC
Noting that if such a protected row is "moved" onto an unprotected row, the action _still_ copies the contents to the target (but doesn't remove the contents on the source row). Same behaviour with a cut-and-paste.

I agree that a message is needed, but I'm wondering if it needs to be different depending on the case, e.g:
- source is protected, target isn't: "Source contents not removed because cells are protected."
- cut action on protected cells: "Contents were copied but not removed because cells are protected"
- both source and target are protected: "Protected cells can not be modified." (the stock message)

UX/Design team, what do you think?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same in OOo 3.3.
Comment 2 Heiko Tietze 2024-01-02 14:15:23 UTC
Or we don't copy neither show the copying rectangle on moving the row. Too many warnings spoil the broth.
Comment 3 Stéphane Guillou (stragu) 2024-01-02 18:45:11 UTC
(In reply to Heiko Tietze from comment #2)
> Or we don't copy neither show the copying rectangle on moving the row. Too
> many warnings spoil the broth.
I think this silence could seem like a bug to users who don't realise the source is protected...

But what you suggest is online Office 365's behaviour: cutting a protected source is silently unallowed.
Looks like it's generally less chatty and only displays the warning message when trying to enter edit mode on a protected cell, or drag-filling it.
Comment 4 Heiko Tietze 2024-01-03 09:44:13 UTC
The missing feedback while moving should be a sufficient indicator.
Comment 5 Cor Nouws 2024-01-11 08:07:02 UTC
(In reply to Heiko Tietze from comment #4)
> The missing feedback while moving should be a sufficient indicator.
Possibly. Do you have a reasonable idea of the situation where a warning is given, or not?
Comment 6 Heiko Tietze 2024-01-12 10:36:19 UTC
We discussed the topic in the design meeting.

The conclusion is to use the stock message "Protected cells can not be modified." (not least to save the l10n team from additional work). In addition, the cursor should not change if DnD is not possible (or show a blocking symbol).