Bug 158710 - All icons and descriptions of animations behaviour in the animation list have disappeared
Summary: All icons and descriptions of animations behaviour in the animation list have...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard: target:24.8.0 target:7.6.5 target:24....
Keywords: bibisected, bisected, regression
: 159265 (view as bug list)
Depends on:
Blocks: Sidebar-Animation
  Show dependency treegraph
 
Reported: 2023-12-14 18:22 UTC by Andy
Modified: 2024-01-18 16:22 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
The User interface of the animation sidebar effect list in 6.1.4 and in 7.6.4.1 (88.29 KB, image/jpeg)
2023-12-14 18:27 UTC, Andy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy 2023-12-14 18:22:50 UTC
Description:
In impress the sidebar where you set animation effects has a list of these in the upper part. 
Normally each animation effect had an icon to the left of the object name that showed its start setting and a text right below the objwct name that identified the animation type. 
In 7.6.4.1 both have disappeared, and only the object name is visible in the list, making the monitoring and editing of the animations you have set slow and difficult.
See the attach for a comparison of the interface in 6.1.4 and 7.6.4

Steps to Reproduce:
1.Create an Impress doc
2.Put some objects in a slide, then open the sidebar on the animation tab and set any animation effect to some objects
3.the list of effect in the upper section of the tab shows only the objects name, all other info shown in previous LO versions are no more

Actual Results:
Only objects names are shown in the animation management sidebar

Expected Results:
The icons indicating the activation method and the effect type should be displayed as well


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: default; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 1 Andy 2023-12-14 18:27:55 UTC
Created attachment 191434 [details]
The User interface of the animation sidebar effect list in 6.1.4 and in 7.6.4.1

It is the same file opened with both versions
Comment 2 nutka 2023-12-15 16:45:07 UTC
On Windows 11:
- OK with version 7.5.9.2
- bug reproducible already with version 7.6.0.1
Comment 3 Stéphane Guillou (stragu) 2023-12-29 01:08:35 UTC
Not reproduced with the gtk3 VCL plugin, but reproduced with gen:

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29097009b1f8c0dcb050367d3f2acfcaf2074a56
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No repro in 7.5 -> regression.

Bibisection with linux-64-7.6 repo:

- Still good at [fa609c12e] source 33c2443134cfd2110258d5424645ace9e1db127f
- Can't start Impress since [b458474ec] (source 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b) and up to [595710182] (source 10cf767884de2c465304ef4b617d924e2d13630f) because of bug 155034
- Bad at [9cb93f1cb] source 1770d3ba3313f2166153d39be6ae1212c00da6d8

So relevant range is: https://git.libreoffice.org/core/+log/26bf26272bf525b59b4a4ce18b3ce14c1febfd7b..1770d3ba3313f2166153d39be6ae1212c00da6d8
This range could be bibisected on e.g. Windows or Ubuntu 22.04.
Comment 4 raal 2023-12-31 07:55:49 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-7.6.
Adding Cc: to Jim Raykowski ; Could you possibly take a look at this one?
Thanks
 5860e1c8208d0ecc254a53733c0d68c915e2785a is the first bad commit
commit 5860e1c8208d0ecc254a53733c0d68c915e2785a
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Oct 28 18:10:11 2023 +0200

    source 4bc86f6477c3ed5f0e97b0a530acf7e102b613b3

150451: tdf#38194 tdf#106556 Enhancement to highlight direct formatting, | https://gerrit.libreoffice.org/c/core/+/150451
Comment 5 Commit Notification 2024-01-01 04:13:42 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7e378516bc596d0308bcb1c974760c224f516ea6

tdf#158710 Fix animation list custom rendering for vcl gen plugin

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Jim Raykowski 2024-01-01 05:06:01 UTC
Happy New Year All!

There is one other place I found in the codebase that does custom rendering of list entries. It likely needs the same kind of patch done for this report for vcl gen type backends to display as expected. Although, the class doesn't seem to be used anywhere in the codebase. Any insight would be appreciated.

https://opengrok.libreoffice.org/xref/core/sfx2/source/appl/newhelp.hxx?r=b6b26421#87
Comment 7 Commit Notification 2024-01-09 08:49:41 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/3004515ce6d9c9c655105af901837e95bae7fb9a

tdf#158710 Fix animation list custom rendering for vcl gen plugin

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-01-09 08:49:44 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/1fbd5001854e27415796beff0de48df0912a7b47

tdf#158710 Fix animation list custom rendering for vcl gen plugin

It will be available in 24.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Buovjaga 2024-01-18 16:20:32 UTC
*** Bug 159265 has been marked as a duplicate of this bug. ***
Comment 10 Buovjaga 2024-01-18 16:22:15 UTC
Also fixed for kf5 and Windows