Bug 158810 - Template Management - useless Actions button which does nothing when clicked
Summary: Template Management - useless Actions button which does nothing when clicked
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.8.0 target:24.2.0.2
Keywords:
: 158832 (view as bug list)
Depends on:
Blocks: Start-Center Templates
  Show dependency treegraph
 
Reported: 2023-12-21 13:30 UTC by Alex Thurgood
Modified: 2024-01-05 12:38 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2023-12-21 13:30:57 UTC
Description:
1) Open LibreOffice StartCenter

2) Click on Templates

3) Move the mouse to the right hand side and click on the Actions button - nothing happens.

How is the user supposed to manage templates from this button, if it doesn't do anything ?

If it isn't supposed to do anything because that's the way it is programmed, why is it even there in the first place ?



Steps to Reproduce:
1) Open LibreOffice StartCenter

2) Click on Templates

3) Move the mouse to the right hand side and click on the Actions button - nothing happens.



Actual Results:
Nothing happens.

Expected Results:
The button should either work, i.e. propose a menu with executable actions, or else be removed.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.9.2 (AARCH64) / LibreOffice Community
Build ID: cdeefe45c17511d326101eed8008ac4092f278a9
CPU threads: 8; OS: Mac OS X 14.1.1; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
Comment 1 Alex Thurgood 2023-12-21 13:35:13 UTC
Problem also reproducible in 

LibreOfficeDev

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 31fb3045dabdb27d913712f3abcade315e3ea9bd
CPU threads: 8; OS: macOS 14.1.1; UI render: Skia/Raster; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2023-12-27 08:49:42 UTC
*** Bug 158832 has been marked as a duplicate of this bug. ***
Comment 3 Stéphane Guillou (stragu) 2023-12-27 08:59:05 UTC
Started since the addition of the top controls in 7.5 (Filter and Actions) for bug 80934.

I guess such a button could have the some of the same options as the template manager's "Manage" menu? For example:
- Import
- Extensions
- Open template manager (to access further options, like categories)

Heiko, what do you think?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 4 Heiko Tietze 2024-01-02 14:20:05 UTC
The action button allows to clear recently used or unavailable documents from the view. It is disabled in the templates view mode, and we can either disabled the commands and keep the hamburger menu enabled (my take) or hide it completely. Or keep the state of affairs.
Comment 5 Alex Thurgood 2024-01-02 17:26:48 UTC
(In reply to Heiko Tietze from comment #4)
> The action button allows to clear recently used or unavailable documents
> from the view. It is disabled in the templates view mode, and we can either
> disabled the commands and keep the hamburger menu enabled (my take) or hide
> it completely. Or keep the state of affairs.

I'm having trouble understanding :
- why we would leave a hamburger which offers no possible interaction at all;
- why we would need a hamburger with actions to clear unavailable document templates - shouldn't these just be cleared automatically on next startup of an LO session (the same argument could be made for documents that are no longer available to the recent documents view of the StartCenter, i.e. automatic removal, but I digress from this report) ?

If the hamburger has no available operations, it shouldn't IMHO even be there, as otherwise it implies that a functionality is available, which isn't. This is what prompted me to report the issue in the first place, as I mistakenly believed that the hamburger allowed access to the template management aspects of the template preview window.
Comment 6 sdc.blanco 2024-01-02 20:50:11 UTC Comment hidden (off-topic)
Comment 7 Heiko Tietze 2024-01-03 09:01:15 UTC
(In reply to Alex Thurgood from comment #5)
> - why we would leave a hamburger which offers no possible interaction at all;
Temporarily unavailable interactions are disabled. The UI becomes very busy if you hide/show to many controls depending on the context. And users should be aware of potential interactions. The question is always what is temporarily. And for dropdown menus it's a good practice to disable the items rather than the menu.

> - why we would need a hamburger with actions to clear unavailable document templates
The button is for recent documents, and disabled in case of templates.
Comment 8 sdc.blanco 2024-01-03 14:33:30 UTC
(In reply to Heiko Tietze from comment #4)
> can either disabled the commands and keep the hamburger menu enabled (my take) 
> or hide it completely
> Or keep the state of affairs.
Last option seems least preferable, because as OP and comment 5 indicate (and I agree), the current state of affairs appears "broken".

No strong opinion about other two options. Hiding seems ok in this case, in that Templates and Recent documents do not have any connection, and hamburger menu is only used for these two options.

A fourth option would be to move the hamburger menu to a dropdown from the Recent Documents button (with the two options (clear, remove) in the dropdown).  
That seems the best to me because (a) the hamburger menu is not particularly visible, (b) it removes the confusion with the templates, and (c) most important, it highlights these options/choices in relation to recent documents.
Comment 9 Commit Notification 2024-01-04 10:23:36 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc03109024041ea00bb62e90975e9a20a3668101

Resolves tdf#158810 - Hide recent actions while in template mode

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-01-05 12:38:50 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/a19137e28c86b9ff118f3cfdd52554e7c326357c

Resolves tdf#158810 - Hide recent actions while in template mode

It will be available in 24.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.