Bug 159086 - UI Checkboxes under GTK3 not disabled when settings are locked down from config
Summary: UI Checkboxes under GTK3 not disabled when settings are locked down from config
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.0.2
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2024-01-09 13:05 UTC by Gabor Kelemen (allotropia)
Modified: 2024-08-28 10:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the issue under GTK3 (96.79 KB, image/png)
2024-01-09 13:05 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-01-09 13:05:59 UTC
Created attachment 191824 [details]
Screenshot of the issue under GTK3

This is followup to bug 157861

If the example extension of that bug attachment 190350 [details] is installed, the checkboxes in the treeview are not greyed out. Happens only under GTK3 vclplugin, it's good with gen/qt5/windows.

1. Install the attachment 190350 [details] extension, restart LO
2. Open Tools - Options - Load/Save - Microsoft Office
-> the checkboxes in the Embedded Objects list can be enabled/disabled. Checking most all of them and pressing OK also crashes LO.

Version: 24.2.0.1.0+ (X86_64) / LibreOffice Community
Build ID: 9558616fdac9e58282c5d07d8345410b5479dc2b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

from bibisect-24.2-linux repo.
Comment 1 Gabor Kelemen (allotropia) 2024-01-09 13:19:48 UTC
As another example, the attachment 190728 [details] from bug 158003 makes the Options list of the Languages & Locales - Writing Aids tabpage correctly disabled, even under GTK3. There is only one column of checkboxes, so maybe a little different.

@Caolán: can you give some code pointers into this issue?
Comment 2 Caolán McNamara 2024-01-10 20:27:50 UTC
https://gerrit.libreoffice.org/c/core/+/161899 should resolve this and work as a guide if it turns up in other places where it didn't matter until now
Comment 3 Commit Notification 2024-01-11 10:07:44 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d6996f399b82fb0482850829349a4bf1647529b2

Resolves: tdf#159086 add sensitive model<->treeview mappings for checkboxes

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2024-01-11 11:13:40 UTC
hope that helps, don't know if it needs to be backport to anywhere, presumably you can take care of that if this works as wanted and needs to be backported anywhere
Comment 5 Commit Notification 2024-01-11 17:16:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/06a0b52124a4db7a3d59f3cc9f2c858e68cd70c0

Resolves: tdf#159086 add sensitive model<->treeview mappings for checkboxes

It will be available in 24.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.