Bug 159138 - Hyperlink dialog is too large when there is a long text in the clipboard
Summary: Hyperlink dialog is too large when there is a long text in the clipboard
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-11 17:50 UTC by Xisco Faulí
Modified: 2024-01-15 13:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (56.48 KB, image/png)
2024-01-11 17:50 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2024-01-11 17:50:26 UTC
Created attachment 191880 [details]
screenshot

Steps to reproduce:
1. Copy some text ( I used the linux terminal )
2. Open Writer
3. Insert - Hyperlink

The dialog doesn't fit in the screen.
This is happening since

author	Andreas Heinisch <andreas.heinisch@yahoo.de>	2023-07-26 10:31:56 +0200
committer	Andreas Heinisch <andreas.heinisch@yahoo.de>	2023-07-27 09:01:57 +0200
commit 89d3735e05b98223a49a387421386fd736fc3de6 (patch)
tree e5891f7cda1cd34b4d1040b5f2c1ee705ebaae1a
parent cf8f7b91f41821b79495c0388359c4cb1156ea67 (diff)
tdf#146576 - Propose clipboard content when inserting a hyperlink
Comment 1 Xisco Faulí 2024-01-11 17:53:17 UTC
My take on it https://gerrit.libreoffice.org/c/core/+/161926
Comment 2 Xisco Faulí 2024-01-12 09:33:32 UTC
I've been thinking a bit more about this issue and ignoring the clipboard content with spaces doesn't look like the real fix to me. Instead, I think we should not expand the dialog depending on the content of the URL field. Same happens with the Text field, even if there is a long text selected in Writer, the dialog size is the same.
@Caolán, I thought you might also be interested in this issue
Comment 3 Caolán McNamara 2024-01-12 10:02:19 UTC
It appears to be the GtkLabel labelled by "URL:" in the "Document" tab which ends up controlling the width of the dialog, the url ComboBoxes already limit themselves to their initial width to avoid problems like this.
Comment 4 Commit Notification 2024-01-12 11:30:45 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/a25b8e353e3ac6383a63f3626b2d0cb88baaf872

Resolves: tdf#159138 don't expand dialog to fit excessively long urls

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-01-12 13:53:00 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2da068327d18b7e8d63a17001a7abb4d9e350411

Resolves: tdf#159138 don't expand dialog to fit excessively long urls

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2024-01-12 14:26:45 UTC
The dialog looks too small to me on gen, but seems to be like that before this set of changes. So if that's a problem then it is unchanged. The too wide issue should be solved now however.
Comment 7 Commit Notification 2024-01-15 13:50:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2-0":

https://git.libreoffice.org/core/commit/e0237d26c6b07f79ab7d4c702b0d0c4241039ac2

Resolves: tdf#159138 don't expand dialog to fit excessively long urls

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.